725571 - make property values of accessibleProperties view selectable

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 1

[[e-mail]]

Comment on attachment 595658 [details] [diff] [review]
patch

>     // accessible bounds
>     var x = { value: 0 };
>     var y = { value: 0 };
>     var width = {value: 0 };
>     var height = {value: 0 };
>     this.mAccSubject.getBounds(x, y, width, height);
...
>+      gBundle.getFormattedString("accBounds",
>+                                 [x.value, y.value, width.value, height.value]);
Would you mind moving this code into a new get bounds() method, and changing the textbox to use prop="bounds" instead, so that it's handled by the loop?

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch2

Comment 3

[[e-mail]]

Comment on attachment 595715 [details] [diff] [review]
patch2

>       if (value instanceof Array)
>         containers[i].textContent = value.join(", ");
>       else
>         containers[i].textContent = value;
You need to change these from .textContent to .value so that they work properly with textboxes. (I'm surprised you see any text at all, I have no idea how that works.) r=me with that fixed.

>+    var x = { value: 0 };
>+    var y = { value: 0 };
>+    var width = {value: 0 };
>+    var height = {value: 0 };
[Nit: could put space after { for consistency.]

Comment 4

[alexander :surkov (:asurkov)]

landed with Neil's comments addressed http://hg.mozilla.org/dom-inspector/rev/71bb135f8a06