Closed Bug 725571 Opened 10 years ago Closed 10 years ago

make property values of accessibleProperties view selectable

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
No description provided.
Attachment #595658 - Flags: review?(neil)
Comment on attachment 595658 [details] [diff] [review]
patch

>     // accessible bounds
>     var x = { value: 0 };
>     var y = { value: 0 };
>     var width = {value: 0 };
>     var height = {value: 0 };
>     this.mAccSubject.getBounds(x, y, width, height);
...
>+      gBundle.getFormattedString("accBounds",
>+                                 [x.value, y.value, width.value, height.value]);
Would you mind moving this code into a new get bounds() method, and changing the textbox to use prop="bounds" instead, so that it's handled by the loop?
Attached patch patch2Splinter Review
Attachment #595658 - Attachment is obsolete: true
Attachment #595658 - Flags: review?(neil)
Attachment #595715 - Flags: review?(neil)
Comment on attachment 595715 [details] [diff] [review]
patch2

>       if (value instanceof Array)
>         containers[i].textContent = value.join(", ");
>       else
>         containers[i].textContent = value;
You need to change these from .textContent to .value so that they work properly with textboxes. (I'm surprised you see any text at all, I have no idea how that works.) r=me with that fixed.

>+    var x = { value: 0 };
>+    var y = { value: 0 };
>+    var width = {value: 0 };
>+    var height = {value: 0 };
[Nit: could put space after { for consistency.]
Attachment #595715 - Flags: review?(neil) → review+
landed with Neil's comments addressed http://hg.mozilla.org/dom-inspector/rev/71bb135f8a06
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.