Closed Bug 725575 Opened 11 years ago Closed 11 years ago

add outputDOMAttrs function to accessibleEvents viewer

Categories

(Other Applications :: DOM Inspector, defect)

Product:
Other Applications
Component:
DOM Inspector
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

Details

Attachments

(1 file)

patch
2.76 KB, patch
crussell
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
      No description provided.
Attachment #595660 - Flags: review?(Sevenspade)
Summary: add outputDOMAttrs to accessibleEvents viewer → add outputDOMAttrs function to accessibleEvents viewer
Comment on attachment 595660 [details] [diff] [review]
patch

Review of attachment 595660 [details] [diff] [review]:
-----------------------------------------------------------------

::: resources/content/viewers/accessibleEvents/accessibleEvents.js
@@ +1086,5 @@
> +  var DOMNode = QIAccessNode(aAccessible).DOMNode;
> +  var DOMAttributes = DOMNode.attributes;
> +  for (let i = 0; i < DOMAttributes.length; i++) {
> +    var DOMAttribute = DOMAttributes.item(i);
> +    output(DOMAttribute.nodeName + ": " + DOMAttribute.nodeValue);

Attribute nodes are going away (bug 611787).  Instead of |nodeName| and |nodeValue|, just use |name| and |value|, respectively.

r+ with that change.
Attachment #595660 - Flags: review?(Sevenspade) → review+
http://hg.mozilla.org/dom-inspector/rev/67f897bde847 with Colby's comment fixed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.