Closed Bug 730260 Opened 8 years ago Closed 8 years ago

Add the comm-central source stamp to SeaMonkey's source stamp file

Categories

(SeaMonkey :: Build Config, enhancement, P3)

enhancement

Tracking

(seamonkey2.7 wontfix, seamonkey2.8 verified, seamonkey2.9 verified)

VERIFIED FIXED
seamonkey2.10
Tracking Status
seamonkey2.7 --- wontfix
seamonkey2.8 --- verified
seamonkey2.9 --- verified

People

(Reporter: glandium, Assigned: sgautherie)

References

Details

Attachments

(1 file)

See for example:
ftp://ftp.mozilla.org/pub/mozilla.org/seamonkey/nightly/latest-comm-aurora/seamonkey-2.9a2.en-US.linux-i686.txt

which only contains the mozilla-aurora changeset corresponding to the build.

Compare to the same thing for thunderbird:
ftp://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-comm-aurora/thunderbird-12.0a2.en-US.linux-i686.txt

Where there is both the mozilla-aurora and the comm-aurora changeset.

This applies to comm-central as well (which, by the way, is comm-central-trunk for seamonkey, which is kind of annoying)

(Not sure this is the right component)
Assignee: nobody → bugspam.Callek
So, I'm not sure when I'd get to this, but its a build-config change required.

Just need to port the relevent code from 

http://mxr.mozilla.org/comm-central/source/mail/installer/Makefile.in#155

to suite/installer/Makefile.in
Assignee: bugspam.Callek → nobody
Component: Release Engineering → Build Config
Product: mozilla.org → SeaMonkey
QA Contact: release → build-config
Whiteboard: [good first bug][lang=make][mentor=Callek]
Version: other → Trunk
Assignee: nobody → sgautherie.bz
Blocks: 630487
Severity: normal → enhancement
Status: NEW → ASSIGNED
Depends on: 630176
Flags: in-testsuite-
Priority: -- → P3
Summary: Seamonkey aurora and central .txt files don't contain comm-central changeset → SeaMonkey aurora and central .txt files don't contain comm-central changeset
Target Milestone: --- → seamonkey2.10
Summary: SeaMonkey aurora and central .txt files don't contain comm-central changeset → Add the comm-central source stamp to SeaMonkey's source stamp file
Attachment #600623 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 600623 [details] [diff] [review]
(Av1) Add the comm-central source stamp to SeaMonkey's source stamp file
[Checked in: Comments 4 and 9]

[Triage Comment]
Attachment #600623 - Flags: approval-comm-aurora+
Comment on attachment 600623 [details] [diff] [review]
(Av1) Add the comm-central source stamp to SeaMonkey's source stamp file
[Checked in: Comments 4 and 9]

http://hg.mozilla.org/comm-central/rev/d1ac5a54d43d


Succeeded as
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=d3d05e6f4e08
https://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/sgautherie.bz@free.fr-d3d05e6f4e08/try-comm-central-linux64/thunderbird-13.0a1.en-US.linux-x86_64.txt
Attachment #600623 - Attachment description: (Av1) Add the comm-central source stamp to SeaMonkey's source stamp file → (Av1) Add the comm-central source stamp to SeaMonkey's source stamp file [Checked in: Comment 4]
Attachment #600623 - Flags: approval-comm-beta?
(In reply to Serge Gautherie (:sgautherie) from comment #4)
> Succeeded as
> http://build.mozillamessaging.com/tinderboxpushlog/
> ?tree=ThunderbirdTry&rev=d3d05e6f4e08
> https://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/sgautherie.
> bz@free.fr-d3d05e6f4e08/try-comm-central-linux64/thunderbird-13.0a1.en-US.
> linux-x86_64.txt

Bah, that was a TB build: I forgot to add the mozconfig-extra :-<
Comment on attachment 600623 [details] [diff] [review]
(Av1) Add the comm-central source stamp to SeaMonkey's source stamp file
[Checked in: Comments 4 and 9]

Review of attachment 600623 [details] [diff] [review]:
-----------------------------------------------------------------

Sure why not.
Attachment #600623 - Flags: approval-comm-beta? → approval-comm-beta+
/pub/seamonkey/tinderbox-builds/comm-central-trunk-linux64/1330200469
seamonkey-2.10a1.en-US.linux-x86_64.txt

V.Fixed
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=make][mentor=Callek] → [c-n: d1ac5a54d43d to c-a and c-b]
Status: RESOLVED → VERIFIED
(In reply to Mike Hommey [:glandium] from comment #0)
> This applies to comm-central as well (which, by the way, is
> comm-central-trunk for seamonkey, which is kind of annoying)

Yes, and I think we should change that. I stumbled over it when trying to explain to the Firebug guys how to update their automatic tests to fetch current SM trunk nightlies, and SM is indeed an exception here ("mozilla-central" for FF, "comm-central" for TB). Callek, do you need a bug/vote/discussion for that?
Comment on attachment 600623 [details] [diff] [review]
(Av1) Add the comm-central source stamp to SeaMonkey's source stamp file
[Checked in: Comments 4 and 9]

http://hg.mozilla.org/releases/comm-aurora/rev/99185e5ec92c
http://hg.mozilla.org/releases/comm-beta/rev/37e4f685aeba
Attachment #600623 - Attachment description: (Av1) Add the comm-central source stamp to SeaMonkey's source stamp file [Checked in: Comment 4] → (Av1) Add the comm-central source stamp to SeaMonkey's source stamp file [Checked in: Comments 4 and 9]
Keywords: checkin-needed
Whiteboard: [c-n: d1ac5a54d43d to c-a and c-b]
(In reply to Jens Hatlak (:InvisibleSmiley) from comment #8)
> (In reply to Mike Hommey [:glandium] from comment #0)
> > This applies to comm-central as well (which, by the way, is
> > comm-central-trunk for seamonkey, which is kind of annoying)
> 
> Yes, and I think we should change that. I stumbled over it when trying to
> explain to the Firebug guys how to update their automatic tests to fetch
> current SM trunk nightlies, and SM is indeed an exception here
> ("mozilla-central" for FF, "comm-central" for TB). Callek, do you need a
> bug/vote/discussion for that?

I *think* there is a bug on file somewhere for that, but I can't recall... if not please do file one.

The issue with doing that is that there are a bunch of hidden gotchya's with changing it, and I need to find time to audit each one..... For history we did initially make it comm-central-trunk due to the divergent nature of comm-central needing to track both trunk and a branch rev of m-c. For a while.
(In reply to Justin Wood (:Callek) from comment #10)
> if not please do file one.

I filed bug 730651.
You need to log in before you can comment on or make changes to this bug.