730260 - Add the comm-central source stamp to SeaMonkey's source stamp file

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, enhancement, P3)

Description

[Mike Hommey [:glandium]]

See for example:
ftp://ftp.mozilla.org/pub/mozilla.org/seamonkey/nightly/latest-comm-aurora/seamonkey-2.9a2.en-US.linux-i686.txt

which only contains the mozilla-aurora changeset corresponding to the build.

Compare to the same thing for thunderbird:
ftp://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-comm-aurora/thunderbird-12.0a2.en-US.linux-i686.txt

Where there is both the mozilla-aurora and the comm-aurora changeset.

This applies to comm-central as well (which, by the way, is comm-central-trunk for seamonkey, which is kind of annoying)

(Not sure this is the right component)

Comment 1

[Justin Wood (:Callek)]

So, I'm not sure when I'd get to this, but its a build-config change required.

Just need to port the relevent code from 

http://mxr.mozilla.org/comm-central/source/mail/installer/Makefile.in#155

to suite/installer/Makefile.in

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Add the comm-central source stamp to SeaMonkey's source stamp file [Checked in: Comments 4 and 9]

Trivial copy of TB code.

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 600623 [details] [diff] [review]
(Av1) Add the comm-central source stamp to SeaMonkey's source stamp file
[Checked in: Comments 4 and 9]

[Triage Comment]

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 600623 [details] [diff] [review]
(Av1) Add the comm-central source stamp to SeaMonkey's source stamp file
[Checked in: Comments 4 and 9]

http://hg.mozilla.org/comm-central/rev/d1ac5a54d43d


Succeeded as
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=d3d05e6f4e08
https://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/[e-mail]-d3d05e6f4e08/try-comm-central-linux64/thunderbird-13.0a1.en-US.linux-x86_64.txt

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #4)
> Succeeded as
> http://build.mozillamessaging.com/tinderboxpushlog/
> ?tree=ThunderbirdTry&rev=d3d05e6f4e08
> https://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/sgautherie.
> [e-mail]-d3d05e6f4e08/try-comm-central-linux64/thunderbird-13.0a1.en-US.
> linux-x86_64.txt

Bah, that was a TB build: I forgot to add the mozconfig-extra :-<

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 600623 [details] [diff] [review]
(Av1) Add the comm-central source stamp to SeaMonkey's source stamp file
[Checked in: Comments 4 and 9]

Review of attachment 600623 [details] [diff] [review]:
-----------------------------------------------------------------

Sure why not.

Comment 7

[Serge Gautherie (:sgautherie)]

/pub/seamonkey/tinderbox-builds/comm-central-trunk-linux64/1330200469
seamonkey-2.10a1.en-US.linux-x86_64.txt

V.Fixed

Comment 8

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Mike Hommey [:glandium] from comment #0)
> This applies to comm-central as well (which, by the way, is
> comm-central-trunk for seamonkey, which is kind of annoying)

Yes, and I think we should change that. I stumbled over it when trying to explain to the Firebug guys how to update their automatic tests to fetch current SM trunk nightlies, and SM is indeed an exception here ("mozilla-central" for FF, "comm-central" for TB). Callek, do you need a bug/vote/discussion for that?

Comment 9

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 600623 [details] [diff] [review]
(Av1) Add the comm-central source stamp to SeaMonkey's source stamp file
[Checked in: Comments 4 and 9]

http://hg.mozilla.org/releases/comm-aurora/rev/99185e5ec92c
http://hg.mozilla.org/releases/comm-beta/rev/37e4f685aeba

Comment 10

[Justin Wood (:Callek)]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #8)
> (In reply to Mike Hommey [:glandium] from comment #0)
> > This applies to comm-central as well (which, by the way, is
> > comm-central-trunk for seamonkey, which is kind of annoying)
> 
> Yes, and I think we should change that. I stumbled over it when trying to
> explain to the Firebug guys how to update their automatic tests to fetch
> current SM trunk nightlies, and SM is indeed an exception here
> ("mozilla-central" for FF, "comm-central" for TB). Callek, do you need a
> bug/vote/discussion for that?

I *think* there is a bug on file somewhere for that, but I can't recall... if not please do file one.

The issue with doing that is that there are a bunch of hidden gotchya's with changing it, and I need to find time to audit each one..... For history we did initially make it comm-central-trunk due to the divergent nature of comm-central needing to track both trunk and a branch rev of m-c. For a while.

Comment 11

[Serge Gautherie (:sgautherie)]

ftp://ftp.mozilla.org/pub/mozilla.org/seamonkey/tinderbox-builds/comm-aurora-macosx-debug/1330219790/seamonkey-2.9a2.en-US.mac.txt

ftp://ftp.mozilla.org/pub/mozilla.org/seamonkey/tinderbox-builds/comm-beta-macosx64/1330219790/seamonkey-2.8.en-US.mac.txt

seamonkey2.9 and seamonkey2.8: verified.

Comment 12

[Serge Gautherie (:sgautherie)]

(In reply to Justin Wood (:Callek) from comment #10)
> if not please do file one.

I filed bug 730651.