Closed
Bug 731219
Opened 13 years ago
Closed 13 years ago
XMLRPC content-type verification fails if a charset is provided
Categories
(Bugzilla :: WebService, defect, P1)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.0
People
(Reporter: glob, Assigned: glob)
References
Details
(Keywords: regression)
Attachments
(1 file)
715 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
following the change in bug 725663, if an xmlrpc client sets the charset as part of its content-type header, we're incorrect rejecting the request.
for example, ruby's xmlrpc library sends a content-type of "text/xml; charset=utf-8" which results in "Only text/xml and application/xml are allowed."
![]() |
||
Updated•13 years ago
|
Target Milestone: --- → Bugzilla 4.0
![]() |
||
Updated•13 years ago
|
Comment 3•13 years ago
|
||
Comment on attachment 601276 [details] [diff] [review]
patch v1
Review of attachment 601276 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good and passes testing r=dkl
Attachment #601276 -
Flags: review?(dkl) → review+
![]() |
||
Updated•13 years ago
|
Flags: approval4.2+
Flags: approval4.0+
Flags: approval+
Comment 5•13 years ago
|
||
This needs to be immediately pushed to bmo, as it's causing major production issues for webtools that use the API.
Severity: major → blocker
Priority: -- → P1
(In reply to Reed Loden [:reed] (very busy) from comment #5)
> This needs to be immediately pushed to bmo, as it's causing major production
> issues for webtools that use the API.
agreed; i'll liaise with IT and get this pushed soon.
we should also release 4.0.6 and 4.2.1
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/WebService/Server/XMLRPC.pm
Committed revision 7699.
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/4.2/
modified Bugzilla/WebService/Server/XMLRPC.pm
Committed revision 8042.
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/WebService/Server/XMLRPC.pm
Committed revision 8138.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
(In reply to Byron Jones ‹:glob› from comment #6)
> (In reply to Reed Loden [:reed] (very busy) from comment #5)
> > This needs to be immediately pushed to bmo, as it's causing major production
> > issues for webtools that use the API.
>
> agreed; i'll liaise with IT and get this pushed soon.
this fix is now live on bmo.
You need to log in
before you can comment on or make changes to this bug.
Description
•