731664 - backport bug 255606 to bmo (It is possible to get all bugs from buglist.cgi by passing URL parameters to buglist.cgi that create no Search.pm criteria)

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[:glob ✱]

we need to block requests which result in "give me all the bugs", as these result is massive load on our db slaves, and it's surprisingly each to do with bzapi.

this was fixed in bug 255606 for 4.2, and although search.pm got a massive rewrite, from what i can tell it should be possible to backport the crux of this fix to 4.0.

Comment 1

[:glob ✱]

Attachment: patch v1

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 601656 [details] [diff] [review]
patch v1

Review of attachment 601656 [details] [diff] [review]:
-----------------------------------------------------------------

::: Bugzilla/Search.pm
@@ +1052,5 @@
>      }
>      $suppstring .= join('', @supplist);
>      
> +    if (!@andlist
> +        && !Bugzilla->params->{'search_allow_no_criteria'}

You do not define this anywhere. Either port the pref change from 255606 or rename this to specific_search_allow_empty_words.

Comment 3

[:glob ✱]

Attachment: patch v2

d'oh, sorry about that.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 601871 [details] [diff] [review]
patch v2

Review of attachment 601871 [details] [diff] [review]:
-----------------------------------------------------------------

Works as expected. r=dkl

Comment 5

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified collectstats.pl
modified Bugzilla/Search.pm
Committed revision 8083.

Comment 6

[Ed Morley [:emorley]]

The "bugs filed today" saved search (available in the public searches list, shared by reed), that I have pinned to my bugzilla footer, no longer works - presumably due to this.

I get:
"You may not search, or create saved searches, without any search terms." 

The saved search is:
https://bugzilla.mozilla.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=Bugs%20Filed%20Today&sharer_id=159758

And is just a [bug creation] between -24h and now.

Comment 7

[Ed Morley [:emorley]]

Sorry, just seen bug 732409, ignore.