732409 - bug 731664 is causing some legitimate queries to be blocked

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[:glob ✱]

bug 731664 is causing some legitimate queries to be blocked.

https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced;bugidtype=include;chfieldfrom=2012-03-01;chfieldto=Now;chfield=[Bug%20creation];chfield=resolution;chfield=bug_status;chfield=short_desc;chfield=cf_crash_signature;order=Importance;columnlist=bug_id%2Cbug_status%2Cresolution%2Cshort_desc%2Ccf_crash_signature;ctype=csv;list_id=2512000

this is because we only check @andlist, but we also need to check @wherepart.

Comment 1

[:glob ✱]

Attachment: patch v1

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 602361 [details] [diff] [review]
patch v1

Review of attachment 602361 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. r=dkl

Comment 3

[Robert Kaiser]

When can we expect this to land on production bmo? The CrashKill team is being blocked in work a lot by bug 731653, which is at least to a major part caused by the bug here.

Comment 4

[:glob ✱]

(In reply to Robert Kaiser (:[e-mail]) from comment #3)
> When can we expect this to land on production bmo? The CrashKill team is
> being blocked in work a lot by bug 731653, which is at least to a major part
> caused by the bug here.

sorry, it was a public holiday for me on the 5th.

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified Bugzilla/Search.pm
Committed revision 8088.

i gave IT the heads-up of this bug at the end of last week, we should be able to get a push tomorrow morning.

Comment 5

[:glob ✱]

this fix has been pushed to bmo.