Closed Bug 732382 Opened 8 years ago Closed 8 years ago

Save As PDF freezes the application

Categories

(Firefox for Android Graveyard :: General, defect, critical)

Firefox 12
ARM
Android
defect
Not set
critical

Tracking

(firefox11 wontfix, firefox12 wontfix, firefox13 fixed)

RESOLVED FIXED
Firefox 14
Tracking Status
firefox11 --- wontfix
firefox12 --- wontfix
firefox13 --- fixed

People

(Reporter: andreea.pod, Assigned: Margaret)

References

Details

(Keywords: hang, regression, Whiteboard: [fennec 11.0b5][fennec 12.0b5])

Attachments

(2 files)

Attached file log
Mozilla/5.0 (Android; Linux armv7l;rv:11.0) Gecko/11.0 Firefox/11.0 Fennec/11.0  (29-02-2012)
Device: Asus EEE Transformers (Android 3.1)

Steps to reproduce:
1. go to about:blank
2. tap on menu and chose Save As PDF

Expected results:
- a white blank page should be saved and the application should work properly 

Actual results:
- Fennec freezes after saving the page.

Note: 
- sometimes the application is not responding even after kill.
Whiteboard: [fennec 11.0b5]
This also reproduces on normal pages like nytimes.com so it's not related to about:blank only.
Summary: Save As PDF on about:blank freezes the application → Save As PDF freezes the application
Whiteboard: [fennec 11.0b5] → [fennec 11.0b5][fennec 12.0b5]
I'm seeing this in current Fenne12b too, so setting status-firefox12 to affected.

Fwiw, this makes 'Save As PDF' unusable for me and causes Fennec to hang so shouldn't this block XUL Fennec?
Severity: major → critical
tracking-fennec: --- → ?
Keywords: hang
Version: Firefox 11 → Firefox 12
I'm not seeing this hang in Fennec 10, we should find a regression range for this bug.
20111130 11.0a1 build is hanging.
20111115 11.0a1 build is not hanging (bug shows bug 704185)
Using 12.0b4 (on Google Play) as well as 12.0b5 (current testing candidate, build #1), I am unable to reproduce this on a Galaxy Nexus (Android 4.0.4), nor having tested on a Galaxy SII (Android 2.3.4). I used cnn.com and nytimes.com.
Ok scratch that, I do see it; it happened on a second attempt this time at bbc.co.uk,

E/ActivityManager(  192): ANR in org.mozilla.firefox_beta (org.mozilla.firefox_beta/.App)
E/ActivityManager(  192): Reason: keyDispatchingTimedOut
E/ActivityManager(  192): Load: 1.03 / 0.78 / 0.4
E/ActivityManager(  192): CPU usage from 5631ms to 0ms ago:
E/ActivityManager(  192):   99% 3911/org.mozilla.firefox_beta: 56% user + 43% kernel

"Firefox Beta is not responding"
Andreea, could you perhaps also check if the regression range in comment 7 is correct?
Margaret, this is a regression in XUL Fennec that is causing hangs when using Save As PDF. Do you know if the fix for bug 704691 could be causing this?
Yes Martijn, I checked and it is correct.
(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #9)
> Margaret, this is a regression in XUL Fennec that is causing hangs when
> using Save As PDF. Do you know if the fix for bug 704691 could be causing
> this?

That seems like the likely culprit. So this isn't a problem in fennec native? We changed the fennec native code that depends on the changes from bug bug 704691 in bug 701797, so maybe we need to port the changes from bug 701797 to XUL fennec.
No, this is not a problem in Fennec Native.
Attached patch patchSplinter Review
The problem is that bug 704691 added another STATE_STOP call to nsPrintData:: DoOnProgressChange, and since we didn't specify the type to listen for in the print listener, we were sending the "Browser:SaveAs:Return" message twice, which ran into problems the second time that message handler was called.
Assignee: nobody → margaret.leibovic
Attachment #616786 - Flags: review?(mark.finkle)
Attachment #616786 - Flags: review?(mark.finkle) → review+
Comment on attachment 616786 [details] [diff] [review]
patch

This only affects XUL fennec. Very low risk and fixes a serious problem with the "Save As PDF" feature.

This was a regression caused by bug 704691, which landed for Firefox 11, so this problem is currently in the released version of XUL fennec. Are we planning on releasing another version of XUL fennec? Should I uplift this to aurora/beta?
Attachment #616786 - Flags: approval-mozilla-central?
Comment on attachment 616786 [details] [diff] [review]
patch

[Approval Request Comment]
Regression: Yes
User impact if declined: Browser hangs
Testing completed (on m-c, etc.): -
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None
Attachment #616786 - Flags: approval-mozilla-central?
Attachment #616786 - Flags: approval-mozilla-central+
Attachment #616786 - Flags: approval-mozilla-beta?
Attachment #616786 - Flags: approval-mozilla-aurora?
Blocks: 704691
https://hg.mozilla.org/mozilla-central/rev/eec7626671fa
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 616786 [details] [diff] [review]
patch

[Triage Comment]
Approved for Aurora 13, but denying for Beta 12 since we're not shipping a release product off of that branch currently.
Attachment #616786 - Flags: approval-mozilla-beta?
Attachment #616786 - Flags: approval-mozilla-beta-
Attachment #616786 - Flags: approval-mozilla-aurora?
Attachment #616786 - Flags: approval-mozilla-aurora+
Duplicate of this bug: 739053
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.