73254 - images aren't printing full size

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[sujay]

using 3/23 build of netscape

1) launch netscape
2) jump to http://www.mapquest.com
3) enter driving directions
4) print them out

notice the big map below driving directions prints out very small.

should be full size...

also happens for printing out simple 640x480 GIFS.

Comment 1

[shrirang khanzode]

added test url

Comment 2

[sujay]

another sample URL:

http://www.vinod.com/cj.jpg

load it in browser then print..
notice the small size.

Comment 3

[sujay]

test URL added above.

Comment 4

[Stuart Parmenter]

windows only

Comment 5

[Boris Zbarsky [:bzbarsky]]

*** Bug 75547 has been marked as a duplicate of this bug. ***

Comment 6

[Kevin McCluskey (gone)]

The problem occurs with intrinsically sized images (I.E no width or height 
specified) If a width or height is specified the images print with the correct 
size.

If you print test2.html on WIN32 you will notice that the raptor.jpg is printed 
at it's intrinsic size. (Which is tiny). If you specify a width and height for 
the raptor.jpg image element it will print correctly.

Comment 7

[Boris Zbarsky [:bzbarsky]]

*** Bug 75904 has been marked as a duplicate of this bug. ***

Comment 8

[Stuart Parmenter]

Attachment: fix for the bug

Comment 9

[Stuart Parmenter]

the top part of this patch is what really fixes the bug here.  the rest of it is 
mostly just null checks.

basically, i have to convert from twips to "scaled" twips so that the image goes 
through the scaling code when drawing.

Comment 10

[timeless]

r=timeless

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

sr=[e-mail]

Comment 12

[Hixie (not reading bugmail)]

+      if (intrinsicScaledHeight != 0) {
+        newHeight = (intrinsicScaledHeight * newWidth) / intrinsicScaledWidth;

Shouldn't that be

+      if (intrinsicScaledWidth != 0) {
                          ^^^^^
...?

Similarly with:

+    if (intrinsicScaledWidth != 0) {
+      newWidth = (intrinsicScaledWidth * newHeight) / intrinsicScaledHeight;

Is there a bug # for:

+            // XXX need to handle low image...

...?

Fix those, and r=hixie

Comment 13

[Hixie (not reading bugmail)]

(fixing mid air collision)

Nice to see the reviewers and superreviewers were so thorough. No rubber 
stamping here. No sir.

Comment 14

[Stuart Parmenter]

fixed

Comment 15

[Stuart Parmenter]

*** Bug 75425 has been marked as a duplicate of this bug. ***

Comment 16

[Terri Preston]

Verified fixed on Windows NT build 2001041704
Verified fixed on Mac build 2001041704, can't
verify on Linux 'cause of bug 75436