732602 - Add-ons built using Builder don't work if there are special chars in the description

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Description

[jakon68]

Attachment: errorlog.txt

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
Build ID: 20120216101208

Steps to reproduce:

I created an add-on using the Add-on builder (https://builder.addons.mozilla.org/).


Actual results:

I tried to test the add-on, but it did not work.  I have created a test add-on so you can test it yourself: https://builder.addons.mozilla.org/addon/1042928/.  You only have to click the 'Test' button. ;)  It cannot be loaded because of the description: There is a single-quote in it, which produces this error (I attached the error log).


Expected results:

The add-on should have loaded correctly, so I could test it.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Confirming that the addon linked doesn't install into Firefox. It fails to work with the "Test" button, and Firefox doesn't install the XPI you get when you click the "Download" button.

I can't reproduce this locally with an addon built directly with the SDK, though. I create an addon with 'cfx init', and edit the description property in package.json to include a single-quote. It then installs just fine for me with cfx run and also the generated XPI file from cfx xpi installs.

Moving this to the AMO/builder product/component to see what they're doing differently. Feel free to switch it back if you can reproduce with the local SDK.

Comment 2

[Antonio Merker]

As mentioned in the bug title, this also happens when using special chars, such as German umlauts (ä, ö, ü, ß).

When putting these chars into the Description, they're shown correctly when re-opening properties. Once you reload the Builder, however, they're gone. They're also gone when downloading the XPI.

Maybe a general move to UTF8 for the description could solve that.

Comment 3

[Piotr Zalewa [:zalun]]

@antoneeo This should be a different bug

Comment 4

[Piotr Zalewa [:zalun]]

Filed bug 733341 (copied antoneeo's comment as description)

Comment 5

[Piotr Zalewa [:zalun]]

It does work for me.
The Add-on is installed in Firefox - both [Test] and from the XPI file.
Its description: "Quotes are dangerous: '"

There was no update, so I'm thinking of a Firefox version/system issue.
I'm running Aurora 12.0a2 (2012-03-05) on Linux

Comment 6

[jakon68]

The add-on was a bad example.  Please try this [1] one.  It seems like it would work, but if you try to show the translation of a selection by pressing "alt-t," nothing happens.

[1]: https://builder.addons.mozilla.org/addon/1042920/latest/

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to jakon68 from comment #6)
> The add-on was a bad example.  Please try this [1] one.  It seems like it
> would work, but if you try to show the translation of a selection by
> pressing "alt-t," nothing happens.
> 
> [1]: https://builder.addons.mozilla.org/addon/1042920/latest/

Worked for me. I don't see any special characters in that addon's description, though.

Comment 8

[jakon68]

(In reply to Wes Kocher (:KWierso) (Jetpack Bugmaster) from comment #7)
> (In reply to jakon68 from comment #6)
> > The add-on was a bad example.  Please try this [1] one.  It seems like it
> > would work, but if you try to show the translation of a selection by
> > pressing "alt-t," nothing happens.
> > 
> > [1]: https://builder.addons.mozilla.org/addon/1042920/latest/
> 
> Worked for me. I don't see any special characters in that addon's
> description, though.
The "special character" is a single quote.  I am trying to use it with "Aurora 12.0a2 (2012-03-09)" and "Firefox 10.0.2," but it works with neither of them for me, but (!) I just discovered the "Test" button on my user page [1] working.  I still cannot install the add-on if I use the "Test" button on the "edit" page of the add-on [2].

[1]: https://builder.addons.mozilla.org/user/gandaro/
[2]: https://builder.addons.mozilla.org/addon/1042920/latest/

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Yeah, it's still working fine for me in my current Firefox Nightly build. Can you try using Nightly and seeing if it works for you? http://nightly.mozilla.org

Comment 10

[Daniel Buchner [:dbuc]]

Yeah that works for me on a Win 7 box running the latest version of Aurora. Could this be OS-specific?

Comment 11

[jakon68]

It also does not work with the latest Nightly build.  I have right now seen another error message to appear in the error console when trying to test the add-on. [1]  I am using Linux (32-bit), maybe it is an OS-specific problem...

[1]:
> Error: loader is not defined
> Source File: data:,loader.unload("uninstall");loader = null; Loader = null; dump = null;

Comment 12

[Piotr Zalewa [:zalun]]

Please update add-on's URL

Comment 13

[gandaro]

Voilà:

https://builder.addons.mozilla.org/package/48077/latest/

Comment 14

[Piotr Zalewa [:zalun]]

I can't see any error message in the console ...
Nightly 18.0a1 (2012-09-19)

Comment 15

[gandaro]

I can still see it, also using 18.0a1 (2012-09-21).

Comment 16

[Piotr Zalewa [:zalun]]

Is anyine from the team able to see the bug?

Comment 17

[Wil Clouser [:clouserw]]

The builder project has been discontinued as of April 1st, 2014.

The announcement last year: https://blog.mozilla.org/addons/2013/12/18/add-on-builder/

Next steps (still being written): https://developer.mozilla.org/en-US/Add-ons/SDK/Builder