733235 - [skiplist] Add MOZ_Crash and MOZ_Assert to irrelevantSignatureRegEx

Status: RESOLVED FIXED

(Socorro :: Infra, task)

Description

[Andrew McCreight [:mccr8]]

These are assertions, so we really want to know where they are being called from, so if you could please add them to the prefix list thing that would be great.

Comment 1

[Scoobidiver (away)]

Which skiplist is the right one: the prefix or the ignore one? This bug and bug 732462 are contradictory.

Comment 2

[Andrew McCreight [:mccr8]]

I'm not sure.  CrashInJS appears to be in the prefix list (see signature CrashInJS | JS_AbortIfWrongThread), but JS_Assert appears to be in the ignore list (see signature CrashIfInvalidSlot).  On the other hand, MOZ_Assert calls MOZ_Crash, so it doesn't make sense for MOZ_Assert to be ignored and MOZ_Crash to be prefixed, as that will just make all asserts show up as crashes.  And if they are prefixed, you'll just get a ton of MOZ_Crash | MOZ_Assert | whatever, so maybe ignore makes sense for both of them.

Comment 3

[Scoobidiver (away)]

(In reply to Andrew McCreight [:mccr8] from comment #2)
> I'm not sure.  CrashInJS appears to be in the prefix list (see signature
> CrashInJS | JS_AbortIfWrongThread), but JS_Assert appears to be in the
> ignore list (see signature CrashIfInvalidSlot). 
CrashInJS can be moved and JS_Assert is in no list. 
To know current skip lists, see https://github.com/mozilla/socorro/blob/master/scripts/config/processorconfig.py.dist

Comment 5

[Mark Banner (:standard8)]

FYI this looks like a typo: Blocks: 732243

Comment 6

[Robert Kaiser]

OK, after talking with some developers, including Andrew, adding MOZ_Crash and MOZ_Assert to irrelevantSignatureRegEx is the way to go. Laura, can you do that?

Comment 7

[Laura Thomson :laura]

In https://github.com/lauraxt/socorro/commit/992415a5d00acdfc1d10f35ece59c2b1b5423499

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/992415a5d00acdfc1d10f35ece59c2b1b5423499
Fixes bug 733235, add MOZ_Crash and MOZ_Assert to the irrelevant list

Comment 9

[[github robot]]

Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/950cbaa330a339a582607b1553af3a903d2553e0
Fixes bug 733235, add MOZ_Crash and MOZ_Assert to the irrelevant list

Comment 10

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/950cbaa330a339a582607b1553af3a903d2553e0
Fixes bug 733235, add MOZ_Crash and MOZ_Assert to the irrelevant list

Comment 11

[[github robot]]

Commit pushed to v3-branch at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/950cbaa330a339a582607b1553af3a903d2553e0
Fixes bug 733235, add MOZ_Crash and MOZ_Assert to the irrelevant list