Closed Bug 733235 Opened 8 years ago Closed 8 years ago

[skiplist] Add MOZ_Crash and MOZ_Assert to irrelevantSignatureRegEx

Categories

(Socorro :: Infra, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mccr8, Assigned: laura)

References

Details

(Whiteboard: [qa-])

These are assertions, so we really want to know where they are being called from, so if you could please add them to the prefix list thing that would be great.
Blocks: 716167
Blocks: 717540
Depends on: 732462
Which skiplist is the right one: the prefix or the ignore one? This bug and bug 732462 are contradictory.
Blocks: 732346
Blocks: 731881
I'm not sure.  CrashInJS appears to be in the prefix list (see signature CrashInJS | JS_AbortIfWrongThread), but JS_Assert appears to be in the ignore list (see signature CrashIfInvalidSlot).  On the other hand, MOZ_Assert calls MOZ_Crash, so it doesn't make sense for MOZ_Assert to be ignored and MOZ_Crash to be prefixed, as that will just make all asserts show up as crashes.  And if they are prefixed, you'll just get a ton of MOZ_Crash | MOZ_Assert | whatever, so maybe ignore makes sense for both of them.
(In reply to Andrew McCreight [:mccr8] from comment #2)
> I'm not sure.  CrashInJS appears to be in the prefix list (see signature
> CrashInJS | JS_AbortIfWrongThread), but JS_Assert appears to be in the
> ignore list (see signature CrashIfInvalidSlot). 
CrashInJS can be moved and JS_Assert is in no list. 
To know current skip lists, see https://github.com/mozilla/socorro/blob/master/scripts/config/processorconfig.py.dist
Blocks: 732243
No longer depends on: 732462
Summary: [skiplist] Add MOZ_Crash and MOZ_Assert to the prefixSignatureRegEx → [skiplist] Add MOZ_Crash and MOZ_Assert to the ignore skip list
Duplicate of this bug: 732462
FYI this looks like a typo: Blocks: 732243
No longer blocks: 732243
Blocks: 732343
OK, after talking with some developers, including Andrew, adding MOZ_Crash and MOZ_Assert to irrelevantSignatureRegEx is the way to go. Laura, can you do that?
Summary: [skiplist] Add MOZ_Crash and MOZ_Assert to the ignore skip list → [skiplist] Add MOZ_Crash and MOZ_Assert to irrelevantSignatureRegEx
In https://github.com/lauraxt/socorro/commit/992415a5d00acdfc1d10f35ece59c2b1b5423499
Assignee: nobody → laura
Target Milestone: --- → 3
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/992415a5d00acdfc1d10f35ece59c2b1b5423499
Fixes bug 733235, add MOZ_Crash and MOZ_Assert to the irrelevant list
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Blocks: 739027
Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/950cbaa330a339a582607b1553af3a903d2553e0
Fixes bug 733235, add MOZ_Crash and MOZ_Assert to the irrelevant list
Commit pushed to v3-branch at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/950cbaa330a339a582607b1553af3a903d2553e0
Fixes bug 733235, add MOZ_Crash and MOZ_Assert to the irrelevant list
See Also: → 1507049
You need to log in before you can comment on or make changes to this bug.