Enable accessibility on Mac

RESOLVED FIXED in mozilla15

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: hub, Assigned: hub)

Tracking

(Depends on: 1 bug)

Trunk
mozilla15
x86_64
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

5 years ago
For Firefox 14 (tentatively), enable accessibility on Mac.
(Assignee)

Updated

5 years ago
Assignee: nobody → hub
Depends on: 718627
(Assignee)

Comment 1

5 years ago
Created attachment 603427 [details] [diff] [review]
Enable Accessibility on Mac. r=
(Assignee)

Comment 2

5 years ago
Created attachment 603536 [details] [diff] [review]
Enable accessibility by default on Mac. r=
(Assignee)

Updated

5 years ago
Attachment #603427 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Depends on: 716935
(Assignee)

Updated

5 years ago
Depends on: 740696
(Assignee)

Comment 3

5 years ago
Created attachment 618373 [details] [diff] [review]
Enable accessibility by default on Mac. r=
(Assignee)

Updated

5 years ago
Attachment #603536 - Attachment is obsolete: true
(Assignee)

Comment 4

5 years ago
Comment on attachment 618373 [details] [diff] [review]
Enable accessibility by default on Mac. r=

We want to make sure enabling a11y in Nightly for Mac has a negligible impact. We are prepared to back it out before the next Aurora uplift if needed.
Attachment #618373 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

5 years ago
Depends on: 746160
(Assignee)

Updated

5 years ago
No longer depends on: 716935
Comment on attachment 618373 [details] [diff] [review]
Enable accessibility by default on Mac. r=

Review of attachment 618373 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ -4604,5 @@
> -
> -case "${target}" in
> -*darwin*)
> -    ACCESSIBILITY=
> -    MOZ_WEBAPP_RUNTIME=1

You seem to be losing this MOZ_WEBAPP_RUNTIME here.
Attachment #618373 - Flags: review?(ted.mielczarek) → review-
(Assignee)

Comment 6

5 years ago
damn. I messed up the rebase.

good catch.
(Assignee)

Comment 7

5 years ago
Created attachment 618463 [details] [diff] [review]
Enable accessibility by default on Mac.
(Assignee)

Updated

5 years ago
Attachment #618373 - Attachment is obsolete: true
(Assignee)

Comment 8

5 years ago
Created attachment 618473 [details] [diff] [review]
Enable accessibility by default on Mac.
(Assignee)

Updated

5 years ago
Attachment #618463 - Attachment is obsolete: true
(Assignee)

Comment 9

5 years ago
Comment on attachment 618473 [details] [diff] [review]
Enable accessibility by default on Mac.

Fixed that mistake in the previous version.
Attachment #618473 - Flags: review?(ted.mielczarek)
Comment on attachment 618473 [details] [diff] [review]
Enable accessibility by default on Mac.

Does this enable the mochitests-a11y on all Mac builds automatically, too, or do these need to be turned on separately?
(Assignee)

Comment 11

5 years ago
I don't enable any test.
Attachment #618473 - Flags: review?(ted.mielczarek) → review+
You'll need a separate bug in mozilla.org : Release Engineering to enable mochitest-a11y on mac builds.

Updated

5 years ago
Blocks: 749160
Rebased and pushed to inbound on Hub's behalf: http://hg.mozilla.org/integration/mozilla-inbound/rev/76447b588eea
Note that this only enables accessibility, it does not yet run the Mochitest suite of tests. This will be dealt with in bug 749160 separately.

Updated

5 years ago
Target Milestone: --- → mozilla15
http://hg.mozilla.org/mozilla-central/rev/76447b588eea
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
(Assignee)

Comment 15

5 years ago
backed out with bug 761256. Will come back with bug 761763
You need to log in before you can comment on or make changes to this bug.