Closed
Bug 733513
Opened 13 years ago
Closed 13 years ago
Enable accessibility on Mac
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: hub, Assigned: hub)
References
(Depends on 1 open bug)
Details
Attachments
(1 file, 4 obsolete files)
|
1.57 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
For Firefox 14 (tentatively), enable accessibility on Mac.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Attachment #603427 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Attachment #603536 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•13 years ago
|
||
Comment on attachment 618373 [details] [diff] [review]
Enable accessibility by default on Mac. r=
We want to make sure enabling a11y in Nightly for Mac has a negligible impact. We are prepared to back it out before the next Aurora uplift if needed.
Attachment #618373 -
Flags: review?(ted.mielczarek)
|
||
Comment 5•13 years ago
|
||
Comment on attachment 618373 [details] [diff] [review]
Enable accessibility by default on Mac. r=
Review of attachment 618373 [details] [diff] [review]:
-----------------------------------------------------------------
::: configure.in
@@ -4604,5 @@
> -
> -case "${target}" in
> -*darwin*)
> - ACCESSIBILITY=
> - MOZ_WEBAPP_RUNTIME=1
You seem to be losing this MOZ_WEBAPP_RUNTIME here.
Attachment #618373 -
Flags: review?(ted.mielczarek) → review-
|
|
Assignee | |
Comment 6•13 years ago
|
||
damn. I messed up the rebase.
good catch.
|
|
Assignee | |
Comment 7•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Attachment #618373 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 8•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Attachment #618463 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 9•13 years ago
|
||
Comment on attachment 618473 [details] [diff] [review]
Enable accessibility by default on Mac.
Fixed that mistake in the previous version.
Attachment #618473 -
Flags: review?(ted.mielczarek)
|
||
Comment 10•13 years ago
|
||
Comment on attachment 618473 [details] [diff] [review]
Enable accessibility by default on Mac.
Does this enable the mochitests-a11y on all Mac builds automatically, too, or do these need to be turned on separately?
|
|
Assignee | |
Comment 11•13 years ago
|
||
I don't enable any test.
|
|
||
Updated•13 years ago
|
Attachment #618473 -
Flags: review?(ted.mielczarek) → review+
|
|
||
Comment 12•13 years ago
|
||
You'll need a separate bug in mozilla.org : Release Engineering to enable mochitest-a11y on mac builds.
|
|
||
Comment 13•13 years ago
|
||
Rebased and pushed to inbound on Hub's behalf: http://hg.mozilla.org/integration/mozilla-inbound/rev/76447b588eea
Note that this only enables accessibility, it does not yet run the Mochitest suite of tests. This will be dealt with in bug 749160 separately.
|
|
||
Updated•13 years ago
|
Target Milestone: --- → mozilla15
|
||
Comment 14•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
|
|
Assignee | |
Comment 15•12 years ago
|
||
backed out with bug 761256. Will come back with bug 761763
You need to log in
before you can comment on or make changes to this bug.
Description
•