Moving a subfolder doesn't delete *.sbd directory.

RESOLVED FIXED

Status

defect
RESOLVED FIXED
18 years ago
15 years ago

People

(Reporter: kazhik, Assigned: Bienvenu)

Tracking

Trunk
x86
Windows 2000
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

18 years ago
Moving a subfolder doesn't delete *.sbd directory.

Steps to reproduce:

(1) Create a subfolder.
(2) Move it to another place by drag and drop. The arrow which indicates
subfolder remains. *.sbd direcotry isn't deleted.
over to naving.
Assignee: sspitzer → naving

Comment 2

18 years ago
Yes the .sbd directory will be there, but it will be empty.
(Reporter)

Comment 3

17 years ago
Posted patch patch (obsolete) — Splinter Review
.sbd is deleted with this patch.

But the icon for the subfolder remains.
(Reporter)

Comment 4

17 years ago
Posted patch patch, v2 (obsolete) — Splinter Review
The previous patch doesn't check whether there are other subfolders or not.
Attachment #75382 - Attachment is obsolete: true

Updated

17 years ago
Blocks: 123209
Does this patch work yet?
Can it be checked in?
(Reporter)

Comment 6

16 years ago
Comment on attachment 75385 [details] [diff] [review]
patch, v2

This patch still works.
Attachment #75385 - Flags: review?(naving)
Navin, how can we request a review to possibly get this patch checked in?

Updated

16 years ago
Blocks: 46365
(Reporter)

Comment 8

16 years ago
Posted patch patch v3 (obsolete) — Splinter Review
patch v2 deletes *.sbd even if it contains subfolders.
Attachment #75385 - Attachment is obsolete: true
(Reporter)

Updated

16 years ago
Attachment #119790 - Flags: review?(bienvenu)
Is it possible to get this in for 1.4 beta?
CC-ing bienvenu, he might be interested.
(Assignee)

Comment 11

16 years ago
Comment on attachment 119790 [details] [diff] [review]
patch v3

you should add a comment that i.Exists() checks to see if the .sbd directory is
empty or not (that's what it does, right?) Also, you don't need the extra
braces around the call to parentPath.Delete. You've made sure that this works
in the case of a non-empty parent directory, right? It looks fine, otherwise,
thx for working on this.
mass re-assign.
Assignee: naving → sspitzer
(Reporter)

Comment 13

16 years ago
Posted patch patch v4Splinter Review
Added a comment and deleted the braces.
Attachment #119790 - Attachment is obsolete: true
(Reporter)

Updated

16 years ago
Attachment #122981 - Flags: review?(bienvenu)
Comment on attachment 75385 [details] [diff] [review]
patch, v2

clearing obsolete review request
Attachment #75385 - Flags: review?(naving)
Attachment #119790 - Flags: review?(bienvenu)

Comment 15

15 years ago
There is a patch, why has this bug stalled?
(Assignee)

Comment 16

15 years ago
taking - I'll try this out.
Assignee: sspitzer → bienvenu
(Assignee)

Comment 17

15 years ago
fix checked in, r/sr=me, thanks Kazuhiko
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
(Assignee)

Updated

15 years ago
Attachment #122981 - Flags: review?(bienvenu)
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.