Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Port configure.in changes from Bug 700910 to Thunderbird

RESOLVED FIXED in Thunderbird 15.0

Status

MailNews Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Irving, Assigned: Irving)

Tracking

Trunk
Thunderbird 15.0
x86
Mac OS X
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Core recently added support for the C++11 'delete' keyword on method declarations; this requires a new warning control flag on clang.
Also pulling in bug 666135, which defines the CLANG_CXX compiler detection and takes out some of the other bothersome warnings
See Also: → bug 700910, bug 666135
Created attachment 604153 [details] [diff] [review]
configure changes to reduce spurious warnings under clang

Clang detection and warning suppression ported from mozilla-central, and drive-by cleanup of DOS line endings in an unrelated file. Try build on its way.

Updated

5 years ago
Component: Build Config → Build Config
Product: Thunderbird → MailNews Core
QA Contact: build-config → build-config
Comment on attachment 604153 [details] [diff] [review]
configure changes to reduce spurious warnings under clang

review @ mark on irvings behalf.
Attachment #604153 - Flags: review?(mbanner)
TBPL shows one of the try builders not completing, but all the others look fine: http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=31e66a799604
Comment on attachment 604153 [details] [diff] [review]
configure changes to reduce spurious warnings under clang

Review of attachment 604153 [details] [diff] [review]:
-----------------------------------------------------------------

A bunch more configure.in changes just dropped in bug 711895, I'll respin the patch and run another try build.
Attachment #604153 - Flags: review?(mbanner)
This can land before bug 737677 but some of the warnings won't go quiet until then
Depends on: 711895, 737677
Created attachment 607987 [details] [diff] [review]
Port configure changes from M-C for better compiler warning control

M-C has been doing a bunch of work on their compiler warnings, not all of them clang-specific. This patch pulls in the most recent batch.

Switching reviewer to bienvenu to give standard8 a break.
Attachment #604153 - Attachment is obsolete: true
Attachment #607987 - Flags: review?(dbienvenu)

Comment 8

5 years ago
Comment on attachment 607987 [details] [diff] [review]
Port configure changes from M-C for better compiler warning control

what's going on with db/makefiles.sh? line ending changes? should that not be part of this diff?
Yes, db/makefiles.sh is a drive-by fix of DOS line endings in an unrelated file. If you want to leave that out of this patch that's fine.

Comment 10

5 years ago
Comment on attachment 607987 [details] [diff] [review]
Port configure changes from M-C for better compiler warning control

builds fine on windows - db/makefiles.sh change is ok, just checking.
Attachment #607987 - Flags: review?(dbienvenu) → review+
Please note that bug 711895 caused some i10n build bustage and may be backed out again :(
Comment on attachment 607987 [details] [diff] [review]
Port configure changes from M-C for better compiler warning control

Patch has suffered bit-rot, update coming...
Attachment #607987 - Flags: review+
Created attachment 612185 [details] [diff] [review]
Port configure changes from M-C for better compiler warning control, updated

No substantive changes, just bit-rot from other configure patches that landed in between. Try is busy (and a bit flaky), but I can queue this up if you'd like to see a try build before landing.
Attachment #607987 - Attachment is obsolete: true
Attachment #612185 - Flags: review?(dbienvenu)

Updated

5 years ago
Attachment #612185 - Flags: review?(dbienvenu) → review+
Try build at http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=e2d1a8c405b5 looks green enough to me, let's push this and see what comes out the other side.
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/014d81b1029f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
BACK THIS OUT!

p.s. given the issues mentioned in the other bug, I'm surprised bienvenu was ok with reviewing this, since he's not technically a build-system peer for c-c.

We have had broken l10n builds since this landed on trunk (on linux). 

Please get review from a c-c actual build system peer (or an m-c build system peer if they are willing to review this) before relanding.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
pps I'm surprised at "us" for not catching that this did break repacks, especially given c#11, and sad that no-one happened to tell you that try is not good enough to catch l10n repack bustage from the change.
Keywords: checkin-needed
Whiteboard: [c-n for comm backout]
Created attachment 614489 [details] [diff] [review]
Additional changes (on top of previously committed patch) to fix l10n repack

This patch should be applied on top of https://bugzilla.mozilla.org/attachment.cgi?id=612185 and contains additional changes from the updated version of bug 711895, to support l10n repack builds using older versions of GCC. Try build in progress at http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=35b9036dc1d1
Attachment #614489 - Flags: review?(bugspam.Callek)
Revision 014d81b1029f backed out. I'll re-land both together.
http://hg.mozilla.org/comm-central/rev/f62eaa1c5b0d
Keywords: checkin-needed
Whiteboard: [c-n for comm backout]
First try build seems to have suffered from some mozilla-central bustage; second try came through clean aside from a couple of random-looking issues: http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=73154769b254
Comment on attachment 614489 [details] [diff] [review]
Additional changes (on top of previously committed patch) to fix l10n repack

Review of attachment 614489 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good sorry for the delay
Attachment #614489 - Flags: review?(bugspam.Callek) → review+
Need to reland both patches on this bug...
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/247aa759c1ce
http://hg.mozilla.org/comm-central/rev/134579274546
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: Thunderbird 14.0 → Thunderbird 15.0
You need to log in before you can comment on or make changes to this bug.