Use Services.prefs or Application.prefs, instead of getPref(), in (SM and TB) MsgComposeCommands.js

NEW
Unassigned

Status

--
minor
7 years ago
7 years ago

People

(Reporter: sgautherie, Unassigned)

Tracking

(Blocks: 1 bug)

Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

7 years ago
At least, most uses should be able to be replaced by direct Services.prefs.get*Pref() calls.

Could we even get rid of the function itself or is supposed to be an API for other consumers?

"Found 54 matching lines in 2 files"
Flags: in-testsuite-
(Reporter)

Updated

7 years ago
Depends on: 734549
(Reporter)

Comment 1

7 years ago
Ah, this getPref() returns 'null' as a default value for non-complex types.
Do we actually need to support that case?
If yes, would it be "better" to use Application.prefs with explicit (typed) defaults?
Summary: Use Services.prefs, instead of getPref(), in (SM and TB) MsgComposeCommands.js → Use Services.prefs or Application.prefs, instead of getPref(), in (SM and TB) MsgComposeCommands.js
You need to log in before you can comment on or make changes to this bug.