At least, most uses should be able to be replaced by direct Services.prefs.get*Pref() calls. Could we even get rid of the function itself or is supposed to be an API for other consumers? "Found 54 matching lines in 2 files"
Ah, this getPref() returns 'null' as a default value for non-complex types. Do we actually need to support that case? If yes, would it be "better" to use Application.prefs with explicit (typed) defaults?
Summary: Use Services.prefs, instead of getPref(), in (SM and TB) MsgComposeCommands.js → Use Services.prefs or Application.prefs, instead of getPref(), in (SM and TB) MsgComposeCommands.js
You need to log in before you can comment on or make changes to this bug.