Closed Bug 735219 Opened 12 years ago Closed 12 years ago

Cannot login to twitter with Instant messaging

Categories

(Thunderbird :: Instant Messaging, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 13.0

People

(Reporter: tetsuharu, Assigned: florian)

References

Details

Attachments

(1 file, 1 obsolete file)

Enviroment:
*Windows 7 (x64)
*http://hg.mozilla.org/mozilla-central/rev/1ca7a94573f2

STR:
1. Open "Add chat account".
2. Select Twitter and add Twitter account.

Result:
I cannot login to Twitter.
The status on the "Instant messaging status" window holds as
"Connection: Initiating...".

If I reconnect it after I disconnected once, 
The following error occurs:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXMLHttpRequest.open]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: resource:///modules/http.jsm :: doXHRequest :: line 13"  data: no]
Blocks: 714733
I am also experiencing this bug with my local build on Linux.
The cause of this problem is that we landed two different files called http.jsm the same day, as BigFiles forket de http.jsm module that was initially part of Instantbird.
The changes made to this module for BigFiles are incompatible :-(.
Severity: normal → major
I also forked oauth.jsm (or did you not have that file?) Dropbox's use of oauth is different from twitter's, from what I could tell, so merging http and oath was not trivial for me, but since you wrote the code, it would probably be easier for you.
(In reply to David :Bienvenu from comment #3)
> I also forked oauth.jsm (or did you not have that file?)

We don't, our oauth code is part of twitter.js
(In reply to Florian Quèze from comment #4)
> (In reply to David :Bienvenu from comment #3)
> > I also forked oauth.jsm (or did you not have that file?)
> 
> We don't, our oauth code is part of twitter.js

Does this mean we have duplicated code ?
(In reply to Ludovic Hirlimann [:Usul] from comment #5)
 
> Does this mean we have duplicated code ?

I think you mean more duplicated code. Or more accurately, more forked code.
Attached patch Proposed fix (obsolete) — Splinter Review
This is the least intrusive fix I've found to resolve this conflict. I have checked that Twitter worked after applying this patch; haven't tested BigFiles.
Attachment #605415 - Flags: review?(dbienvenu)
Blocks: BigFiles
Attached patch Fix v2Splinter Review
Add parentheses as I got the operator priority wrong around the aMethod handling.
Attachment #605415 - Attachment is obsolete: true
Attachment #605418 - Flags: review?(dbienvenu)
Attachment #605415 - Flags: review?(dbienvenu)
Comment on attachment 605418 [details] [diff] [review]
Fix v2

dropbox test works in mozmill and in thunderbird, thx!
Attachment #605418 - Flags: review?(dbienvenu) → review+
Thanks for the quick review! :)

http://hg.mozilla.org/comm-central/rev/3d368e502399
Status: NEW → RESOLVED
Closed: 12 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
Assignee: nobody → florian
I tried tinderbox-build(http://hg.mozilla.org/mozilla-central/rev/b6627f28b7ec),
after STR, this error message was not shown on error console.

> Error: uncaught exception: [Exception... "Component returned failure code:
> 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXMLHttpRequest.open]"  nsresult:
> "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
> resource:///modules/http.jsm :: doXHRequest :: line 13"  data: no]

But Thunderbird did not show OAuth window for login to twitter immediately after adding twitter account...
(So if I restart Thunderbird once, Thunderbird shows it.)

Does this indicate that this bug is still opened?
Or Should I file an another bug?
(In reply to OHZEKI Tetsuharu [:saneyuki_s] from comment #11)

> Thunderbird did not show OAuth window for login to twitter immediately
> after adding twitter account...
> (So if I restart Thunderbird once, Thunderbird shows it.)

I have tried but couldn't reproduce the issue (someone else noticed the same problem though), so there's probably something missing in the steps to reproduce.

> Does this indicate that this bug is still opened?

No, as Twitter is no longer completely unusable.

> Or Should I file an another bug?

Yes please, if possible with more detailed steps to reproduce this specific issue.
(In reply to Florian Quèze from comment #12)
> Yes please, if possible with more detailed steps to reproduce this specific
> issue.

I have filed bug 735688.
You need to log in before you can comment on or make changes to this bug.