735309 - Valgrind builds should use an in-tree mozconfig

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement, P3)

Description

[(not currently active) Ted Mielczarek]

Right now Valgrind builds build a mozconfig file from their build script. Since we've switched to having all our mozconfigs in the source tree, they should use an in-tree mozconfig instead. This would have prevented bug 735295.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: add in-tree mozconfigs for Valgrind builds

This just copies the nightly build mozconfigs to valgrind mozconfigs, removes some options that are not relevant, and adds a few from the valgrind.sh script that are necessary.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: make Valgrind builds use in-tree mozconfigs

This patch changes the valgrind.sh script to use the in-tree mozconfigs from the previous patch. It also tweaks the client.mk invocation, because these builds apparently weren't picking up the mozconfig. I bet we broke that somewhere along the way with our mozconfig-find changes.

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 607668 [details] [diff] [review]
add in-tree mozconfigs for Valgrind builds

Review of attachment 607668 [details] [diff] [review]:
-----------------------------------------------------------------

would it make sense to include the linux{,64} mozconfig instead of copying it?

Comment 4

[(not currently active) Ted Mielczarek]

I guess it's feasible to include the nightly mozconfig and just add our additional options. The options I removed aren't really critical to not be there, they just seemed extraneous. That's probably a better plan to limit the amount of drift we introduce.

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: add in-tree mozconfigs for Valgrind builds

As suggested. This does keep things simpler, and should ensure that the Valgrind mozconfigs track the Nightly mozconfigs more closely.

Comment 6

[(not currently active) Ted Mielczarek]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5d47b047e08f

I'll push the build/tools changes once this hits mozilla-central. (Not that it would break the builds any worse than they are now, but for sanity's sake.)

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/5d47b047e08f

Comment 8

[(not currently active) Ted Mielczarek]

Pushed the tools change:
http://hg.mozilla.org/build/tools/rev/29961f8da532