Valgrind builds should use an in-tree mozconfig

RESOLVED FIXED

Status

P3
enhancement
RESOLVED FIXED
7 years ago
6 months ago

People

(Reporter: ted, Assigned: ted)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [valgrind][mozconfig], URL)

Attachments

(2 attachments, 1 obsolete attachment)

Right now Valgrind builds build a mozconfig file from their build script. Since we've switched to having all our mozconfigs in the source tree, they should use an in-tree mozconfig instead. This would have prevented bug 735295.
See Also: → bug 735295

Updated

7 years ago
Severity: normal → enhancement
Priority: -- → P3
Whiteboard: [valgrind][mozconfig]
Created attachment 607668 [details] [diff] [review]
add in-tree mozconfigs for Valgrind builds

This just copies the nightly build mozconfigs to valgrind mozconfigs, removes some options that are not relevant, and adds a few from the valgrind.sh script that are necessary.
Attachment #607668 - Flags: review?(catlee)
Assignee: nobody → ted.mielczarek
Created attachment 607675 [details] [diff] [review]
make Valgrind builds use in-tree mozconfigs

This patch changes the valgrind.sh script to use the in-tree mozconfigs from the previous patch. It also tweaks the client.mk invocation, because these builds apparently weren't picking up the mozconfig. I bet we broke that somewhere along the way with our mozconfig-find changes.
Attachment #607675 - Flags: review?(catlee)
Blocks: 696299
Comment on attachment 607668 [details] [diff] [review]
add in-tree mozconfigs for Valgrind builds

Review of attachment 607668 [details] [diff] [review]:
-----------------------------------------------------------------

would it make sense to include the linux{,64} mozconfig instead of copying it?
Attachment #607668 - Flags: review?(catlee) → review+

Updated

7 years ago
Attachment #607675 - Flags: review?(catlee) → review+
I guess it's feasible to include the nightly mozconfig and just add our additional options. The options I removed aren't really critical to not be there, they just seemed extraneous. That's probably a better plan to limit the amount of drift we introduce.
Created attachment 607915 [details] [diff] [review]
add in-tree mozconfigs for Valgrind builds

As suggested. This does keep things simpler, and should ensure that the Valgrind mozconfigs track the Nightly mozconfigs more closely.
Attachment #607915 - Flags: review?(catlee)
Attachment #607668 - Attachment is obsolete: true

Updated

7 years ago
Attachment #607915 - Flags: review?(catlee) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/5d47b047e08f

I'll push the build/tools changes once this hits mozilla-central. (Not that it would break the builds any worse than they are now, but for sanity's sake.)
Pushed the tools change:
http://hg.mozilla.org/build/tools/rev/29961f8da532
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.