Last Comment Bug 735598 - Qt QWS embedding (without-x)
: Qt QWS embedding (without-x)
Status: RESOLVED FIXED
:
Product: Core Graveyard
Classification: Graveyard
Component: Widget: Qt (show other bugs)
: 2.0 Branch
: ARM Linux
: -- normal (vote)
: mozilla14
Assigned To: Oleg Romashin (:romaxa)
:
Mentors:
Depends on: 703155 735602
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-14 01:53 PDT by prabindh
Modified: 2016-07-11 21:54 PDT (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patchset_for_bugzilla.tar.gz contains set of patches including config changes that will allow QWS compilation (4.41 KB, application/octet-stream)
2012-03-14 01:53 PDT, prabindh
no flags Details
Added check for MOZ_X11 before using X11 Window types (1.05 KB, patch)
2012-03-14 02:13 PDT, Oleg Romashin (:romaxa)
karlt: review+
Details | Diff | Splinter Review

Description prabindh 2012-03-14 01:53:36 PDT
Created attachment 605686 [details]
patchset_for_bugzilla.tar.gz contains set of patches including config changes that will allow QWS compilation

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:10.0.1) Gecko/20100101 Firefox/10.0.1
Build ID: 20120209214325

Steps to reproduce:

Build without-x configuration with a Qt-embedded-QWS target that does not have X11 support (ie, framebuffer based system), and does not use a Linaro filesystem.  The bug relates to below issues already tackled by Oleg Romashin (thanks!), but does not fully resolve no-x compilation issues on non-Linaro builds.

https://bugzilla.mozilla.org/show_bug.cgi?id=734678
https://bugzilla.mozilla.org/show_bug.cgi?id=734667


Actual results:

Compilation errors in lot of places due to

a) Assumption that WIDGET_QT directly maps to X11

b) Assumption that WIDGET_QT maps to MAEMO and to X11

Hence compilation errors.


Expected results:

No compilation errors. 

I am attaching a patchset that adds a separate cairo-qt-qws configuration, and fixes these issues.
Comment 1 prabindh 2012-03-14 01:55:51 PDT
Patchset also available at,

https://github.com/prabindh/mozilla-embedded/tree/master/patches/13Mar

Right now - I am stuck at libxul.so linking stage due to gcc4.3.3 issues. Planning to move to gcc4.5 and will update.

Also refer to https://bugzilla.mozilla.org/show_bug.cgi?id=735594 for a xpconnect bug found while trying to compile without jsd.
Comment 2 Oleg Romashin (:romaxa) 2012-03-14 02:11:33 PDT
part of that patch queue, located in 
bug 703155 (significant Qt port rework and make it compilable with Qt5 environment.) patches with qt5_ prefix

For QWS specific backend we need this patch:
http://hg.mozilla.org/users/romaxa_gmail.com/embedipc_queue/file/7872d7707032/qt_qws_build.diff
and allow to compile EGL provider for Qt/non-maemo build
http://hg.mozilla.org/users/romaxa_gmail.com/embedipc_queue/file/7872d7707032/webgl_glx_fix.diff
Comment 3 Oleg Romashin (:romaxa) 2012-03-14 02:13:08 PDT
Created attachment 605692 [details] [diff] [review]
Added check for MOZ_X11 before using X11 Window types
Comment 4 Oleg Romashin (:romaxa) 2012-03-14 02:33:59 PDT
Comment on attachment 605686 [details]
patchset_for_bugzilla.tar.gz contains set of patches including config changes that will allow QWS compilation

Oh, did not check patch queue correctly.
But here is some comments about patch queue...
I'm not sure we should create one more cairo-qt-qws configure option, because:
1) Qt5 - is going to be mostly qws by default (no direct X usage)
2) Qt has internal define Q_WS_X11, which could be detected and ifdefed properly.

JSDEBUGGER - need to be posted into separate bug.
Comment 6 Marco Bonardo [::mak] (Away 6-20 Aug) 2012-03-15 07:59:48 PDT
https://hg.mozilla.org/mozilla-central/rev/67146677dfa5

Note You need to log in before you can comment on or make changes to this bug.