Closed Bug 735602 Opened 8 years ago Closed 8 years ago

Add possibility to choose EGL backend on Non-Maemo Linux/Qt/Gtk builds instead ofo GLX

Categories

(Core :: Graphics, defect)

ARM
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: romaxa, Assigned: romaxa)

References

Details

Attachments

(1 file, 2 obsolete files)

Currently we are compiling for Linux target by default GLX provider.
And for maemo EGL provider.
I think it would be more flexible to have option which would allow to enable EGL backend for special configurations.
Blocks: 735598
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #605693 - Flags: review?(mh+mozilla)
Attachment #605693 - Flags: review?(matt.woodrow)
Comment on attachment 605693 [details] [diff] [review]
Allow to use EGL provider for custom Linux targets

Review of attachment 605693 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +5186,5 @@
> +then
> +    MOZ_WEBGL_GLX=
> +    AC_SUBST(MOZ_FORCE_EGL_BACKEND)
> +    AC_DEFINE(MOZ_FORCE_EGL_BACKEND)
> +fi

Please make this more generic. I'd suggest --with-gl-provider=value. value would override the GL_PROVIDER value from gfx/gl/Makefile.in.
Attachment #605693 - Flags: review?(mh+mozilla) → review-
Attached patch Comments addresed (obsolete) — Splinter Review
Attachment #605693 - Attachment is obsolete: true
Attachment #605693 - Flags: review?(matt.woodrow)
Attachment #605938 - Flags: review?(mh+mozilla)
Comment on attachment 605938 [details] [diff] [review]
Comments addresed

Review of attachment 605938 [details] [diff] [review]:
-----------------------------------------------------------------

I'd go further in GLContextProvider.h, removing now redundant things, and would also use this facility for windows and mac (only special case being EGL always being there on windows in addition to WGL). But I'd rather a gfx peer to give their opinion.
Attachment #605938 - Flags: review?(mh+mozilla) → feedback?(jmuizelaar)
Attachment #605938 - Attachment is obsolete: true
Attachment #605938 - Flags: feedback?(jmuizelaar)
Attachment #608549 - Flags: review?(jgilbert)
Comment on attachment 608549 [details] [diff] [review]
Custom GL provider config option

Review of attachment 608549 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me, but I don't know enough about the configure stuff.

Maybe bjacob knows better?
Attachment #608549 - Flags: review?(jgilbert)
Attachment #608549 - Flags: review?(bjacob)
Attachment #608549 - Flags: feedback+
Mike already checked configure stuff
(In reply to Jeff Gilbert [:jgilbert] from comment #6)
> Comment on attachment 608549 [details] [diff] [review]
> Custom GL provider config option
> 
> Review of attachment 608549 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks fine to me, but I don't know enough about the configure stuff.
> 
> Maybe bjacob knows better?

Just in case, did you see comment 4?
Comment on attachment 608549 [details] [diff] [review]
Custom GL provider config option

Alright, sounds good then.
Attachment #608549 - Flags: review?(bjacob)
Attachment #608549 - Flags: review+
Attachment #608549 - Flags: feedback+
Please can you set the target milestone when landing on inbound, along the lines of http://blog.bonardo.net/2012/03/23/how-you-can-help-mozilla-inbound-sheriffs-when-pushing :-)

https://hg.mozilla.org/mozilla-central/rev/6bbe864b5162
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.