Last Comment Bug 735602 - Add possibility to choose EGL backend on Non-Maemo Linux/Qt/Gtk builds instead ofo GLX
: Add possibility to choose EGL backend on Non-Maemo Linux/Qt/Gtk builds instea...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: ARM Linux
: -- normal (vote)
: mozilla14
Assigned To: Oleg Romashin (:romaxa)
:
Mentors:
Depends on:
Blocks: 735598
  Show dependency treegraph
 
Reported: 2012-03-14 02:16 PDT by Oleg Romashin (:romaxa)
Modified: 2012-03-24 13:39 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Allow to use EGL provider for custom Linux targets (3.01 KB, patch)
2012-03-14 02:17 PDT, Oleg Romashin (:romaxa)
mh+mozilla: review-
Details | Diff | Splinter Review
Comments addresed (6.52 KB, patch)
2012-03-14 13:59 PDT, Oleg Romashin (:romaxa)
no flags Details | Diff | Splinter Review
Custom GL provider config option (6.61 KB, patch)
2012-03-22 17:54 PDT, Oleg Romashin (:romaxa)
jgilbert: review+
Details | Diff | Splinter Review

Description Oleg Romashin (:romaxa) 2012-03-14 02:16:00 PDT
Currently we are compiling for Linux target by default GLX provider.
And for maemo EGL provider.
I think it would be more flexible to have option which would allow to enable EGL backend for special configurations.
Comment 1 Oleg Romashin (:romaxa) 2012-03-14 02:17:25 PDT
Created attachment 605693 [details] [diff] [review]
Allow to use EGL provider for custom Linux targets
Comment 2 Mike Hommey [:glandium] 2012-03-14 02:41:29 PDT
Comment on attachment 605693 [details] [diff] [review]
Allow to use EGL provider for custom Linux targets

Review of attachment 605693 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +5186,5 @@
> +then
> +    MOZ_WEBGL_GLX=
> +    AC_SUBST(MOZ_FORCE_EGL_BACKEND)
> +    AC_DEFINE(MOZ_FORCE_EGL_BACKEND)
> +fi

Please make this more generic. I'd suggest --with-gl-provider=value. value would override the GL_PROVIDER value from gfx/gl/Makefile.in.
Comment 3 Oleg Romashin (:romaxa) 2012-03-14 13:59:28 PDT
Created attachment 605938 [details] [diff] [review]
Comments addresed
Comment 4 Mike Hommey [:glandium] 2012-03-15 07:36:30 PDT
Comment on attachment 605938 [details] [diff] [review]
Comments addresed

Review of attachment 605938 [details] [diff] [review]:
-----------------------------------------------------------------

I'd go further in GLContextProvider.h, removing now redundant things, and would also use this facility for windows and mac (only special case being EGL always being there on windows in addition to WGL). But I'd rather a gfx peer to give their opinion.
Comment 5 Oleg Romashin (:romaxa) 2012-03-22 17:54:32 PDT
Created attachment 608549 [details] [diff] [review]
Custom GL provider config option
Comment 6 Jeff Gilbert [:jgilbert] 2012-03-22 18:33:27 PDT
Comment on attachment 608549 [details] [diff] [review]
Custom GL provider config option

Review of attachment 608549 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me, but I don't know enough about the configure stuff.

Maybe bjacob knows better?
Comment 7 Oleg Romashin (:romaxa) 2012-03-22 20:37:27 PDT
Mike already checked configure stuff
Comment 8 Mike Hommey [:glandium] 2012-03-23 00:04:12 PDT
(In reply to Jeff Gilbert [:jgilbert] from comment #6)
> Comment on attachment 608549 [details] [diff] [review]
> Custom GL provider config option
> 
> Review of attachment 608549 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks fine to me, but I don't know enough about the configure stuff.
> 
> Maybe bjacob knows better?

Just in case, did you see comment 4?
Comment 9 Jeff Gilbert [:jgilbert] 2012-03-23 12:40:56 PDT
Comment on attachment 608549 [details] [diff] [review]
Custom GL provider config option

Alright, sounds good then.
Comment 10 Ed Morley [:emorley] 2012-03-24 13:39:35 PDT
Please can you set the target milestone when landing on inbound, along the lines of http://blog.bonardo.net/2012/03/23/how-you-can-help-mozilla-inbound-sheriffs-when-pushing :-)

https://hg.mozilla.org/mozilla-central/rev/6bbe864b5162

Note You need to log in before you can comment on or make changes to this bug.