We need a Twitter OAuth key for Thunderbird (User-agent/UA name is Instantbird)

RESOLVED FIXED in Thunderbird 17.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
7 months ago

People

(Reporter: florian, Assigned: florian)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 17.0
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird15+ fixed, thunderbird16 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
(currently the Twitter accounts use OAuth keys from Instantbird)
Duplicate of this bug: 736004
Summary: We need a Twitter OAuth key for Thunderbird → We need a Twitter OAuth key for Thunderbird (User-agent/UA name is Instantbird)
(Assignee)

Updated

5 years ago
Blocks: 714733
I heard somewhere that JB was the person making this happen…
Assignee: nobody → jb
Status: NEW → ASSIGNED
tracking-thunderbird15: --- → +

Comment 3

5 years ago
What does it specifically take ? Is it just creating a key ?
(Assignee)

Comment 4

5 years ago
(In reply to Jb Piacentino from comment #3)
> What does it specifically take ? Is it just creating a key ?

So 2 things need to happen to resolve this bug:
- We need a Thunderbird key. I expected you (Jb) to resolve this part as, I think, the twitter folks have answered our/your questions related to this.

- Once I have the key to use for Thunderbird, I will need to do a simple patch so that Instantbird and Thunderbird can use different keys but still share the same twitter code. (My plan for that is to put the key in the mail/app/profile/all-thunderbird.js default preference file for Thunderbird, and the equivalent file for Instantbird, instead of hardcoding the key in twitter.js.)
(Assignee)

Comment 5

5 years ago
Created attachment 643419 [details] [diff] [review]
Patch
Assignee: jb → florian
Attachment #643419 - Flags: review?(clokep)
Comment on attachment 643419 [details] [diff] [review]
Patch

Looks good. Let's not forget to use a the Instantbird key when applying this to Instantbird! :)
Attachment #643419 - Flags: review?(clokep) → review+
(Assignee)

Comment 7

5 years ago
Created attachment 643420 [details]
Screenshot of the OAuth dialog when this key is used

And there is a test tweet from the "Thunderbird Chat" application: https://twitter.com/testib/status/225626326386745344
You can see the application name links to "http://www.mozilla.org/thunderbird/"
Attachment #643420 - Flags: ui-review?(bwinton)
Comment on attachment 643420 [details]
Screenshot of the OAuth dialog when this key is used

Awesome!  ui-r=me!
Attachment #643420 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Updated

5 years ago
Attachment #643419 - Flags: approval-comm-beta?
Attachment #643419 - Flags: approval-comm-aurora?

Comment 9

5 years ago
See ! That was not complicated.. I wonder why it took soooo long ;-) Must have been me :D

Thanks !
Comment on attachment 643419 [details] [diff] [review]
Patch

Yeah, I really think we want to have this on aurora/beta.
Attachment #643419 - Flags: approval-comm-beta?
Attachment #643419 - Flags: approval-comm-beta+
Attachment #643419 - Flags: approval-comm-aurora?
Attachment #643419 - Flags: approval-comm-aurora+
comm-central: https://hg.mozilla.org/comm-central/rev/99fa53a669b4
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/7be00c62d51c
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/b40539fb798e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-thunderbird15: --- → fixed
status-thunderbird16: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0

Updated

7 months ago
Blocks: 1310389
You need to log in before you can comment on or make changes to this bug.