Closed
Bug 735642
Opened 12 years ago
Closed 12 years ago
We need a Twitter OAuth key for Thunderbird (User-agent/UA name is Instantbird)
Categories
(Thunderbird :: Instant Messaging, defect)
Thunderbird
Instant Messaging
Tracking
(thunderbird15+ fixed, thunderbird16 fixed)
RESOLVED
FIXED
Thunderbird 17.0
People
(Reporter: florian, Assigned: florian)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
1.65 KB,
patch
|
clokep
:
review+
bwinton
:
approval-comm-aurora+
bwinton
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
173.30 KB,
image/png
|
bwinton
:
ui-review+
|
Details |
(currently the Twitter accounts use OAuth keys from Instantbird)
Updated•12 years ago
|
Summary: We need a Twitter OAuth key for Thunderbird → We need a Twitter OAuth key for Thunderbird (User-agent/UA name is Instantbird)
Comment 2•12 years ago
|
||
I heard somewhere that JB was the person making this happen…
Assignee: nobody → jb
Status: NEW → ASSIGNED
Updated•12 years ago
|
tracking-thunderbird15:
--- → +
Comment 3•12 years ago
|
||
What does it specifically take ? Is it just creating a key ?
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Jb Piacentino from comment #3) > What does it specifically take ? Is it just creating a key ? So 2 things need to happen to resolve this bug: - We need a Thunderbird key. I expected you (Jb) to resolve this part as, I think, the twitter folks have answered our/your questions related to this. - Once I have the key to use for Thunderbird, I will need to do a simple patch so that Instantbird and Thunderbird can use different keys but still share the same twitter code. (My plan for that is to put the key in the mail/app/profile/all-thunderbird.js default preference file for Thunderbird, and the equivalent file for Instantbird, instead of hardcoding the key in twitter.js.)
Assignee | ||
Comment 5•12 years ago
|
||
Assignee: jb → florian
Attachment #643419 -
Flags: review?(clokep)
Comment 6•12 years ago
|
||
Comment on attachment 643419 [details] [diff] [review] Patch Looks good. Let's not forget to use a the Instantbird key when applying this to Instantbird! :)
Attachment #643419 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 7•12 years ago
|
||
And there is a test tweet from the "Thunderbird Chat" application: https://twitter.com/testib/status/225626326386745344 You can see the application name links to "http://www.mozilla.org/thunderbird/"
Attachment #643420 -
Flags: ui-review?(bwinton)
Comment 8•12 years ago
|
||
Comment on attachment 643420 [details]
Screenshot of the OAuth dialog when this key is used
Awesome! ui-r=me!
Attachment #643420 -
Flags: ui-review?(bwinton) → ui-review+
Assignee | ||
Updated•12 years ago
|
Attachment #643419 -
Flags: approval-comm-beta?
Attachment #643419 -
Flags: approval-comm-aurora?
Comment 9•12 years ago
|
||
See ! That was not complicated.. I wonder why it took soooo long ;-) Must have been me :D Thanks !
Comment 10•12 years ago
|
||
Comment on attachment 643419 [details] [diff] [review] Patch Yeah, I really think we want to have this on aurora/beta.
Attachment #643419 -
Flags: approval-comm-beta?
Attachment #643419 -
Flags: approval-comm-beta+
Attachment #643419 -
Flags: approval-comm-aurora?
Attachment #643419 -
Flags: approval-comm-aurora+
Comment 11•12 years ago
|
||
comm-central: https://hg.mozilla.org/comm-central/rev/99fa53a669b4 comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/7be00c62d51c comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/b40539fb798e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
status-thunderbird15:
--- → fixed
status-thunderbird16:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in
before you can comment on or make changes to this bug.
Description
•