Change inactive tab timer clamp setting to something higher than 1hz

RESOLVED FIXED

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
9 months ago

People

(Reporter: mfinkle, Assigned: kbrosnan)

Tracking

(Blocks: 1 bug)

unspecified
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox14 fixed, firefox15 fixed, blocking-fennec1.0 +)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Inactive tabs clamp the timers to 1hz. We could clamp them higher and save some battery life. Suspend forever is not an option, so we need to pick a "high" value.

What value? 1 day?

The pref is "dom.min_background_timeout_value" (see bug 633421)

Updated

5 years ago
OS: Linux → Android
Hardware: x86 → ARM

Updated

5 years ago
blocking-fennec1.0: --- → ?
We'd like to get some data on power usage versus clamping frequency. The A-team is working on power monitoring solutions.
blocking-fennec1.0: ? → -
blocking-fennec1.0: - → ?
For the record, I have no issue with bumping this value up, but I do not want to use the pref to disable timers completely. Note that the value affects any tab that is not the selected tab when Firefox is in the foreground and all tabs when Firefox is in the background.

I think there is a bug about disabling timers, JS and events after a period of being in the background built into the platform. I think that's a better approach and I don't want to use some front-end hacks to simulate that either.

We should also provide a way for users to allow pages to request running in the background.

Again, what value should we use? I see no harm in bumping the threshold to anything in the 10 to 30 second range. Maybe up to 60 seconds.
blocking-fennec1.0: ? → -
Let's test with a 15min throttle. A test page can be found here:
http://people.mozilla.org/~kgupta/bug/761731.html
Assignee: nobody → kbrosnan
blocking-fennec1.0: - → +
(Reporter)

Updated

5 years ago
Duplicate of this bug: 761731
(Assignee)

Comment 5

5 years ago
Created attachment 632069 [details] [diff] [review]
patch to increase the timeout to 15m
Attachment #632069 - Flags: review?(mark.finkle)

Comment 6

5 years ago
Comment on attachment 632069 [details] [diff] [review]
patch to increase the timeout to 15m

Review of attachment 632069 [details] [diff] [review]:
-----------------------------------------------------------------

Doesn't this just add an empty line?
(Assignee)

Comment 7

5 years ago
Comment on attachment 632069 [details] [diff] [review]
patch to increase the timeout to 15m

Doh qupdate why do you hate me.
Attachment #632069 - Attachment is obsolete: true
Attachment #632069 - Flags: review?(mark.finkle)
(Assignee)

Comment 8

5 years ago
Created attachment 632085 [details] [diff] [review]
a patch with some code
Attachment #632085 - Flags: review?(mark.finkle)
Attachment #632085 - Attachment is patch: true
Comment on attachment 632085 [details] [diff] [review]
a patch with some code

I assume this has a noticeable effect on the test file
Attachment #632085 - Flags: review?(mark.finkle) → review+
Comment on attachment 632085 [details] [diff] [review]
a patch with some code

[Triage Comment]
Approving for Aurora and Beta in preparation for the B7 go to build. We can also test in QA with tinderbox builds in the morning.
Attachment #632085 - Flags: approval-mozilla-beta+
Attachment #632085 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/23e8e357b19d
https://hg.mozilla.org/releases/mozilla-aurora/rev/6ccff991c3b1
https://hg.mozilla.org/releases/mozilla-beta/rev/e1f1b8aa81f8
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-firefox14: --- → fixed
status-firefox15: --- → fixed
Resolution: --- → FIXED
Created attachment 632118 [details] [diff] [review]
follow up to disable a test that times out
Attachment #632118 - Flags: review?(mbrubeck)
Might be better to just force the pref back to normal for tests:
http://mxr.mozilla.org/mozilla-central/source/build/automation.py.in#309
Comment on attachment 632118 [details] [diff] [review]
follow up to disable a test that times out

I'm OK with disabling the test in the short-term, but I think we need to reset the timeout pref for mochitests using the link I posted.
Attachment #632118 - Flags: review?(mbrubeck) → review+
Comment on attachment 632118 [details] [diff] [review]
follow up to disable a test that times out

[Approval Request Comment]
Risk to taking this patch (and alternatives if risky): Android-only test-only change to silence a failing test.

String or UUID changes made by this patch: None.
Attachment #632118 - Flags: approval-mozilla-beta?
Attachment #632118 - Flags: approval-mozilla-aurora?
Created attachment 632134 [details] [diff] [review]
patch to change pref for tests
Attachment #632134 - Flags: review?(mbrubeck)
Comment on attachment 632134 [details] [diff] [review]
patch to change pref for tests

I think this method is preferred
Attachment #632134 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/mozilla-central/rev/9d7563ac386c
https://hg.mozilla.org/releases/mozilla-aurora/rev/776c453ae0ea
https://hg.mozilla.org/releases/mozilla-beta/rev/62cad754d390

Updated

5 years ago
Depends on: 763898
Attachment #632118 - Flags: approval-mozilla-beta?
Attachment #632118 - Flags: approval-mozilla-beta-
Attachment #632118 - Flags: approval-mozilla-aurora?
Attachment #632118 - Flags: approval-mozilla-aurora-
Attachment #632118 - Flags: review+ → review-
Comment on attachment 632134 [details] [diff] [review]
patch to change pref for tests

[Triage Comment]
Attachment #632134 - Flags: approval-mozilla-beta+
Attachment #632134 - Flags: approval-mozilla-aurora+

Updated

a year ago
Blocks: 1253346
You need to log in before you can comment on or make changes to this bug.