Closed Bug 736961 Opened 8 years ago Closed 8 years ago

xpidl-parser/header.py delete itself

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla15

People

(Reporter: jhorak, Assigned: gaston)

References

Details

Attachments

(4 files)

After changeset http://hg.mozilla.org/mozilla-central/rev/466c118c3e44 landed
header.py, xpidl.py and typelib.py is deleted when running 'make' in 'xpcom/idl-parser' subdir.

header.py was run by following command:
/usr/bin/python2.7 ../../config/pythonpath.py \
  -I../../other-licenses/ply \
  -I../../xpcom/idl-parser \
  ../../xpcom/idl-parser/header.py --cachedir=. --regen

This breaks building trunk tree in linux right now.
Setting --cachedir=. to --cachedir=cache fix this issue.
Attached patch proposed patchSplinter Review
Attachment #607102 - Flags: review?
Duplicate of this bug: 735624
Comment on attachment 607102 [details] [diff] [review]
proposed patch

Yeah, the "no bug" checkin broke srcdir builds in a rather silly way. However, I recommend that you should never do srcdir build, please use an objdir.
Attachment #607102 - Flags: review? → review?(khuey)
Comment on attachment 607102 [details] [diff] [review]
proposed patch

The cachedir here, the cachedir in config/rules.mk and js/src/config/rules.mk, and the cachedir used in various places in js/xpconnect/src/Makefile.in must be the same.
Attachment #607102 - Flags: review?(khuey) → review-
My patch doesn't work with objdir so my fix is rather wrong.
BTW, the latest ply-3.4 still "stupid"?
ply bundled with m-c is ply-3.3.
Is there a workaround to build firefox, until this bug gets fixed? :)
(In reply to Chamal from comment #8)
> Is there a workaround to build firefox, until this bug gets fixed? :)
By adding:
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-dir
to your mozconfig all object will be put into obj-dir and compilation will go smooth.
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #5)
> Comment on attachment 607102 [details] [diff] [review]
> proposed patch
> 
> The cachedir here, the cachedir in config/rules.mk and
> js/src/config/rules.mk, and the cachedir used in various places in
> js/xpconnect/src/Makefile.in must be the same.

And in addition to that some paths around needs to be adjusted if 'cache' is added to cachedir, as for example xpidlex.py (at least) ends up under that dir.
This patches adresses comment #5 and allows me to build with objdir set and objdir=. (i think the latter mimics what happens with an src build). Not sure a clobber is needed. Kyle, do you think it's worth a try run ? Once it's r+ed and commited i'll ask for beta/aurora approval.
Attachment #622693 - Flags: review?(khuey)
All green on try, setting checkin-needed
Keywords: checkin-needed
[Approval Request Comment]
Regression caused by (bug #): No bug, blame khuey
User impact if declined: failure to build from source tarball without objdir
Testing completed (on m-c, etc.): in this bug
Risk to taking this patch (and alternatives if risky): other failures ?
String changes made by this patch: none
Attachment #623065 - Flags: approval-mozilla-aurora?
[Approval Request Comment]
Regression caused by (bug #): no bug, blame khuey
User impact if declined: failure to build from source tarball without separate objdir
Testing completed (on m-c, etc.): in this bug
Risk to taking this patch (and alternatives if risky): other build failures ?
String changes made by this patch: none

Other notes: this patch is not a hg changeset against mozilla-beta branch, but a patchset against 13.0b2 tarball. It allows me to build it using ./configure/make (so, without objdir), otherwise it fails with :

gmake[6]: Entering directory `/usr/obj/firefox-13.0beta2/mozilla-beta/xpcom/typelib/xpidl'
gmake[6]: *** No rule to make target `../../../xpcom/idl-parser/xpidl.py', needed by `libs'.  Stop.
Attachment #623068 - Flags: approval-mozilla-beta?
Assignee: nobody → landry
https://hg.mozilla.org/mozilla-central/rev/eae1858ccc6d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Depends on: 754625
Attachment #623065 - Flags: approval-mozilla-aurora?
Comment on attachment 623068 [details] [diff] [review]
use separate cachedir for all idl-parser calls (beta backport)

Unsetting approval for aurora/beta since it broke sdk builds (see bug #754625)
Attachment #623068 - Flags: approval-mozilla-beta?
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.