xpidl-parser/header.py delete itself

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jan Horak, Assigned: gaston)

Tracking

Trunk
mozilla15
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Reporter)

Description

5 years ago
After changeset http://hg.mozilla.org/mozilla-central/rev/466c118c3e44 landed
header.py, xpidl.py and typelib.py is deleted when running 'make' in 'xpcom/idl-parser' subdir.

header.py was run by following command:
/usr/bin/python2.7 ../../config/pythonpath.py \
  -I../../other-licenses/ply \
  -I../../xpcom/idl-parser \
  ../../xpcom/idl-parser/header.py --cachedir=. --regen

This breaks building trunk tree in linux right now.
(Reporter)

Comment 1

5 years ago
Setting --cachedir=. to --cachedir=cache fix this issue.
(Reporter)

Comment 2

5 years ago
Created attachment 607102 [details] [diff] [review]
proposed patch
Attachment #607102 - Flags: review?

Updated

5 years ago
Duplicate of this bug: 735624
Comment on attachment 607102 [details] [diff] [review]
proposed patch

Yeah, the "no bug" checkin broke srcdir builds in a rather silly way. However, I recommend that you should never do srcdir build, please use an objdir.
Attachment #607102 - Flags: review? → review?(khuey)
Comment on attachment 607102 [details] [diff] [review]
proposed patch

The cachedir here, the cachedir in config/rules.mk and js/src/config/rules.mk, and the cachedir used in various places in js/xpconnect/src/Makefile.in must be the same.
Attachment #607102 - Flags: review?(khuey) → review-
(Reporter)

Comment 6

5 years ago
My patch doesn't work with objdir so my fix is rather wrong.

Comment 7

5 years ago
BTW, the latest ply-3.4 still "stupid"?
ply bundled with m-c is ply-3.3.

Comment 8

5 years ago
Is there a workaround to build firefox, until this bug gets fixed? :)
(Reporter)

Comment 9

5 years ago
(In reply to Chamal from comment #8)
> Is there a workaround to build firefox, until this bug gets fixed? :)
By adding:
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-dir
to your mozconfig all object will be put into obj-dir and compilation will go smooth.
(Assignee)

Comment 10

5 years ago
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #5)
> Comment on attachment 607102 [details] [diff] [review]
> proposed patch
> 
> The cachedir here, the cachedir in config/rules.mk and
> js/src/config/rules.mk, and the cachedir used in various places in
> js/xpconnect/src/Makefile.in must be the same.

And in addition to that some paths around needs to be adjusted if 'cache' is added to cachedir, as for example xpidlex.py (at least) ends up under that dir.
(Assignee)

Comment 11

5 years ago
Created attachment 622693 [details] [diff] [review]
use separate cachedir for all idl-parser calls

This patches adresses comment #5 and allows me to build with objdir set and objdir=. (i think the latter mimics what happens with an src build). Not sure a clobber is needed. Kyle, do you think it's worth a try run ? Once it's r+ed and commited i'll ask for beta/aurora approval.
Attachment #622693 - Flags: review?(khuey)
Attachment #622693 - Flags: review?(khuey) → review+
(Assignee)

Comment 12

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=a098af1a9683 just to be on the safe side.
(Assignee)

Comment 13

5 years ago
All green on try, setting checkin-needed
Keywords: checkin-needed
(Assignee)

Comment 14

5 years ago
Created attachment 623065 [details] [diff] [review]
use separate cachedir for all idl-parser calls (aurora backport)

[Approval Request Comment]
Regression caused by (bug #): No bug, blame khuey
User impact if declined: failure to build from source tarball without objdir
Testing completed (on m-c, etc.): in this bug
Risk to taking this patch (and alternatives if risky): other failures ?
String changes made by this patch: none
Attachment #623065 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 15

5 years ago
Created attachment 623068 [details] [diff] [review]
use separate cachedir for all idl-parser calls (beta backport)

[Approval Request Comment]
Regression caused by (bug #): no bug, blame khuey
User impact if declined: failure to build from source tarball without separate objdir
Testing completed (on m-c, etc.): in this bug
Risk to taking this patch (and alternatives if risky): other build failures ?
String changes made by this patch: none

Other notes: this patch is not a hg changeset against mozilla-beta branch, but a patchset against 13.0b2 tarball. It allows me to build it using ./configure/make (so, without objdir), otherwise it fails with :

gmake[6]: Entering directory `/usr/obj/firefox-13.0beta2/mozilla-beta/xpcom/typelib/xpidl'
gmake[6]: *** No rule to make target `../../../xpcom/idl-parser/xpidl.py', needed by `libs'.  Stop.
Attachment #623068 - Flags: approval-mozilla-beta?

Updated

5 years ago
Assignee: nobody → landry
https://hg.mozilla.org/integration/mozilla-inbound/rev/eae1858ccc6d
Status: NEW → ASSIGNED
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/eae1858ccc6d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Depends on: 754625
(Assignee)

Updated

5 years ago
Attachment #623065 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 18

5 years ago
Comment on attachment 623068 [details] [diff] [review]
use separate cachedir for all idl-parser calls (beta backport)

Unsetting approval for aurora/beta since it broke sdk builds (see bug #754625)
Attachment #623068 - Flags: approval-mozilla-beta?
Duplicate of this bug: 761900
You need to log in before you can comment on or make changes to this bug.