737413 - gfxCrashReporterUtils.cpp is not thread safe

Status: RESOLVED DUPLICATE of bug 766304

(Core :: Graphics, defect)

Description

[Benoit Girard (:BenWa)]

###!!! ASSERTION: Using observer service off the main thread!: 'Error', file /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/xpcom/ds/nsObserverService.cpp, line 128

Breakpoint 3, nsObserverService::AddObserver (this=0x107e66970, anObserver=0x10933b680, aTopic=0x103383d78 "xpcom-shutdown", ownsWeak=false) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/xpcom/ds/nsObserverService.cpp:128
128	    NS_ENSURE_VALIDCALL
(gdb) where
#0  nsObserverService::AddObserver (this=0x107e66970, anObserver=0x10933b680, aTopic=0x103383d78 "xpcom-shutdown", ownsWeak=false) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/xpcom/ds/nsObserverService.cpp:128
#1  0x00000001015134dd in mozilla::ScopedGfxFeatureReporter::WriteAppNote (this=0x113781580, statusChar=43 '+') at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/gfx/src/gfxCrashReporterUtils.cpp:97
#2  0x0000000102b8fd1c in mozilla::ScopedGfxFeatureReporter::~ScopedGfxFeatureReporter (this=0x113781580) at gfxCrashReporterUtils.h:62
#3  0x0000000102b8ae15 in mozilla::gl::GLContext::InitWithPrefix (this=0x10cc09000, prefix=0x103415bdc "gl", trygl=true) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/gfx/gl/GLContext.cpp:468
#4  0x0000000102b9341b in mozilla::gl::GLContextCGL::Init (this=0x10cc09000) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/gfx/gl/GLContextProviderCGL.mm:156
#5  0x0000000102b91735 in mozilla::gl::GLContextProviderCGL::GetGlobalContext () at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/gfx/gl/GLContextProviderCGL.mm:650
#6  0x0000000102b917c4 in mozilla::gl::GetGlobalContextCGL () at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/gfx/gl/GLContextProviderCGL.mm:435
#7  0x0000000102b91b0d in mozilla::gl::GLContextProviderCGL::CreateForWindow (aWidget=0x10a8958a0) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/gfx/gl/GLContextProviderCGL.mm:445
#8  0x0000000102b6a246 in mozilla::layers::LayerManagerOGL::CreateContext (this=0x10dc86bd0) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/gfx/layers/opengl/LayerManagerOGL.cpp:172
#9  0x000000010273d748 in mozilla::layers::LayerManagerOGL::Initialize (this=0x10dc86bd0, force=false) at LayerManagerOGL.h:110
#10 0x0000000102b7b678 in mozilla::layers::CompositorParent::AllocPLayers (this=0x10d6ae800, backendType=@0x11378193c) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/gfx/layers/ipc/CompositorParent.cpp:357
#11 0x000000010288dc62 in mozilla::layers::PCompositorParent::OnMessageReceived (this=0x10d6ae800, __msg=@0x1137819f0, __reply=@0x1137819a0) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/builds/obj-ff-64dbg/ipc/ipdl/PCompositorParent.cpp:392
#12 0x000000010281d8d8 in mozilla::ipc::SyncChannel::OnDispatchMessage (this=0x10d6ae810, msg=@0x1137819f0) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/ipc/glue/SyncChannel.cpp:175
#13 0x000000010281436a in mozilla::ipc::RPCChannel::OnMaybeDequeueOne (this=0x10d6ae810) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/ipc/glue/RPCChannel.cpp:432
#14 0x00000001028178b7 in DispatchToMethod<mozilla::ipc::RPCChannel, bool (mozilla::ipc::RPCChannel::*)()> (obj=0x10d6ae810, method={__pfn = 0x10281418c <mozilla::ipc::RPCChannel::OnMaybeDequeueOne()>, __delta = 0}, arg=@0x113b940b0) at tuple.h:383
#15 0x00000001028178f4 in RunnableMethod<mozilla::ipc::RPCChannel, bool (mozilla::ipc::RPCChannel::*)(), Tuple0>::Run (this=0x113b94080) at task.h:307
#16 0x0000000102815c6d in mozilla::ipc::RPCChannel::RefCountedTask::Run (this=0x113b17df0) at RPCChannel.h:462
#17 0x000000010281795f in mozilla::ipc::RPCChannel::DequeueTask::Run (this=0x10a2f0240) at RPCChannel.h:485
#18 0x0000000102a6cdec in MessageLoop::RunTask (this=0x113781d30, task=0x10a2f0240) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/ipc/chromium/src/base/message_loop.cc:318
#19 0x0000000102a6d22c in MessageLoop::DeferOrRunPendingTask (this=0x113781d30, pending_task=@0x113781b90) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/ipc/chromium/src/base/message_loop.cc:326
#20 0x0000000102a6d708 in MessageLoop::DoWork (this=0x113781d30) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/ipc/chromium/src/base/message_loop.cc:426
#21 0x0000000102a74939 in base::MessagePumpDefault::Run (this=0x10a2f0120, delegate=0x113781d30) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/ipc/chromium/src/base/message_pump_default.cc:23
#22 0x0000000102a6d00a in MessageLoop::RunInternal (this=0x113781d30) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/ipc/chromium/src/base/message_loop.cc:208
#23 0x0000000102a6d021 in MessageLoop::RunHandler (this=0x113781d30) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/ipc/chromium/src/base/message_loop.cc:201
#24 0x0000000102a6d082 in MessageLoop::Run (this=0x113781d30) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/ipc/chromium/src/base/message_loop.cc:175
#25 0x0000000102a9028a in base::Thread::ThreadMain (this=0x10a2e5220) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/ipc/chromium/src/base/thread.cc:156
#26 0x0000000102abf930 in ThreadFunc (closure=0x10a2e5220) at /Volumes/SSD-Mac1/Users/benoitgirard/ssd-mozilla/mozilla-central/tree/ipc/chromium/src/base/platform_thread_posix.cc:26
#27 0x00007fff8c01c8bf in _pthread_start ()
#28 0x00007fff8c01fb75 in thread_start ()

Comment 1

[Benoit Girard (:BenWa)]

We should just use the gfxPlatform deinit methods instead of xpcom shutdown.

Comment 2

[Chris Peterson [:cpeterson]]

Mass tracking-e10s flag change. Filter bugmail on "2be0fcce-e36a-4e2c-aa80-0e3d33eb5406".