Chat - ugly border around avatar on the right

RESOLVED WORKSFORME

Status

defect
RESOLVED WORKSFORME
7 years ago
6 months ago

People

(Reporter: andreasn, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Reporter

Description

7 years ago
Posted image screenshot
The avatars in the right pane have a border around them. On avatars that have a picture this looks odd, but it don't look quite right on avatars that fall back on the generic image either.
I suggest we drop this border.
Blocks: 714733
Like on Windows removed the border.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #612860 - Flags: review?(nisses.mail)
(In reply to Andreas Nilsson (:andreasn) from comment #0)
> Created attachment 607604 [details]
> screenshot
> 
> The avatars in the right pane have a border around them. On avatars that
> have a picture this looks odd, but it don't look quite right on avatars that
> fall back on the generic image either.
> I suggest we drop this border.

This border was there for consistency with the display in the top part of the "Show accounts" dialog, where it would look odd without this border (see also the effect when hovering the icon there).

I would recommend WONTFIX.

Note: another Chat bug where I wasn't CC'ed.
Reporter

Comment 3

7 years ago
(In reply to Florian Quèze from comment #2)
> (In reply to Andreas Nilsson (:andreasn) from comment #0)

> This border was there for consistency with the display in the top part of
> the "Show accounts" dialog, where it would look odd without this border (see
> also the effect when hovering the icon there).
> 
> I would recommend WONTFIX.

So my main issue with the current appearance is that the borders are rounded, while the photo inside is not (so it looks really odd in the corners). I think the best solution would be to have images with rounded corners (similar to what we have in the chat view) at the same size as the empty avatars. That will assure it looks similar enough to the image in the account dialog.

> Note: another Chat bug where I wasn't CC'ed.

Oops, sorry for that! :(
I tried to give the photo a border-radius. It has already a radius of 5px and on the empty image this works because it is attached as a background image. But the individual photo is attached as src="..." and this overlays the background and no css code can manipulate this.

If this photo could attached similar as the photo in Address book then css could do his work.
Reporter

Comment 5

7 years ago
Comment on attachment 612860 [details] [diff] [review]
Remove the border

Setting review minus until can come up with a better solution that adresses Florians concerns.
Attachment #612860 - Flags: review?(nisses.mail) → review-
Unassigning me because this isn't doable only with CSS.
Assignee: richard.marti → nobody
Status: ASSIGNED → NEW
I'm assigning myself only as a note to myself that I want to fix this later.
Assignee: nobody → josiah
For reference, bug 955673 dealt with a similar issue in Instantbird's awesometab.
I'm extremely busy, so I'm un-assigning myself, at least for the time being.
Assignee: josiah → nobody

Comment 10

6 months ago
Hello,
I would like to work on this.
Posted image avatar.png
Checked the avatar and it seems the rounded image was fixed somewhere.
Sorry Devika but this bug is fixed and there is nothing to do here.
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.