Last Comment Bug 737986 - Win wifi headers conflict with the new Win8 SDK
: Win wifi headers conflict with the new Win8 SDK
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking (show other bugs)
: Trunk
: x86_64 Windows 8.1
: -- normal (vote)
: mozilla14
Assigned To: Jim Mathies [:jimm]
:
Mentors:
Depends on:
Blocks: elm-merge
  Show dependency treegraph
 
Reported: 2012-03-21 12:00 PDT by Jim Mathies [:jimm]
Modified: 2014-07-24 11:06 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (567 bytes, patch)
2012-03-21 13:54 PDT, Jim Mathies [:jimm]
doug.turner: review+
Details | Diff | Splinter Review

Description Jim Mathies [:jimm] 2012-03-21 12:00:32 PDT
http://hg.mozilla.org/projects/elm/rev/9c985bdad2f1

Note this isn't the proper fix, instead of checking for MOZ_WIN8METRO, this should be checking for the 602 sdk.
Comment 1 Jim Mathies [:jimm] 2012-03-21 12:56:57 PDT
(In reply to Masatoshi Kimura [:emk] from comment #30)
> Comment on attachment 605186 [details] [diff] [review]
> wifi code header fixes
> 
> > +#ifndef MOZ_WIN8METRO
> > +#include <ntddndis.h>
> > +#include <winioctl.h>
> > +#endif
> Are these headers even required? No one refer APIs in those headers after
> bug 600235.

Might not be, I'll test on a regular mc build.
Comment 2 Jim Mathies [:jimm] 2012-03-21 13:54:14 PDT
Created attachment 608081 [details] [diff] [review]
fix

These are no longer needed for our normal desktop builds.
Comment 3 Doug Turner (:dougt) 2012-03-21 14:55:14 PDT
make sure things continue to build :)
Comment 4 Jim Mathies [:jimm] 2012-03-21 15:57:16 PDT
It built locally without those headers, but I'll throw all of these at try to be safe.
Comment 5 Doug Turner (:dougt) 2012-03-21 16:01:51 PDT
sounds like you've done this before... :D
Comment 7 Marco Bonardo [::mak] 2012-03-22 18:11:21 PDT
https://hg.mozilla.org/mozilla-central/rev/90e47dac65b6

Note You need to log in before you can comment on or make changes to this bug.