Closed Bug 737986 Opened 9 years ago Closed 9 years ago

Win wifi headers conflict with the new Win8 SDK

Categories

(Core :: Networking, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: jimm, Assigned: jimm)

References

Details

Attachments

(1 file)

http://hg.mozilla.org/projects/elm/rev/9c985bdad2f1

Note this isn't the proper fix, instead of checking for MOZ_WIN8METRO, this should be checking for the 602 sdk.
(In reply to Masatoshi Kimura [:emk] from comment #30)
> Comment on attachment 605186 [details] [diff] [review]
> wifi code header fixes
> 
> > +#ifndef MOZ_WIN8METRO
> > +#include <ntddndis.h>
> > +#include <winioctl.h>
> > +#endif
> Are these headers even required? No one refer APIs in those headers after
> bug 600235.

Might not be, I'll test on a regular mc build.
Attached patch fixSplinter Review
These are no longer needed for our normal desktop builds.
Assignee: nobody → jmathies
Attachment #608081 - Flags: review?(doug.turner)
Attachment #608081 - Flags: review?(doug.turner) → review+
make sure things continue to build :)
It built locally without those headers, but I'll throw all of these at try to be safe.
sounds like you've done this before... :D
https://hg.mozilla.org/mozilla-central/rev/90e47dac65b6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
No longer blocks: 737975
Blocks: elm-merge
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.