Win wifi headers conflict with the new Win8 SDK

RESOLVED FIXED in mozilla14

Status

()

Core
Networking
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
mozilla14
x86_64
Windows 8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
http://hg.mozilla.org/projects/elm/rev/9c985bdad2f1

Note this isn't the proper fix, instead of checking for MOZ_WIN8METRO, this should be checking for the 602 sdk.
(Assignee)

Comment 1

5 years ago
(In reply to Masatoshi Kimura [:emk] from comment #30)
> Comment on attachment 605186 [details] [diff] [review]
> wifi code header fixes
> 
> > +#ifndef MOZ_WIN8METRO
> > +#include <ntddndis.h>
> > +#include <winioctl.h>
> > +#endif
> Are these headers even required? No one refer APIs in those headers after
> bug 600235.

Might not be, I'll test on a regular mc build.
(Assignee)

Comment 2

5 years ago
Created attachment 608081 [details] [diff] [review]
fix

These are no longer needed for our normal desktop builds.
Assignee: nobody → jmathies
Attachment #608081 - Flags: review?(doug.turner)

Updated

5 years ago
Attachment #608081 - Flags: review?(doug.turner) → review+

Comment 3

5 years ago
make sure things continue to build :)
(Assignee)

Comment 4

5 years ago
It built locally without those headers, but I'll throw all of these at try to be safe.

Comment 5

5 years ago
sounds like you've done this before... :D
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/90e47dac65b6
https://hg.mozilla.org/mozilla-central/rev/90e47dac65b6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
(Assignee)

Updated

5 years ago
No longer blocks: 737975
(Assignee)

Updated

5 years ago
Blocks: 747347
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.