Closed
Bug 738884
Opened 12 years ago
Closed 12 years ago
Investigate adding MOZ_URL_CLASSIFIER=1 (url-classifier) to SeaMonkey
Categories
(SeaMonkey :: Build Config, enhancement)
SeaMonkey
Build Config
Tracking
(Not tracked)
VERIFIED
FIXED
seamonkey2.11
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
Attachments
(1 file)
|
852 bytes,
patch
|
Callek
:
review+
benjamin
:
feedback+
|
Details | Diff | Splinter Review |
MOZ_URL_CLASSIFIER=1 is part of MOZ_SAFE_BROWSING=1, which FF and TB have, but not SM (yet). XulRunner has MOZ_URL_CLASSIFIER=1, then I wonder whether SM could/should have that too ftb. Benjamin, would that simply package the files etc, or would it have some other actual (behavioral) effects?
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #608967 -
Flags: feedback?(benjamin)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 608967 [details] [diff] [review] (Av1) Add MOZ_URL_CLASSIFIER=1 to SeaMonkey Succeeds as http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=27edc56ea7d2 + /pub/thunderbird/try-builds/sgautherie.bz@free.fr-27edc56ea7d2/try-comm-central-win32-debug seamonkey-2.11a1.en-US.win32.zip
|
||
Comment 3•12 years ago
|
||
Comment on attachment 608967 [details] [diff] [review] (Av1) Add MOZ_URL_CLASSIFIER=1 to SeaMonkey There is no effect unless you also set browser.safebrowsing.malware.enabled. I don't know whether you need a specific agreement with Google to do that or not.
Attachment #608967 -
Flags: feedback?(benjamin) → feedback+
|
|
Assignee | |
Updated•12 years ago
|
Attachment #608967 -
Flags: review?(bugspam.Callek)
|
||
Comment 4•12 years ago
|
||
What does adding this get us?
|
|
Assignee | |
Comment 5•12 years ago
|
||
(In reply to Justin Wood (:Callek) from comment #4) > What does adding this get us? It just makes this API available, fwiw.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Flags: in-testsuite-
|
||
Comment 6•12 years ago
|
||
(In reply to Justin Wood (:Callek) from comment #4) > What does adding this get us? Nothing at all except less build difference from Firefox.
|
|
||
Comment 7•12 years ago
|
||
Comment on attachment 608967 [details] [diff] [review] (Av1) Add MOZ_URL_CLASSIFIER=1 to SeaMonkey Thanks KaiRo,serge for the prompt answers. That is as I thought I just didn't want to have to figure it out in detail.
Attachment #608967 -
Flags: review?(bugspam.Callek) → review+
|
|
Assignee | |
Comment 8•12 years ago
|
||
http://hg.mozilla.org/comm-central/rev/095efea00545
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.11
|
|
Assignee | |
Updated•12 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•