738884 - Investigate adding MOZ_URL_CLASSIFIER=1 (url-classifier) to SeaMonkey

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, enhancement)

Description

[Serge Gautherie (:sgautherie)]

MOZ_URL_CLASSIFIER=1 is part of MOZ_SAFE_BROWSING=1, which FF and TB have, but not SM (yet).

XulRunner has MOZ_URL_CLASSIFIER=1, then I wonder whether SM could/should have that too ftb.
Benjamin, would that simply package the files etc, or would it have some other actual (behavioral) effects?

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Add MOZ_URL_CLASSIFIER=1 to SeaMonkey

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 608967 [details] [diff] [review]
(Av1) Add MOZ_URL_CLASSIFIER=1 to SeaMonkey

Succeeds as
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=27edc56ea7d2
+
/pub/thunderbird/try-builds/[e-mail]-27edc56ea7d2/try-comm-central-win32-debug
seamonkey-2.11a1.en-US.win32.zip

Comment 3

[Benjamin Smedberg]

Comment on attachment 608967 [details] [diff] [review]
(Av1) Add MOZ_URL_CLASSIFIER=1 to SeaMonkey

There is no effect unless you also set browser.safebrowsing.malware.enabled. I don't know whether you need a specific agreement with Google to do that or not.

Comment 4

[Justin Wood (:Callek)]

What does adding this get us?

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to Justin Wood (:Callek) from comment #4)
> What does adding this get us?

It just makes this API available, fwiw.

Comment 6

[Robert Kaiser]

(In reply to Justin Wood (:Callek) from comment #4)
> What does adding this get us?

Nothing at all except less build difference from Firefox.

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 608967 [details] [diff] [review]
(Av1) Add MOZ_URL_CLASSIFIER=1 to SeaMonkey

Thanks KaiRo,serge for the prompt answers. That is as I thought I just didn't want to have to figure it out in detail.

Comment 8

[Serge Gautherie (:sgautherie)]

http://hg.mozilla.org/comm-central/rev/095efea00545

Comment 9

[Serge Gautherie (:sgautherie)]

V.Fixed, as we got bug 739687 ;->