738938 - Progress throbber shows again when loading about:home on startup

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Peter Retzer (:pretzer)]

Bug 718846 and bug 719868 fixed this some time ago, but this regressed again, maybe with the maple merge.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Not maple. The about:home page is loaded into Gecko and showProgress is set to false, so no throbber is shown. BUT then the new tab is selected, to make it active, and Tab (or Tabs) has code to handle Tab:Selected" and it shows the throbber because the page is still loading.

Comment 3

[Peter Retzer (:pretzer)]

renominating to see if this would fall under the new soft-blocking category.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 613319 [details] [diff] [review]
patch

I don't like this because mState is not the same as the return of getState and that could lead to problems.

Comment 7

[:Margaret Leibovic]

Uh, oops, I took this without looking at it.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/423e8d6463ff

Comment 10

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/423e8d6463ff

Comment 11

[Cristian Nicolae (:xti)]

Throbber doesn't show up anymore on the latest Nightly build, when about:home is loaded at start up. Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-22)
Device: Galaxy Nexus
OS: Android 4.0.2