autoFill should be disabled by the autocomplete preference

VERIFIED FIXED in Firefox 14

Status

()

defect
VERIFIED FIXED
7 years ago
Last month

People

(Reporter: Virtual, Assigned: mak)

Tracking

({nightly-community, regression})

14 Branch
Firefox 15
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox14+ fixed)

Details

Attachments

(4 attachments)

Location bar suggest some sites from bookmarks, even if all settings are disabled for autofilling in options...

Comment 4

7 years ago
Confirmed on Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20120328 Firefox/14.0a1 ID:20120328031211
Version: unspecified → Trunk
FYI - This is regression from version 13. When I will have more free time I will try to find it.
I imagine this is because the inline autocomplete search doesn't obey the "autocomplete" prefs.
Blocks: 735187
No longer blocks: 405745, 566489
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Assignee

Comment 7

7 years ago
(In reply to Gavin Sharp (use gavin@gavinsharp.com for email) from comment #6)
> I imagine this is because the inline autocomplete search doesn't obey the
> "autocomplete" prefs.

right.
BUMP, Will it make into Firefox 13 ?
I'm asking, because Firefox 12 was released and this bug is hella annoying as I always use location bar for google search and this issue make it completely unavailable ;p
So please, don't forget about this.
(In reply to Virtual_ManPL from comment #8)
> BUMP, Will it make into Firefox 13 ?

Inline auto-complete won't ship until FF14, so tracking for that release.
mak, would you be the right person to look into this for FF14, or would ddahl be?
Assignee: nobody → mak77
Assignee

Comment 11

7 years ago
I may look at it, if we consider it a blocker for enabling the feature, currently we have no UI to enable/disable the feature, the prefs UI above controls the popup behavior, though that's completely unclear to the end user.
Assignee

Updated

7 years ago
Blocks: 746572
Assignee

Comment 12

7 years ago
I will split out some complication from here.

Basically, the blocking issue is that having autocomplete UI pref set to "Suggest nothing" actually is confusing, cause autoFill keeps suggesting urls. This should be easy to patch and test, and safe to backport to Aurora.

The issue on top, that I'd move to a separate bug, is that autoFill doesn't obey when selecting only-history or only-bookmarks options.  This is quite more complicated to get right, especially from a performances point of view. Since these are more technical options and autoFill acts already is some sort of exotic way (looking detached from the popup results and only filling typed entries) this issue looks far less problematic to live with.
Assignee

Comment 13

7 years ago
And as a side note to issue 2, we also have bug 530209, that suggests we want to revise the ui there, to clarify it.
(In reply to Marco Bonardo [:mak] from comment #12)

I concur wholeheartedly!
Assignee

Updated

7 years ago
Blocks: 751709
Assignee

Updated

7 years ago
Summary: Location bar suggest sth from bookmarks even if all settings are disabled for autofilling in options → autoFill should be disabled by the autocomplete preference
Assignee

Comment 15

7 years ago
Posted patch patch v1.0Splinter Review
Attachment #621001 - Flags: review?(dietrich)
Assignee

Updated

7 years ago
Severity: major → normal
Flags: in-testsuite+
Comment on attachment 621001 [details] [diff] [review]
patch v1.0

Review of attachment 621001 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/tests/inline/test_autocomplete_functional.js
@@ +34,5 @@
>    "vis",
>    "visit2.mozilla.org/",
>    function ()
>    {
> +    Services.prefs.setBoolPref("browser.urlbar.autoFill", true);

optional fix: i wish this could be done in the right test, as a cleanup func, instead of spread across to an unrelated test.
Attachment #621001 - Flags: review?(dietrich) → review+
Assignee

Comment 17

7 years ago
(In reply to Dietrich Ayala (:dietrich) from comment #16)
> optional fix: i wish this could be done in the right test, as a cleanup
> func, instead of spread across to an unrelated test.

will move it to the head, so that each test starts in a clean env with known prefs setup.
https://hg.mozilla.org/mozilla-central/rev/00c018e8dcef
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Verified with latest hourly.
Works properly now.
Thank you very much!
Status: RESOLVED → VERIFIED
Assignee

Comment 21

7 years ago
Comment on attachment 621001 [details] [diff] [review]
patch v1.0

[Approval Request Comment]
Regression caused by (bug #): No regression, this is a blocker for keeping the feature enabled in Firefox 14
User impact if declined: Disable the feature
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): quite low, small patch leveraging existing code paths
String changes made by this patch: none
Attachment #621001 - Flags: approval-mozilla-aurora?
Comment on attachment 621001 [details] [diff] [review]
patch v1.0

[Triage Comment]
Approved for Aurora 14 since this will partially dictate whether the feature is left enabled on that release.
Attachment #621001 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.