751709 - autoFill should obey history-only or bookmarks-only autocomplete options

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=740076#c12

Briefly, we will obey the simple "enabled" pref, but not the advanced behavior of limiting results to history or bookmarks...
It may also be tricky considered the many combination the autocomplete algorithm may have.
Depending on the direction of bug 530209 this may even end up being a wontfix (if for example we'd define an Autocomplete section that gets disabled/disappears when it's unchecked, with options inside it that clarify they refer to the popup results).

Comment 3

[:Gavin Sharp [email: [e-mail]]]

If we can't have autoFill properly filter results based on their state according to the preference, why not just disable it entirely when you select a non-default value for browser.urlbar.default.behavior (in addition to when autocomplete.enabled is false)?

Comment 4

[Peter 'vt100' Schwindt]

Is there any progress on this one? Looks like this new behaviour is known since the dev days of FF14. But unfortunately this has been silently removed from the feature list, but not from the preferences interface.

Gavin: Me? Or Marco?

Comment 5

[:Gavin Sharp [email: [e-mail]]]

My comment was addressed to the general audience of would-be bug fixers, including but not limited to Marco :)

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #3)
> If we can't have autoFill properly filter results based on their state
> according to the preference, why not just disable it entirely when you
> select a non-default value for browser.urlbar.default.behavior (in addition
> to when autocomplete.enabled is false)?

+1, I think this is the best way on.

Comment 8

[Christoph Anton Mitterer]

Can’t quite understand why FF has contradicting behaviour here:
I've selected to just use bookmarks... and in the dropdown list that pops up, this actually works,... but the address bar itself is auto-completed with some of the domains from the history.

Not just illogical, but also quite annoying; and this is new behaviour since some version

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

it needs much deeper changes to properly distinguish history and bookmarks there, I'm going to file a bug to implement comment 3.

Comment 11

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

fixed in UnifiedComplete.

The fix makes so that we act properly for bookmarks or history, for more complicated behaviors we disable autoFill.

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Andrei, if you've already verified this in some other UnifiedComplete bug, you can go ahead and qe-verify- this. Thanks!

Comment 13

[Andrei Vaida [:avaida]]

(In reply to Liz Henry :lizzard from comment #12)
> Andrei, if you've already verified this in some other UnifiedComplete bug,
> you can go ahead and qe-verify- this. Thanks!

Yes, the functionality behind "When using the location bar, suggest" preference has already been tested and confirmed as working properly.