740269 - Download should be recorded after confirmation instead of on-click

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Description

[krupa raj[:krupa]]

firefox 12

steps to reproduce:
1. Open Firebug->Net
2. Load https://marketplace-dev.allizom.org/en-US/search/
3. Click on 'Install' buttons for one of the apps


observed behavior:
We do a POST to record the download on clicking on the install button. This is inaccurate sonce the user can still cancel the install. This is more obvious in Firefox 12, but is still true for 13 and later versions

Comment 1

[Christopher Van Wiemeersch [:cvan]]

For Firefox 13+ only we could use this https://developer.mozilla.org/en/Apps/Apps_JavaScript_API/navigator.mozApps.amInstalled

If you're using anything else, we may not be able to do any better than the `onsuccess` callback (https://developer.mozilla.org/en/Apps/Apps_JavaScript_API/navigator.mozApps.install) which actually runs on success of the installation prompt not the user's acceptance of installation.

Comment 2

[Wil Clouser [:clouserw]]

In our current world, don't the install functions have success callbacks we could use?

Comment 3

[Christopher Van Wiemeersch [:cvan]]

(In reply to Wil Clouser [:clouserw] from comment #2)
> In our current world, don't the install functions have success callbacks we
> could use?

Yes.

The current flow:

1) Generate receipt + log install
2) Send receipt to navigator.mozApps.install
3) Accept install

What we could/should do:

1) Generate receipt
2) Send receipt to navigator.mozApps.install
4) Accept install
3) Log install

Comment 4

[Christopher Van Wiemeersch [:cvan]]

(In reply to Wil Clouser [:clouserw] from comment #2)
> In our current world, don't the install functions have success callbacks we
> could use?

Yes.

The current flow:

1) Generate receipt + log install
2) Send receipt to navigator.mozApps.install
3) Accept install

What we could/should do:

1) Generate receipt
2) Send receipt to navigator.mozApps.install
3) Accept install
4) Log install

Comment 6

[Matt Basta [:basta]]

Is this still something we want? It's really easy to do with the new button deferreds.

Comment 7

[Wil Clouser [:clouserw]]

aye

Comment 8

[Matt Basta [:basta]]

https://github.com/mozilla/fireplace/commit/4cb70dbf1db967435d906e0a2f6dbf9c2dd82883

http://i.imgur.com/OQxjtWv.png