The default bug view has changed. See this FAQ.

Put the debugger in its own compartment again

RESOLVED FIXED in Firefox 14

Status

()

Firefox
Developer Tools: Debugger
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: past, Assigned: past)

Tracking

Trunk
Firefox 14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [chrome-debug])

Attachments

(1 attachment, 1 obsolete attachment)

Bug 703718 removed the sandbox that ensured the debugger was in a separate compartment from the debuggee. We are now ready to support the chrome debugging case and the engine has not yet developed the new protection mechanism that would have made the sandbox approach redundant. Therefore we need to revert the change from bug 703718 in order to move forward with chrome debugging for now.
Assignee: nobody → past
Status: NEW → ASSIGNED
Created attachment 616175 [details] [diff] [review]
Working patch

This should do it.
Attachment #616175 - Flags: review?(dcamp)

Comment 2

5 years ago
At the work week reverting bug 703718 wasn't enough, Jason also had to manually instantiate the jsdebugger component instead of using jsdebugger.jsm.  Do you want to do that here or in a followup?
(In reply to Dave Camp (:dcamp) from comment #2)
> At the work week reverting bug 703718 wasn't enough, Jason also had to
> manually instantiate the jsdebugger component instead of using
> jsdebugger.jsm.  Do you want to do that here or in a followup?

Ah, forgot about that. Yeah, I'll do it here.
Attachment #616175 - Flags: review?(dcamp)
Created attachment 616197 [details] [diff] [review]
Working patch v2

V2, now with the workaround to the jsdebugger.jsm loading issue.
Attachment #616175 - Attachment is obsolete: true
Attachment #616197 - Flags: review?(dcamp)

Comment 5

5 years ago
Try run for 166fe9b02435 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=166fe9b02435
Results (out of 60 total builds):
    exception: 25
    success: 12
    failure: 23
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/pastithas@mozilla.com-166fe9b02435

Comment 6

5 years ago
Try run for cc66e1fd5d84 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=cc66e1fd5d84
Results (out of 221 total builds):
    exception: 1
    success: 181
    warnings: 38
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/pastithas@mozilla.com-cc66e1fd5d84
(In reply to Mozilla RelEng Bot from comment #5)
> Try run for 166fe9b02435 is complete.
> Detailed breakdown of the results available here:
>     https://tbpl.mozilla.org/?tree=Try&rev=166fe9b02435
> Results (out of 60 total builds):
>     exception: 25
>     success: 12
>     failure: 23
> Builds (or logs if builds failed) available at:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/pastithas@mozilla.
> com-166fe9b02435

Ignore this try run, it was canceled before completion.

Updated

5 years ago
Attachment #616197 - Flags: review?(dcamp) → review+
Comment on attachment 616197 [details] [diff] [review]
Working patch v2

This is a devtools-only change that shouldn't affect Fennec, but since it touches toolkit/ and Fennec has (preffed off) debugger support (bug 739966), lucasr or mfinkle may want to have a look. If people are worried for some reason, I'll also note that we don't need to get this in for Firefox 14, but it would help a lot with the patch queue juggling we are currently doing.
Attachment #616197 - Flags: approval-mozilla-central?
Attachment #616197 - Flags: approval-mozilla-central? → approval-mozilla-central+
https://hg.mozilla.org/integration/fx-team/rev/b9914d4ebc92
Whiteboard: [chrome-debug] → [chrome-debug][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/b9914d4ebc92
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [chrome-debug][fixed-in-fx-team] → [chrome-debug]

Updated

5 years ago
Target Milestone: --- → Firefox 14
Depends on: 749550
You need to log in before you can comment on or make changes to this bug.