740803 - Put the debugger in its own compartment again

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

Bug 703718 removed the sandbox that ensured the debugger was in a separate compartment from the debuggee. We are now ready to support the chrome debugging case and the engine has not yet developed the new protection mechanism that would have made the sandbox approach redundant. Therefore we need to revert the change from bug 703718 in order to move forward with chrome debugging for now.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Working patch

This should do it.

Comment 2

[Dave Camp (:dcamp)]

At the work week reverting bug 703718 wasn't enough, Jason also had to manually instantiate the jsdebugger component instead of using jsdebugger.jsm.  Do you want to do that here or in a followup?

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Dave Camp (:dcamp) from comment #2)
> At the work week reverting bug 703718 wasn't enough, Jason also had to
> manually instantiate the jsdebugger component instead of using
> jsdebugger.jsm.  Do you want to do that here or in a followup?

Ah, forgot about that. Yeah, I'll do it here.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Working patch v2

V2, now with the workaround to the jsdebugger.jsm loading issue.

Comment 5

[Mozilla RelEng Bot]

Try run for 166fe9b02435 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=166fe9b02435
Results (out of 60 total builds):
    exception: 25
    success: 12
    failure: 23
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-166fe9b02435

Comment 6

[Mozilla RelEng Bot]

Try run for cc66e1fd5d84 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=cc66e1fd5d84
Results (out of 221 total builds):
    exception: 1
    success: 181
    warnings: 38
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-cc66e1fd5d84

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Mozilla RelEng Bot from comment #5)
> Try run for 166fe9b02435 is complete.
> Detailed breakdown of the results available here:
>     https://tbpl.mozilla.org/?tree=Try&rev=166fe9b02435
> Results (out of 60 total builds):
>     exception: 25
>     success: 12
>     failure: 23
> Builds (or logs if builds failed) available at:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/pastithas@mozilla.
> com-166fe9b02435

Ignore this try run, it was canceled before completion.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 616197 [details] [diff] [review]
Working patch v2

This is a devtools-only change that shouldn't affect Fennec, but since it touches toolkit/ and Fennec has (preffed off) debugger support (bug 739966), lucasr or mfinkle may want to have a look. If people are worried for some reason, I'll also note that we don't need to get this in for Firefox 14, but it would help a lot with the patch queue juggling we are currently doing.

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/b9914d4ebc92

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/b9914d4ebc92