gkmedias.dll should be in dependentlibs.list

RESOLVED FIXED in mozilla14

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bsmedberg, Assigned: bsmedberg)

Tracking

unspecified
mozilla14
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
When using the XPCOM glue from a directory which is not the same as xul.dll, as WebRT is going to, gkmedias.dll cannot be found/loaded. This is causing the WebRT patch to currently use some unfortunate workarounds such as using SetDllDirectory, which is fragile. Instead I'd just like to undo the delay-loading of gkmedias.dll and load it eagerly again via dependentlibs.list.
So we can't delay load anything that we ship on Windows?
(Assignee)

Comment 2

5 years ago
Created attachment 610972 [details] [diff] [review]
Remove delay-loading, add to dependentlibs.list, rev. 1
Attachment #610972 - Flags: review?(khuey)
(Assignee)

Comment 3

5 years ago
We cannot delay-load it using the automatic windows mechanism. We could delay-load it using LoadLibrary.
(Assignee)

Updated

5 years ago
Blocks: 725408
Could we (at the expense of complicating the dependent libs loading) add an annotation to dependentlibs.list such that it only loads it if the executable is running from a different directory?
Comment on attachment 610972 [details] [diff] [review]
Remove delay-loading, add to dependentlibs.list, rev. 1

Review of attachment 610972 [details] [diff] [review]:
-----------------------------------------------------------------

:-(
Attachment #610972 - Flags: review?(khuey) → review+
(Assignee)

Comment 6

5 years ago
re: comment 4; yes it's technically possible, but I would prefer not to do that unless we have data saying that this matters: bug 712175 appears to be preemptively doing it and it's not clear why that's necessary.
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/522fb722cc09
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/522fb722cc09
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Blocks: 761185
You need to log in before you can comment on or make changes to this bug.