Last Comment Bug 740919 - gkmedias.dll should be in dependentlibs.list
: gkmedias.dll should be in dependentlibs.list
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: x86_64 Windows 7
: -- normal (vote)
: mozilla14
Assigned To: Benjamin Smedberg AWAY UNTIL 2-AUG-2016 [:bsmedberg]
:
Mentors:
Depends on:
Blocks: 725408 761185
  Show dependency treegraph
 
Reported: 2012-03-30 12:20 PDT by Benjamin Smedberg AWAY UNTIL 2-AUG-2016 [:bsmedberg]
Modified: 2012-06-07 23:33 PDT (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove delay-loading, add to dependentlibs.list, rev. 1 (1.42 KB, patch)
2012-03-30 12:24 PDT, Benjamin Smedberg AWAY UNTIL 2-AUG-2016 [:bsmedberg]
khuey: review+
Details | Diff | Splinter Review

Description Benjamin Smedberg AWAY UNTIL 2-AUG-2016 [:bsmedberg] 2012-03-30 12:20:04 PDT
When using the XPCOM glue from a directory which is not the same as xul.dll, as WebRT is going to, gkmedias.dll cannot be found/loaded. This is causing the WebRT patch to currently use some unfortunate workarounds such as using SetDllDirectory, which is fragile. Instead I'd just like to undo the delay-loading of gkmedias.dll and load it eagerly again via dependentlibs.list.
Comment 1 Kyle Huey [:khuey] (khuey@mozilla.com) 2012-03-30 12:21:57 PDT
So we can't delay load anything that we ship on Windows?
Comment 2 Benjamin Smedberg AWAY UNTIL 2-AUG-2016 [:bsmedberg] 2012-03-30 12:24:29 PDT
Created attachment 610972 [details] [diff] [review]
Remove delay-loading, add to dependentlibs.list, rev. 1
Comment 3 Benjamin Smedberg AWAY UNTIL 2-AUG-2016 [:bsmedberg] 2012-03-30 12:25:47 PDT
We cannot delay-load it using the automatic windows mechanism. We could delay-load it using LoadLibrary.
Comment 4 Ted Mielczarek [:ted.mielczarek] 2012-03-30 13:17:54 PDT
Could we (at the expense of complicating the dependent libs loading) add an annotation to dependentlibs.list such that it only loads it if the executable is running from a different directory?
Comment 5 Kyle Huey [:khuey] (khuey@mozilla.com) 2012-04-03 08:28:29 PDT
Comment on attachment 610972 [details] [diff] [review]
Remove delay-loading, add to dependentlibs.list, rev. 1

Review of attachment 610972 [details] [diff] [review]:
-----------------------------------------------------------------

:-(
Comment 6 Benjamin Smedberg AWAY UNTIL 2-AUG-2016 [:bsmedberg] 2012-04-03 12:30:28 PDT
re: comment 4; yes it's technically possible, but I would prefer not to do that unless we have data saying that this matters: bug 712175 appears to be preemptively doing it and it's not clear why that's necessary.
Comment 7 Benjamin Smedberg AWAY UNTIL 2-AUG-2016 [:bsmedberg] 2012-04-05 14:25:56 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/522fb722cc09
Comment 8 Matt Brubeck (:mbrubeck) 2012-04-06 11:34:34 PDT
https://hg.mozilla.org/mozilla-central/rev/522fb722cc09

Note You need to log in before you can comment on or make changes to this bug.