IRC and XMPP connections fail when there's a system HTTP proxy

RESOLVED FIXED in Thunderbird 17.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: BenB, Assigned: florian)

Tracking

unspecified
Thunderbird 17.0
x86_64
Linux

Thunderbird Tracking Flags

(thunderbird15 fixed, thunderbird16 fixed)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Reproduction:
1. In GNOME settings | Proxy, enter a HTTP proxy.
2. Create a new TB profile, and start TB from the commandline
3. Create an IRC account, and connect

Actual result:
"Your chat accounts are not connected".
"Show chat status" shows "Lost connection to server".

Error console shows:
irc: Unhandled IRC message: HTTP/1.0 400 Bad Request
irc: Unhandled IRC message: Server: squid/...
irc: Unhandled IRC message: Date: Mon, 02 Apr 2012 20:15:07 GMT
irc: Unhandled IRC message: Content-Type: text/html
irc: Unhandled IRC message: Content-Length: 1221
irc: Unhandled IRC message: Expires: Mon, 02 Apr 2012 20:15:07 GMT
irc: Unhandled IRC message: X-Squid-Error: ERR_INVALID_REQ 0
irc: Unhandled IRC message: X-Cache: MISS from squid.host
irc: Unhandled IRC message: X-Cache-Lookup: NONE from squid.host:1234
irc: Unhandled IRC message: Connection: close

Expected result:
No HTTP proxy used for IRC.

Comment 1

5 years ago
possibly bug 741056 but that's a crasher on windows.
We have a similar Instantbird bug on file: https://bugzilla.instantbird.org/show_bug.cgi?id=1347
Duplicate of this bug: 778087
Summary: IRC fails when there's a system HTTP proxy → IRC and XMPP connections fail when there's a system HTTP proxy
Created attachment 647488 [details] [diff] [review]
Patch

I'm proposing with this patch that we just ignore HTTP proxies for now.

I know it should be possible to use some HTTP proxies to tunnel a non-HTTP connection, but I don't know exactly what we need to do for that, and I've no HTTP proxy supporting that to test with, so for now just ignoring the HTTP proxies seems the best thing to do.
Assignee: nobody → florian
Attachment #647488 - Flags: review?(clokep)
Comment on attachment 647488 [details] [diff] [review]
Patch

This looks fine. Thanks.
Attachment #647488 - Flags: review?(clokep) → review+
Comment on attachment 647488 [details] [diff] [review]
Patch

[Approval Request Comment]
I've seen several reports of people who couldn't connect there chat accounts in Thunderbird because of this, so I think we should take this for Thunderbird 15.
Attachment #647488 - Flags: approval-comm-beta?
Attachment #647488 - Flags: approval-comm-aurora?
(Reporter)

Comment 7

5 years ago
> I'm proposing with this patch that we just ignore HTTP proxies for now.

+1

This also allows to use the trick mentioned in bug 741550.
Attachment #647488 - Flags: approval-comm-beta?
Attachment #647488 - Flags: approval-comm-beta+
Attachment #647488 - Flags: approval-comm-aurora?
Attachment #647488 - Flags: approval-comm-aurora+
https://hg.mozilla.org/comm-central/rev/b9acacd77af4
https://hg.mozilla.org/releases/comm-aurora/rev/ebababc57916
https://hg.mozilla.org/releases/comm-beta/rev/37202ee972f6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-thunderbird15: --- → fixed
status-thunderbird16: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.