742793 - Support vCard based avatars on JS-XMPP

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Adam Nemeth]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/534.50 (KHTML, like Gecko) Version/5.1 Safari/534.50

Steps to reproduce:

My friend didn't have his avatar listed (although he had one in Adium [not through my AB] but not one in Gmail). I told this to him, he changed avatar. 


Actual results:

The avatar didn't change; after logging in and out it did


Expected results:

Changes should've been reflected at runtime

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch

Same patch, minus a typo.

Comment 3

[Florian Quèze [:florian]]

I'm morphing this bug to be a little bit more general, about supporting vCard based avatars on XMPP.

I just checked in:
https://hg.mozilla.org/comm-central/rev/eee6c5a63844 - fetch new vCards when the server notifies us of an update. The patch reviewed here, that fixes the bug reported here.
https://hg.mozilla.org/comm-central/rev/17da70a358e2 - send the user's vCard (including the avatar and the display name). This patch was reviewed in https://bugzilla.instantbird.org/show_bug.cgi?id=1381

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 633568 [details] [diff] [review]
Patch

[Approval Request Comment]
I'm putting the approval flag on this attachment, but I'm actually requesting approval aurora for both changesets that landed on comm-central (comment 3).

Comment 5

[Florian Quèze [:florian]]

I won't land this on aurora immediately as I've heard a user complaining yesterday on IRC ("Hey, your Jabber client is destroying my vcard every time I sign on!") that looks like it's caused by the changes in 17da70a358e2. I filed https://bugzilla.instantbird.org/show_bug.cgi?id=1556 to track this issue.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Landed in comm-aurora as https://hg.mozilla.org/releases/comm-aurora/rev/faffa1007ffb

Comment 7

[Florian Quèze [:florian]]

> https://hg.mozilla.org/comm-central/rev/eee6c5a63844 - fetch new vCards when
> the server notifies us of an update. The patch reviewed here, that fixes the
> bug reported here.

Only this part landed on aurora (comment 6).

> https://hg.mozilla.org/comm-central/rev/17da70a358e2 - send the user's vCard
> (including the avatar and the display name). This patch was reviewed in
> https://bugzilla.instantbird.org/show_bug.cgi?id=1381

This seems to be causing a regression (comment 5) that still needs to be investigated.

Comment 8

[Florian Quèze [:florian]]

(In reply to Florian Quèze from comment #7)

> > https://hg.mozilla.org/comm-central/rev/17da70a358e2 - send the user's vCard
> > (including the avatar and the display name). This patch was reviewed in
> > https://bugzilla.instantbird.org/show_bug.cgi?id=1381
> 
> This seems to be causing a regression (comment 5) that still needs to be
> investigated.

This landed for Thunderbird 15 (now comm-beta) in bug 779117, along with a fix for the regression.