Closed Bug 742793 Opened 9 years ago Closed 8 years ago

Support vCard based avatars on JS-XMPP

Categories

(Thunderbird :: Instant Messaging, defect)

13 Branch
x86
macOS
defect
Not set
normal

Tracking

(thunderbird15 fixed)

RESOLVED FIXED
Thunderbird 16.0
Tracking Status
thunderbird15 --- fixed

People

(Reporter: bugzilla, Assigned: florian)

References

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/534.50 (KHTML, like Gecko) Version/5.1 Safari/534.50

Steps to reproduce:

My friend didn't have his avatar listed (although he had one in Adium [not through my AB] but not one in Gmail). I told this to him, he changed avatar. 


Actual results:

The avatar didn't change; after logging in and out it did


Expected results:

Changes should've been reflected at runtime
Depends on: 740280
Blocks: 740280
No longer depends on: 740280
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #633566 - Flags: review?(clokep)
Attached patch PatchSplinter Review
Same patch, minus a typo.
Attachment #633566 - Attachment is obsolete: true
Attachment #633566 - Flags: review?(clokep)
Attachment #633568 - Flags: review?(clokep)
Attachment #633568 - Flags: review?(clokep) → review+
I'm morphing this bug to be a little bit more general, about supporting vCard based avatars on XMPP.

I just checked in:
https://hg.mozilla.org/comm-central/rev/eee6c5a63844 - fetch new vCards when the server notifies us of an update. The patch reviewed here, that fixes the bug reported here.
https://hg.mozilla.org/comm-central/rev/17da70a358e2 - send the user's vCard (including the avatar and the display name). This patch was reviewed in https://bugzilla.instantbird.org/show_bug.cgi?id=1381
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Summary: Avatar changes are only visible at restart → Support vCard based avatars on JS-XMPP
Target Milestone: --- → Thunderbird 16.0
Comment on attachment 633568 [details] [diff] [review]
Patch

[Approval Request Comment]
I'm putting the approval flag on this attachment, but I'm actually requesting approval aurora for both changesets that landed on comm-central (comment 3).
Attachment #633568 - Flags: approval-comm-aurora?
Attachment #633568 - Flags: approval-comm-aurora? → approval-comm-aurora+
I won't land this on aurora immediately as I've heard a user complaining yesterday on IRC ("Hey, your Jabber client is destroying my vcard every time I sign on!") that looks like it's caused by the changes in 17da70a358e2. I filed https://bugzilla.instantbird.org/show_bug.cgi?id=1556 to track this issue.
> https://hg.mozilla.org/comm-central/rev/eee6c5a63844 - fetch new vCards when
> the server notifies us of an update. The patch reviewed here, that fixes the
> bug reported here.

Only this part landed on aurora (comment 6).

> https://hg.mozilla.org/comm-central/rev/17da70a358e2 - send the user's vCard
> (including the avatar and the display name). This patch was reviewed in
> https://bugzilla.instantbird.org/show_bug.cgi?id=1381

This seems to be causing a regression (comment 5) that still needs to be investigated.
(In reply to Florian Quèze from comment #7)

> > https://hg.mozilla.org/comm-central/rev/17da70a358e2 - send the user's vCard
> > (including the avatar and the display name). This patch was reviewed in
> > https://bugzilla.instantbird.org/show_bug.cgi?id=1381
> 
> This seems to be causing a regression (comment 5) that still needs to be
> investigated.

This landed for Thunderbird 15 (now comm-beta) in bug 779117, along with a fix for the regression.
You need to log in before you can comment on or make changes to this bug.