Last Comment Bug 742795 - autoconf.mk should be completely autogenerated
: autoconf.mk should be completely autogenerated
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Mike Hommey [:glandium]
:
: Gregory Szorc [:gps]
Mentors:
Depends on: 763987 764286 774032
Blocks: 774049 778740
  Show dependency treegraph
 
Reported: 2012-04-05 10:41 PDT by Ted Mielczarek [:ted.mielczarek]
Modified: 2012-08-08 06:38 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
(PoC) Autogenerate autoconf.mk (37.85 KB, patch)
2012-06-12 23:42 PDT, Mike Hommey [:glandium]
no flags Details | Diff | Splinter Review
Autogenerate autoconf.mk (33.95 KB, patch)
2012-07-28 00:13 PDT, Mike Hommey [:glandium]
ted: review+
Details | Diff | Splinter Review

Description Ted Mielczarek [:ted.mielczarek] 2012-04-05 10:41:58 PDT
Currently to add an entry to autoconf.mk you have to both add an entry in autoconf.mk.in and add an AC_SUBST line to configure.in. We should fix this to work more like AC_DEFINE/mozilla-config.h, where the file is generated entirely from the AC_SUBST lines in configure.in.

We'll have to move the few ifdefs/other non-declarative bits in there to config.mk, but that's probably a net win.

Fixing this will probably require some autoconf grovelling.
Comment 1 Mike Hommey [:glandium] 2012-06-12 23:42:50 PDT
Created attachment 632576 [details] [diff] [review]
(PoC) Autogenerate autoconf.mk

This seems to work locally, but there are a few issues:
- config.status doesn't generate a new autoconf.mk
- there may be AC_SUBSTed variable that shouldn't be defined in autoconf.mk (see, for example, STL_FLAGS in js/src/configure.in ; it was not in autoconf.mk.in but was AC_SUBSTed, so it ended up in the autogenerated autoconf.mk, and that was breaking my build)
Comment 2 Mike Hommey [:glandium] 2012-07-28 00:13:29 PDT
Created attachment 646824 [details] [diff] [review]
Autogenerate autoconf.mk
Comment 3 Ted Mielczarek [:ted.mielczarek] 2012-08-06 06:00:47 PDT
Comment on attachment 646824 [details] [diff] [review]
Autogenerate autoconf.mk

Review of attachment 646824 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome!
Comment 5 Ed Morley [:emorley] 2012-08-06 08:06:02 PDT
Backed out at glandium's request:
https://hg.mozilla.org/integration/mozilla-inbound/rev/867c9f564966
Comment 6 Mike Hommey [:glandium] 2012-08-06 22:35:47 PDT
Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f940a77ee247
Comment 7 Ed Morley [:emorley] 2012-08-07 07:33:52 PDT
https://hg.mozilla.org/mozilla-central/rev/f940a77ee247
Comment 8 Robert Kaiser 2012-08-08 06:19:51 PDT
Is there a bug open already to do this in comm-central as well?
Comment 9 Mike Hommey [:glandium] 2012-08-08 06:38:23 PDT
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #8)
> Is there a bug open already to do this in comm-central as well?

It's mentioned in bug 780357

Note You need to log in before you can comment on or make changes to this bug.