Closed
Bug 742795
Opened 12 years ago
Closed 12 years ago
autoconf.mk should be completely autogenerated
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: ted, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
|
33.95 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Currently to add an entry to autoconf.mk you have to both add an entry in autoconf.mk.in and add an AC_SUBST line to configure.in. We should fix this to work more like AC_DEFINE/mozilla-config.h, where the file is generated entirely from the AC_SUBST lines in configure.in. We'll have to move the few ifdefs/other non-declarative bits in there to config.mk, but that's probably a net win. Fixing this will probably require some autoconf grovelling.
|
Assignee | |
Comment 1•12 years ago
|
||
This seems to work locally, but there are a few issues: - config.status doesn't generate a new autoconf.mk - there may be AC_SUBSTed variable that shouldn't be defined in autoconf.mk (see, for example, STL_FLAGS in js/src/configure.in ; it was not in autoconf.mk.in but was AC_SUBSTed, so it ended up in the autogenerated autoconf.mk, and that was breaking my build)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #646824 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #632576 -
Attachment is obsolete: true
|
Reporter | |
Comment 3•12 years ago
|
||
Comment on attachment 646824 [details] [diff] [review] Autogenerate autoconf.mk Review of attachment 646824 [details] [diff] [review]: ----------------------------------------------------------------- Awesome!
Attachment #646824 -
Flags: review?(ted.mielczarek) → review+
|
|
Reporter | |
Updated•12 years ago
|
Assignee: nobody → mh+mozilla
|
|
Assignee | |
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f8928077ed4
Target Milestone: --- → mozilla17
|
||
Comment 5•12 years ago
|
||
Backed out at glandium's request: https://hg.mozilla.org/integration/mozilla-inbound/rev/867c9f564966
|
|
Assignee | |
Comment 6•12 years ago
|
||
Relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/f940a77ee247
|
|
||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f940a77ee247
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 8•12 years ago
|
||
Is there a bug open already to do this in comm-central as well?
|
|
Assignee | |
Comment 9•12 years ago
|
||
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #8) > Is there a bug open already to do this in comm-central as well? It's mentioned in bug 780357
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•