Note: There are a few cases of duplicates in user autocompletion which are being worked on.

autoconf.mk should be completely autogenerated

RESOLVED FIXED in mozilla17

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ted, Assigned: glandium)

Tracking

(Blocks: 1 bug)

Trunk
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Currently to add an entry to autoconf.mk you have to both add an entry in autoconf.mk.in and add an AC_SUBST line to configure.in. We should fix this to work more like AC_DEFINE/mozilla-config.h, where the file is generated entirely from the AC_SUBST lines in configure.in.

We'll have to move the few ifdefs/other non-declarative bits in there to config.mk, but that's probably a net win.

Fixing this will probably require some autoconf grovelling.
(Assignee)

Updated

5 years ago
Depends on: 763987
(Assignee)

Comment 1

5 years ago
Created attachment 632576 [details] [diff] [review]
(PoC) Autogenerate autoconf.mk

This seems to work locally, but there are a few issues:
- config.status doesn't generate a new autoconf.mk
- there may be AC_SUBSTed variable that shouldn't be defined in autoconf.mk (see, for example, STL_FLAGS in js/src/configure.in ; it was not in autoconf.mk.in but was AC_SUBSTed, so it ended up in the autogenerated autoconf.mk, and that was breaking my build)
(Assignee)

Updated

5 years ago
Depends on: 764286

Updated

5 years ago
Blocks: 774049
(Assignee)

Updated

5 years ago
Depends on: 776968
(Assignee)

Updated

5 years ago
Depends on: 774032
(Assignee)

Updated

5 years ago
No longer depends on: 776968
(Assignee)

Comment 2

5 years ago
Created attachment 646824 [details] [diff] [review]
Autogenerate autoconf.mk
Attachment #646824 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

5 years ago
Attachment #632576 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Blocks: 778740
(Reporter)

Comment 3

5 years ago
Comment on attachment 646824 [details] [diff] [review]
Autogenerate autoconf.mk

Review of attachment 646824 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome!
Attachment #646824 - Flags: review?(ted.mielczarek) → review+
(Reporter)

Updated

5 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f8928077ed4
Target Milestone: --- → mozilla17

Comment 5

5 years ago
Backed out at glandium's request:
https://hg.mozilla.org/integration/mozilla-inbound/rev/867c9f564966
(Assignee)

Comment 6

5 years ago
Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f940a77ee247

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f940a77ee247
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 8

5 years ago
Is there a bug open already to do this in comm-central as well?
(Assignee)

Comment 9

5 years ago
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #8)
> Is there a bug open already to do this in comm-central as well?

It's mentioned in bug 780357
You need to log in before you can comment on or make changes to this bug.