RESOLVED FIXED in Thunderbird 17.0

Status

MailNews Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Fallen, Assigned: glandium)

Tracking

unspecified
Thunderbird 17.0
x86
All
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
I just saw a pretty large push go to inbound that changes a lot of things in synchronized files like configure.in. Someone should go through this stuff to see what is needed for comm-central.

bug 776968 - Avoid modifying autoconf.mk after running nspr configure
bug 774032 (8 parts!)
  - Avoid Preprocessor.py replacing undefined variables with the 
    attemptSubstitution filter
  - Allow to disable markers in Preprocessor.py
  - Remove variables with no AC_SUBST in autoconf.mk.in
  - Add check-sync-dirs exception for *.pyc under build/
  - Use explicit _NON_GLOBAL_ACDEFINES, and rely less on pattern matching
  - Replace autoconf handling of config files and headers with our own
  - Remove make-makefile and acoutput-fast.pl
  - bonus: Use @DEPTH@ and @relativesrcdir@ in Makefile.in
bug 780159 - Remove obsolete REGCHROME
bug 776561 - Avoid OS_LIBS containing -lrt when there is no config.cache
bug 778740 - Allow to use Linux kernel headers for perf events
(Reporter)

Comment 1

5 years ago
glandium says we should only need bug 774032 and bug 780159. About bug 776968 he says it should change nothing since there was a workaround to avoid reconfigures.
(Assignee)

Comment 2

5 years ago
bug 778740 is irrelevant for c-c because it doesn't use linux perf event stuff.
bug 776561 is irrelevant for c-c because it doesn't have the check for clock_gettime that added -lrt on m-c
bug 776968 may actually be good to port, for the part that *is* in c-c (the autoconf.mk rewriting part is not), because it avoids using shell commands each time NSPR_LIBS is used.
(Assignee)

Comment 3

5 years ago
Created attachment 648965 [details] [diff] [review]
Partial port of bug 774032

This should port the following parts of bug 774032:
  - Remove variables with no AC_SUBST in autoconf.mk.in
  - Use explicit _NON_GLOBAL_ACDEFINES, and rely less on pattern matching
  - Replace autoconf handling of config files and headers with our own
but it doesn't contain the following files that need to be copied from m-c:
  - build/ConfigStatus.py
  - config/Expression.py
  - config/Preprocessor.py

The following patches are irrelevant if you just copy the last versions of the above files:
  - Avoid Preprocessor.py replacing undefined variables with the 
    attemptSubstitution filter
  - Allow to disable markers in Preprocessor.py

This is not required, because it's already in c-c, somehow:
  - Add check-sync-dirs exception for *.pyc under build/

This is not required, because the files are not in c-c:
  - Remove make-makefile and acoutput-fast.pl

This is not strictly required but is a nice bonus (but not in this patch):
  - bonus: Use @DEPTH@ and @relativesrcdir@ in Makefile.in
(Assignee)

Comment 4

5 years ago
Also, the part for WIN_TOP_SRC is not ported. It may require porting things from c-c to m-c (cygwin parts)
(Assignee)

Comment 5

5 years ago
Created attachment 649091 [details] [diff] [review]
Partial port of bug 774032

Refreshed with bug 780446 and bug 780421
(Assignee)

Updated

5 years ago
Attachment #648965 - Attachment is obsolete: true
(Assignee)

Comment 6

5 years ago
Note that you'll also want bug 763987 (the goal being to prepare autoconf.mk for bug 742795, and for that, it needs all variables to be in the form VAR = @VAR@, not VAR = FOO @VAR@ or VAR = @VAR2@)
(Assignee)

Comment 7

5 years ago
(In reply to Mike Hommey [:glandium] from comment #6)
> Note that you'll also want bug 763987 (the goal being to prepare autoconf.mk
> for bug 742795, and for that, it needs all variables to be in the form VAR =
> @VAR@, not VAR = FOO @VAR@ or VAR = @VAR2@)

That's however not needed to unbreak the build on c-c.

(In reply to Mike Hommey [:glandium] from comment #4)
> Also, the part for WIN_TOP_SRC is not ported. It may require porting things
> from c-c to m-c (cygwin parts)

cygwin support was removed from m-c in bug 462361. I guess we can just remove the cygwin part in configure.in in c-c.
(Assignee)

Comment 8

5 years ago
Created attachment 649100 [details] [diff] [review]
Allow m-c's ConfigStatus.py to be used from c-c

This allows c-c to configure properly with the PoC I already attached, and without copying files from m-c.
Attachment #649100 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 9

5 years ago
Comment on attachment 649091 [details] [diff] [review]
Partial port of bug 774032

I think this is enough, with the m-c patch i attached, to unbreak c-c.
Attachment #649091 - Flags: review?(bugspam.Callek)
(Assignee)

Updated

5 years ago
Assignee: nobody → mh+mozilla
Attachment #649100 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 10

5 years ago
Landed the m-c part:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91de8ff323d4
Whiteboard: [leave open]
(Assignee)

Comment 11

5 years ago
And the missing sync with js/src:
https://hg.mozilla.org/integration/mozilla-inbound/rev/949770676b0f
(Assignee)

Updated

5 years ago
Duplicate of this bug: 780485

Updated

5 years ago
Depends on: 776968, 774032, 780159, 776561, 778740

Comment 13

5 years ago
As this is about the general comm-central build system and not Thunderbird-specific, it belongs in MailNews Core
Component: Build Config → Build Config
Product: Thunderbird → MailNews Core
https://hg.mozilla.org/mozilla-central/rev/91de8ff323d4
https://hg.mozilla.org/mozilla-central/rev/949770676b0f
I've experienced this bug on both Linux and Windows(7) so changing platform from OSX to All.
OS: Mac OS X → All
(Assignee)

Comment 16

5 years ago
Landed on c-c to unbreak it.
http://hg.mozilla.org/comm-central/rev/493c0d246a5e

Maybe the remaining parts should be tracked in a separate bug, and we should close this one?

Updated

5 years ago
Status: NEW → ASSIGNED
Thanks for your work on this Mike.

I agree with Mike, we should do follow-ups in a separate bug. Can someone formulate a list please?
Attachment #649091 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 18

5 years ago
(In reply to Mark Banner (:standard8) from comment #17)
> Thanks for your work on this Mike.
> 
> I agree with Mike, we should do follow-ups in a separate bug. Can someone
> formulate a list please?

Filed bug 781446.
Target Milestone: --- → Thunderbird 17.0

Updated

5 years ago
Whiteboard: [leave open]
You need to log in before you can comment on or make changes to this bug.