Closed
Bug 776968
Opened 12 years ago
Closed 12 years ago
Avoid modifying autoconf.mk after running nspr configure
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.28 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Currently, we initialize the value for NSPR_LIBS and NSPR_CFLAGS to a quoted command running nspr-config (except on windows). Then, after nspr configure has run, we replace the value with the actual out of nspr-config. It's actually pretty pointless.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #645359 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 645359 [details] [diff] [review] Avoid modifying autoconf.mk after running nspr configure This apparently breaks osx.
Attachment #645359 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → mh+mozilla
|
|
Assignee | |
Comment 3•12 years ago
|
||
This works better.
Attachment #645663 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #645359 -
Attachment is obsolete: true
|
||
Updated•12 years ago
|
Attachment #645663 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c65fa0ee6e28
Target Milestone: --- → mozilla17
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c65fa0ee6e28
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•