Avoid modifying autoconf.mk after running nspr configure

RESOLVED FIXED in mozilla17

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Currently, we initialize the value for NSPR_LIBS and NSPR_CFLAGS to a quoted command running nspr-config (except on windows). Then, after nspr configure has run, we replace the value with the actual out of nspr-config. It's actually pretty pointless.
Created attachment 645359 [details] [diff] [review]
Avoid modifying autoconf.mk after running nspr configure
Attachment #645359 - Flags: review?(ted.mielczarek)
Comment on attachment 645359 [details] [diff] [review]
Avoid modifying autoconf.mk after running nspr configure

This apparently breaks osx.
Attachment #645359 - Flags: review?(ted.mielczarek)
Assignee: nobody → mh+mozilla
Created attachment 645663 [details] [diff] [review]
Avoid modifying autoconf.mk after running nspr configure

This works better.
Attachment #645663 - Flags: review?(ted.mielczarek)
Attachment #645359 - Attachment is obsolete: true
No longer blocks: 742795
Attachment #645663 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c65fa0ee6e28
Target Milestone: --- → mozilla17

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/c65fa0ee6e28
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Blocks: 780357
You need to log in before you can comment on or make changes to this bug.