Last Comment Bug 776968 - Avoid modifying autoconf.mk after running nspr configure
: Avoid modifying autoconf.mk after running nspr configure
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: Mike Hommey [:glandium]
:
: Gregory Szorc [:gps]
Mentors:
Depends on:
Blocks: 774032 780357
  Show dependency treegraph
 
Reported: 2012-07-24 10:06 PDT by Mike Hommey [:glandium]
Modified: 2012-08-05 10:42 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Avoid modifying autoconf.mk after running nspr configure (4.15 KB, patch)
2012-07-24 10:15 PDT, Mike Hommey [:glandium]
no flags Details | Diff | Splinter Review
Avoid modifying autoconf.mk after running nspr configure (3.28 KB, patch)
2012-07-24 23:33 PDT, Mike Hommey [:glandium]
ted: review+
Details | Diff | Splinter Review

Description Mike Hommey [:glandium] 2012-07-24 10:06:29 PDT
Currently, we initialize the value for NSPR_LIBS and NSPR_CFLAGS to a quoted command running nspr-config (except on windows). Then, after nspr configure has run, we replace the value with the actual out of nspr-config. It's actually pretty pointless.
Comment 1 Mike Hommey [:glandium] 2012-07-24 10:15:21 PDT
Created attachment 645359 [details] [diff] [review]
Avoid modifying autoconf.mk after running nspr configure
Comment 2 Mike Hommey [:glandium] 2012-07-24 13:48:46 PDT
Comment on attachment 645359 [details] [diff] [review]
Avoid modifying autoconf.mk after running nspr configure

This apparently breaks osx.
Comment 3 Mike Hommey [:glandium] 2012-07-24 23:33:43 PDT
Created attachment 645663 [details] [diff] [review]
Avoid modifying autoconf.mk after running nspr configure

This works better.
Comment 5 Ed Morley [:emorley] 2012-08-04 11:17:21 PDT
https://hg.mozilla.org/mozilla-central/rev/c65fa0ee6e28

Note You need to log in before you can comment on or make changes to this bug.