744607 - scroll causes lines in webpage

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[xxbones21xx]

Attachment: lines in nightly.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120411 Firefox/14.0a1
Build ID: 20120411030716

Steps to reproduce:

I used the middle button to scroll through a webpage after Nightly's 4-11-12 update.


Actual results:

Its scrolled correctly but caused there to be lines appearing wear the page was scrolled.


Expected results:

Not this. Should have just scrolled and left the contents of the page untouched.

Comment 1

[xxbones21xx]

When i removed multirow bookmarks toolbar plus, then lines didnt appear anymore.

Comment 2

[Cork]

Caused by http://hg.mozilla.org/integration/mozilla-inbound/rev/25a13d26509d

Link to the mentioned extension https://addons.mozilla.org/en-US/firefox/addon/multirow-bookmarks-toolbarplus

Roc, is this a regression or just an incompatible extension?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Probably not the extension.

Comment 4

[Timothy Nikkel (:tnikkel)]

Do we snap the clip rect everywhere properly in FrameLayerBuilder?

Comment 5

[Christian Ascheberg]

I also notice this in current nightly build when scrolling iframes.
Possible duplicate: bug #744666

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

We need to make sure that stuff outside the snapped clip rect isn't included in the layer's visible region. This patch does that.

The change to nsDisplayClip::GetBounds doesn't really matter --- nothing uses this snap output --- but it's more correct; mClip's edges can be snapped, but the edges of the bounds of the wrapped list cannot be snapped.

Comment 7

[Timothy Nikkel (:tnikkel)]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #6)
> The change to nsDisplayClip::GetBounds doesn't really matter --- nothing
> uses this snap output --- but it's more correct; mClip's edges can be
> snapped, but the edges of the bounds of the wrapped list cannot be snapped.

So technically it should just leave aSnap alone and let nsDisplayWrapList::GetBounds set it?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e339ca6c2f11(In reply to Timothy Nikkel (:tn) from comment #7)
> (In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #6)
> > The change to nsDisplayClip::GetBounds doesn't really matter --- nothing
> > uses this snap output --- but it's more correct; mClip's edges can be
> > snapped, but the edges of the bounds of the wrapped list cannot be snapped.
> 
> So technically it should just leave aSnap alone and let
> nsDisplayWrapList::GetBounds set it?

I suppose, but it doesn't matter.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e339ca6c2f11

Comment 12

[Kelsey Gilbert [:jgilbert]]

fwiw, this seems to be happening on my galexy tab, as well.

Comment 13

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/e339ca6c2f11