Closed
Bug 746645
Opened 13 years ago
Closed 12 years ago
Adding the white-list for myapps (or stage-myapps) has no effect with a clean FF profile
Categories
(Firefox Graveyard :: Web Apps, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 14
People
(Reporter: JStagner, Assigned: ianbicking)
Details
(Keywords: regression)
Attachments
(1 file)
1.04 KB,
patch
|
fabrice
:
review+
mfinkle
:
approval-mozilla-central+
|
Details | Diff | Splinter Review |
Navigating to https://myapps.mozillalabs.com displays a screen to add a preference dom.mozApps.whitelist
On machines where I added the white list in a prior nightly and have updated to today's nightly - this works. On NEW installs (or complete re-installs) of nightly adding the whitelist seems to have n effect.
Tested on Windows 7 and Mac OSX
Comment 1•13 years ago
|
||
May be related to bug 746629. Sounds like a FF specific issue though. Moving to FF --> Web Apps.
Severity: normal → critical
Component: Dashboard → Web Apps
Keywords: regression
Product: Web Apps → Firefox
QA Contact: dashboard → webapps
Updated•13 years ago
|
Version: unspecified → 14 Branch
Updated•13 years ago
|
OS: Windows 7 → All
Hardware: x86 → All
Comment 2•13 years ago
|
||
Not seeing this behavior with a dirty profile on Win 7 64-bit. Flagging qawanted to investigate.
Keywords: qawanted
Comment 3•12 years ago
|
||
I see this behaviour on today's Nightly with OSX.
Comment 4•12 years ago
|
||
Confirmed. The whitelisting no longer works. Seen this behavior on OS X 10.6.
Keywords: qawanted
Updated•12 years ago
|
Whiteboard: [marketplace-beta?]
Comment 5•12 years ago
|
||
Regression window: Was working on yesterday's nightly, not working on today's nightly. This likely involves the patches that were submitted yesterday on 4/17.
Comment 6•12 years ago
|
||
I think this happens only with a clean FF profile. Does not occur with a dirty profile.
Summary: Adding the white-list for myapps (or stage-myapps) has no effect. → Adding the white-list for myapps (or stage-myapps) has no effect with a clean FF profile
Comment 7•12 years ago
|
||
For comment 6 - Only if the dirty profile already had the whitelisting parameter set.
Assignee | ||
Comment 8•12 years ago
|
||
Looking at the whitelisting code, it's pretty fragile. The value must be of exactly the format: https://myapps.mozillalabs.com,https://somethingelse.com,... – each item must be a valid URL, separated with commas if you include multiple domains. If an item is invalid that item and the rest after it are ignored and no error is reported. Is there a chance you set the property differently?
Reporter | ||
Comment 9•12 years ago
|
||
In my case I used exactly that url, all lower case - tried 3 machines all with the same failure.
Assignee | ||
Comment 10•12 years ago
|
||
This code, dom/base/Webapps.jsm line 52, is what is stopping the whitelist from being loaded:
this.appsFile = FileUtils.getFile(DIRECTORY_NAME, ["webapps", "webapps.json"], true);
if (!this.appsFile.exists())
return;
So probably if you install an app, then restart your browser, the whitelist will start working. I've attached a patch.
Attachment #616694 -
Flags: review?(fabrice)
Updated•12 years ago
|
Attachment #616694 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 11•12 years ago
|
||
Comment on attachment 616694 [details] [diff] [review]
Fix regression
This patch fixes a logic bug, that keeps the mozApps.mgmt whitelist from being loaded in profiles that otherwise have never used mozApps.install()
Risks? None that I see; the remainder of the code block is already protected by a try/catch
Attachment #616694 -
Flags: approval-mozilla-central?
Updated•12 years ago
|
Whiteboard: [marketplace-beta?]
Comment 12•12 years ago
|
||
Comment on attachment 616694 [details] [diff] [review]
Fix regression
[triage comment]
not related to Fennec at all, fine for a a=desktop-only
Attachment #616694 -
Flags: approval-mozilla-central?
Comment 13•12 years ago
|
||
lsblakk: I'm ready to check this in, but are you sure this is a=desktop-only? dom/base/Webapps.jsm is loaded by Fennec; and the tree rules say only browser/ qualifies for that kind of approval (although akeybl recently extended it to webapprt/, which is only built with browser/).
Assignee: nobody → ianb
Comment 14•12 years ago
|
||
Comment on attachment 616694 [details] [diff] [review]
Fix regression
Possible risk to Fennec Native 14 (if any):
This fixes a bug, also present in Fennec, which seems low-risk for two reasons:
1. There is no obvious benefit to relying on the current buggy behavior, so it seems unlikely for there to be any code in Fennec that depends on it.
2. The behavior is only triggered when websites access the mozApps API for interacting with Fennec's webapps feature, and webapps are not (yet!) a key feature of Fennec nor exposed much to its users.
Attachment #616694 -
Flags: approval-mozilla-central?
Comment 15•12 years ago
|
||
(Note: re-requested approval after conversation with Lukas on IRC and agreement that this isn't desktop-only and thus not subject to a=desktop-only.)
Updated•12 years ago
|
Attachment #616694 -
Flags: approval-mozilla-central? → approval-mozilla-central+
Comment 16•12 years ago
|
||
Target Milestone: --- → Firefox 14
Comment 17•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
Flags: in-moztrap-
Updated•12 years ago
|
QA Contact: jsmith
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•