746771 - Mac installer needs to use updated webapp.json structure with registryDir instead of app.profile

Status: VERIFIED FIXED

Description

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/762911344837#l3.205
The code from bug 739636 creates a json object of format:
{
  app: {
    profile: ..,
    origin: ..,
    installOrigin: ..,
    manifest: ..
  }
}

The runtime from bug 725408 is expecting a top level registryDir property on this config file.

http://mxr.mozilla.org/mozilla-central/source/webapprt/WebappRTDirectoryProvider.js#24

Comment 1

[Jason Smith [:jsmith]]

Dan - Any ideas?

Comment 2

[:Felipe Gomes (needinfo me!)]

Created attachment 616320 [details] [diff] [review]
Patch

I'll wait for Mardak to confirm this is the correct fix before requesting review

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 616320 [details] [diff] [review]
Patch

This is the right fix, per the install flow <https://etherpad.mozilla.org/webapprt-install-flow>.  However, also remove the `profile` property from the `app` structure, as it is redundant and unnecessary.

Comment 4

[Ed Lee :Mardak]

Created attachment 617125 [details] [diff] [review]
for checkin

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ffb9beb36e5a

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ffb9beb36e5a

Comment 7

[Jason Smith [:jsmith]]

To verify this bug, I need to install an application and check that the webapp.json file contains registryDir, right?

For some reason when I do "Show Package Contents" on Mac, I can't find the webapp.json file. Is this expected?

Comment 8

[Ed Lee :Mardak]

webapp.json actually appears in the user's profile and not part of the application:

~/Library/Application Support/marketplace-dev.allizom.org;https;-1/webapp.json

Comment 9

[Jason Smith [:jsmith]]

Verified on OS X 10.7.