Mac installer needs to use updated webapp.json structure with registryDir instead of app.profile
VERIFIED
FIXED
in Firefox 14
Status
People
(Reporter: Mardak, Assigned: Felipe)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
(Whiteboard: [qa!])
Attachments
(1 attachment, 1 obsolete attachment)
1.12 KB,
patch
|
Details | Diff | Splinter Review |
https://hg.mozilla.org/mozilla-central/rev/762911344837#l3.205 The code from bug 739636 creates a json object of format: { app: { profile: .., origin: .., installOrigin: .., manifest: .. } } The runtime from bug 725408 is expecting a top level registryDir property on this config file. http://mxr.mozilla.org/mozilla-central/source/webapprt/WebappRTDirectoryProvider.js#24
Updated•7 years ago
|
Component: Desktop Runtime → Web Apps
Product: Web Apps → Firefox
QA Contact: desktop-runtime → webapps
Version: unspecified → 14 Branch
Comment 1•7 years ago
|
||
Dan - Any ideas?
(Assignee) | ||
Updated•7 years ago
|
Assignee: nobody → felipc
(Assignee) | ||
Comment 2•7 years ago
|
||
Created attachment 616320 [details] [diff] [review] Patch I'll wait for Mardak to confirm this is the correct fix before requesting review
(Assignee) | ||
Updated•7 years ago
|
Attachment #616320 -
Flags: review?(myk)
Comment 3•7 years ago
|
||
Comment on attachment 616320 [details] [diff] [review] Patch This is the right fix, per the install flow <https://etherpad.mozilla.org/webapprt-install-flow>. However, also remove the `profile` property from the `app` structure, as it is redundant and unnecessary.
Attachment #616320 -
Flags: review?(myk) → review+
(Reporter) | ||
Comment 4•7 years ago
|
||
Created attachment 617125 [details] [diff] [review] for checkin
Attachment #616320 -
Attachment is obsolete: true
(Reporter) | ||
Updated•7 years ago
|
Summary: Mac installer creates incorrect webapp.json → Mac installer needs to use updated webapp.json structure with registryDir instead of app.profile
(Reporter) | ||
Comment 5•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffb9beb36e5a
Comment 6•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ffb9beb36e5a
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
Updated•7 years ago
|
Whiteboard: [qa+]
Updated•7 years ago
|
Flags: in-moztrap?(jsmith)
Comment 7•7 years ago
|
||
To verify this bug, I need to install an application and check that the webapp.json file contains registryDir, right? For some reason when I do "Show Package Contents" on Mac, I can't find the webapp.json file. Is this expected?
(Reporter) | ||
Comment 8•7 years ago
|
||
webapp.json actually appears in the user's profile and not part of the application: ~/Library/Application Support/marketplace-dev.allizom.org;https;-1/webapp.json
Updated•7 years ago
|
Updated•7 years ago
|
Flags: in-moztrap?(jsmith) → in-moztrap-
Updated•7 years ago
|
QA Contact: jsmith
Updated•3 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•