Mac installer needs to use updated webapp.json structure with registryDir instead of app.profile

VERIFIED FIXED in Firefox 14

Status

Firefox Graveyard
Web Apps
VERIFIED FIXED
5 years ago
2 years ago

People

(Reporter: Mardak, Assigned: Felipe)

Tracking

14 Branch
Firefox 14
x86
Mac OS X
Dependency tree / graph
Bug Flags:
in-moztrap -

Details

(Whiteboard: [qa!])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
https://hg.mozilla.org/mozilla-central/rev/762911344837#l3.205
The code from bug 739636 creates a json object of format:
{
  app: {
    profile: ..,
    origin: ..,
    installOrigin: ..,
    manifest: ..
  }
}

The runtime from bug 725408 is expecting a top level registryDir property on this config file.

http://mxr.mozilla.org/mozilla-central/source/webapprt/WebappRTDirectoryProvider.js#24

Updated

5 years ago
Component: Desktop Runtime → Web Apps
Product: Web Apps → Firefox
QA Contact: desktop-runtime → webapps
Version: unspecified → 14 Branch
Dan - Any ideas?
(Assignee)

Updated

5 years ago
Assignee: nobody → felipc
(Assignee)

Comment 2

5 years ago
Created attachment 616320 [details] [diff] [review]
Patch

I'll wait for Mardak to confirm this is the correct fix before requesting review
(Reporter)

Updated

5 years ago
Blocks: 746213
(Assignee)

Updated

5 years ago
Attachment #616320 - Flags: review?(myk)
Comment on attachment 616320 [details] [diff] [review]
Patch

This is the right fix, per the install flow <https://etherpad.mozilla.org/webapprt-install-flow>.  However, also remove the `profile` property from the `app` structure, as it is redundant and unnecessary.
Attachment #616320 - Flags: review?(myk) → review+

Updated

5 years ago
Blocks: 731054
(Reporter)

Comment 4

5 years ago
Created attachment 617125 [details] [diff] [review]
for checkin
Attachment #616320 - Attachment is obsolete: true
(Reporter)

Updated

5 years ago
Summary: Mac installer creates incorrect webapp.json → Mac installer needs to use updated webapp.json structure with registryDir instead of app.profile
(Reporter)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffb9beb36e5a
https://hg.mozilla.org/mozilla-central/rev/ffb9beb36e5a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14

Updated

5 years ago
Whiteboard: [qa+]

Updated

5 years ago
No longer blocks: 731054

Updated

5 years ago
Flags: in-moztrap?(jsmith)
To verify this bug, I need to install an application and check that the webapp.json file contains registryDir, right?

For some reason when I do "Show Package Contents" on Mac, I can't find the webapp.json file. Is this expected?
(Reporter)

Comment 8

5 years ago
webapp.json actually appears in the user's profile and not part of the application:

~/Library/Application Support/marketplace-dev.allizom.org;https;-1/webapp.json
No longer blocks: 746213
No longer depends on: 725408, 739636

Updated

5 years ago
Blocks: 746213
Depends on: 725408, 739636
Verified on OS X 10.7.
Status: RESOLVED → VERIFIED
Whiteboard: [qa+] → [qa!]

Updated

5 years ago
Flags: in-moztrap?(jsmith) → in-moztrap-

Updated

5 years ago
QA Contact: jsmith
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.