Create pref for webapps installer dry-run

VERIFIED FIXED in Firefox 14

Status

Firefox Graveyard
Web Apps
VERIFIED FIXED
5 years ago
2 years ago

People

(Reporter: Felipe, Assigned: Felipe)

Tracking

Trunk
Firefox 14
Bug Flags:
in-moztrap -

Details

(Whiteboard: [qa!])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 616408 [details] [diff] [review]
Patch

This would be very helpful during tests of other parts of the api (bug 741549) as to not worry about waiting for the actual installation to happen, and possible garbage left in the slave in case a test fails and does not do proper clean-up.
Attachment #616408 - Flags: review?(gavin.sharp)
(Assignee)

Comment 1

5 years ago
Created attachment 616412 [details] [diff] [review]
Patch v2

(missed closed paren in previous patch)
Attachment #616408 - Attachment is obsolete: true
Attachment #616408 - Flags: review?(gavin.sharp)
Attachment #616412 - Flags: review?(gavin.sharp)
Comment on attachment 616412 [details] [diff] [review]
Patch v2

nit: I kind of prefer just a getBoolPref call in a try/catch, since it's a little easier to read. Alternatively, use a local variable for the pref name so you can re-wrap the if statement onto only two lines.
Attachment #616412 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ac6e651207d3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14

Updated

5 years ago
Blocks: 731054
Looks like an internal code change. Is there anything from an end-user perspective I can verify here?
You can set the pref to confirm that the app doesn't get installed.

Updated

5 years ago
No longer blocks: 731054

Updated

5 years ago
Whiteboard: [qa+]
Verified on Win 7 64-bit on Nightly.
Status: RESOLVED → VERIFIED
Whiteboard: [qa+] → [qa!]

Updated

5 years ago
Flags: in-moztrap-

Updated

5 years ago
QA Contact: jsmith
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.