Closed Bug 746848 Opened 9 years ago Closed 9 years ago

Create pref for webapps installer dry-run

Categories

(Firefox Graveyard :: Web Apps, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 14

People

(Reporter: Felipe, Assigned: Felipe)

References

Details

(Whiteboard: [qa!])

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
This would be very helpful during tests of other parts of the api (bug 741549) as to not worry about waiting for the actual installation to happen, and possible garbage left in the slave in case a test fails and does not do proper clean-up.
Attachment #616408 - Flags: review?(gavin.sharp)
Attached patch Patch v2Splinter Review
(missed closed paren in previous patch)
Attachment #616408 - Attachment is obsolete: true
Attachment #616408 - Flags: review?(gavin.sharp)
Attachment #616412 - Flags: review?(gavin.sharp)
Comment on attachment 616412 [details] [diff] [review]
Patch v2

nit: I kind of prefer just a getBoolPref call in a try/catch, since it's a little easier to read. Alternatively, use a local variable for the pref name so you can re-wrap the if statement onto only two lines.
Attachment #616412 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/mozilla-central/rev/ac6e651207d3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
Blocks: 731054
Looks like an internal code change. Is there anything from an end-user perspective I can verify here?
You can set the pref to confirm that the app doesn't get installed.
No longer blocks: 731054
Whiteboard: [qa+]
Verified on Win 7 64-bit on Nightly.
Status: RESOLVED → VERIFIED
Whiteboard: [qa+] → [qa!]
Flags: in-moztrap-
QA Contact: jsmith
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.