748434 - Text Cut Off in Buttons, Mixed Font Sizes

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Damon Sicore (:damons)]

Attachment: Screenshot showing inconsistent font sizes and cutoff buttons

Visit Bugzilla, attempt to log in, Buttons contain text that is cut off.

See attached screenshot

Galaxy Nexus
14.0a1 (2012-04-24) Nightly

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

ycombinator + button bug

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Seems like either we should (a) be making the button bigger or (b) not inflating it because it's constrained width.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(that should have been bug 708175, but we should see why it wasn't fixed here)

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

also, I don't think this is related to ycombinator. Needs some investigation.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

related to bug 706889?

Comment 6

[Cristian Nicolae (:xti)]

Attachment: vertically cut off screenshot

This issue still occurs on the latest Nightly build.

--
Firefox 15.0a1 (2012-05-23)
Device: Galaxy Nexus
OS: Android 4.0.2

Comment 9

[Scott Johnson (:jwir3)]

Attachment: reduced test case

Here's a reduced test case for this that I created. If we disable the table code, the problem goes away. So, this could be a case of the table cell being a font inflation container, when we really want the button itself to be a font inflation container.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Blocks need to check whether the inflation-disabled-for-intrinsic-width state matches the state that was used for their cached min width before using their cached min width (and need to use a bit to store that).  I don't think anything else other than blocks needs this because blocks are the only things inside of form controls that cache intrinsic widths.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81f6b1cfbba5

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5d6b37f2e13
because the test is failing once I remove my local work for bug 707195 from my tree.  I have no idea why it's making any difference, though.

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d24460a6ee1c
with a workaround as described in the comment in the test, and also an added comment in nsFontInflationData on the same issue.

Comment 15

[Ed Morley [:emorley]]

(In reply to David Baron [:dbaron] from comment #14)
> Relanded:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/d24460a6ee1c
> with a workaround as described in the comment in the test, and also an added
> comment in nsFontInflationData on the same issue.

https://hg.mozilla.org/mozilla-central/rev/d24460a6ee1c

Comment 16

[Jet Villegas (inactive)]

Need FF14 (beta) approval request and uplift on this one.

Comment 17

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 630338 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 706609 (being incomplete)
User impact if declined: text gets cut off in buttons that are inside things that size intrinsically, such as tables and some floats
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): slight performance risk, though probably not significant; also just general risk from adding anything new (though again relatively low)
String or UUID changes made by this patch: none

Comment 18

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/851cdb368ca1
https://hg.mozilla.org/releases/mozilla-beta/rev/16bb2de8a125

Comment 19

[Gabriela [:gaby2300]]

I can verify fixed in Galaxy S2 with Android 2.3.4 and the latest Firebox Beta

Comment 20

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Backed out of Aurora due to perma-orange on Linux PGO Moth.

https://hg.mozilla.org/releases/mozilla-aurora/rev/5838fc84511b

Comment 21

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

relanded successfully:
https://hg.mozilla.org/releases/mozilla-aurora/rev/49541cfaf38f

Comment 22

[Martijn Wargers (dead)]

I'm still seeing cases of text cut off in buttons and mixed font sizes, so I filed bug 766172 and bug 766170.

Comment 23

[Cristian Nicolae (:xti)]

There are still issues regarding the font inflation on regular text (covered by other bugs), but the text is no longer cut off in buttons. Closing bug as verified fixed on:

--
Firefox 16.0a1 (2012-07-09)
Firefox 15.0a2 (2012-07-09)
Firefox 14 Beta

Device: Galaxy Nexus
OS: Android 4.0.4