Closed
Bug 748630
Opened 12 years ago
Closed 12 years ago
Need to support IDBTransaction.error
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: bent.mozilla, Assigned: khuey)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
26.01 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
Need to support IDBTransaction.error. Currently .error only lives on IDBRequest.
Assignee | ||
Comment 1•12 years ago
|
||
Reporter | ||
Comment 2•12 years ago
|
||
Comment on attachment 636310 [details] [diff] [review] Patch Review of attachment 636310 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/indexedDB/IDBTransaction.cpp @@ +530,5 @@ > return NS_OK; > } > > +nsresult > +IDBTransaction::Abort(IDBRequest* aRequest) Assert aRequest and that we're on the main thread. @@ +532,5 @@ > > +nsresult > +IDBTransaction::Abort(IDBRequest* aRequest) > +{ > + nsresult errorCode = aRequest->GetErrorCode(); Nit: no need for the stack variable, just put this into the AbortWithCode call.
Attachment #636310 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4f832cefc08e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Blocks: 822406
Updated•11 years ago
|
Keywords: dev-doc-needed
Comment 4•9 years ago
|
||
Documentation is there: https://developer.mozilla.org/en-US/docs/Web/API/IDBTransaction.error (not specific entry in Fx 16 for developers as covered by the unprefixing of IndexedDB).
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•