The default bug view has changed. See this FAQ.

Need to support IDBTransaction.error

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: Ben Turner (not reading bugmail, use the needinfo flag!), Assigned: khuey)

Tracking

({dev-doc-complete})

unspecified
mozilla16
dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

26.01 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
Need to support IDBTransaction.error. Currently .error only lives on IDBRequest.
Blocks: 726378
Created attachment 636310 [details] [diff] [review]
Patch
Assignee: nobody → khuey
Status: NEW → ASSIGNED
Attachment #636310 - Flags: review?(bent.mozilla)
Blocks: 767999
Comment on attachment 636310 [details] [diff] [review]
Patch

Review of attachment 636310 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/IDBTransaction.cpp
@@ +530,5 @@
>    return NS_OK;
>  }
>  
> +nsresult
> +IDBTransaction::Abort(IDBRequest* aRequest)

Assert aRequest and that we're on the main thread.

@@ +532,5 @@
>  
> +nsresult
> +IDBTransaction::Abort(IDBRequest* aRequest)
> +{
> +  nsresult errorCode = aRequest->GetErrorCode();

Nit: no need for the stack variable, just put this into the AbortWithCode call.
Attachment #636310 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/4f832cefc08e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Blocks: 769537
Blocks: 822406
Keywords: dev-doc-needed
Documentation is there: https://developer.mozilla.org/en-US/docs/Web/API/IDBTransaction.error
(not specific entry in Fx 16 for developers as covered by the unprefixing of IndexedDB).
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.