Closed Bug 748630 Opened 8 years ago Closed 8 years ago

Need to support IDBTransaction.error

Categories

(Core :: Storage: IndexedDB, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: bent.mozilla, Assigned: khuey)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Need to support IDBTransaction.error. Currently .error only lives on IDBRequest.
Attached patch PatchSplinter Review
Assignee: nobody → khuey
Status: NEW → ASSIGNED
Attachment #636310 - Flags: review?(bent.mozilla)
Comment on attachment 636310 [details] [diff] [review]
Patch

Review of attachment 636310 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/IDBTransaction.cpp
@@ +530,5 @@
>    return NS_OK;
>  }
>  
> +nsresult
> +IDBTransaction::Abort(IDBRequest* aRequest)

Assert aRequest and that we're on the main thread.

@@ +532,5 @@
>  
> +nsresult
> +IDBTransaction::Abort(IDBRequest* aRequest)
> +{
> +  nsresult errorCode = aRequest->GetErrorCode();

Nit: no need for the stack variable, just put this into the AbortWithCode call.
Attachment #636310 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/4f832cefc08e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Documentation is there: https://developer.mozilla.org/en-US/docs/Web/API/IDBTransaction.error
(not specific entry in Fx 16 for developers as covered by the unprefixing of IndexedDB).
You need to log in before you can comment on or make changes to this bug.