Last Comment Bug 748630 - Need to support IDBTransaction.error
: Need to support IDBTransaction.error
Status: RESOLVED FIXED
: dev-doc-complete
Product: Core
Classification: Components
Component: DOM: IndexedDB (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
:
: Hsin-Yi Tsai [:hsinyi]
Mentors:
Depends on:
Blocks: 726378 767999 769537 822406
  Show dependency treegraph
 
Reported: 2012-04-24 18:49 PDT by Ben Turner (not reading bugmail, use the needinfo flag!)
Modified: 2014-12-27 05:54 PST (History)
5 users (show)
khuey: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (26.01 KB, patch)
2012-06-25 07:51 PDT, Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
bent.mozilla: review+
Details | Diff | Splinter Review

Description Ben Turner (not reading bugmail, use the needinfo flag!) 2012-04-24 18:49:39 PDT
Need to support IDBTransaction.error. Currently .error only lives on IDBRequest.
Comment 1 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-06-25 07:51:49 PDT
Created attachment 636310 [details] [diff] [review]
Patch
Comment 2 Ben Turner (not reading bugmail, use the needinfo flag!) 2012-06-25 08:13:45 PDT
Comment on attachment 636310 [details] [diff] [review]
Patch

Review of attachment 636310 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/IDBTransaction.cpp
@@ +530,5 @@
>    return NS_OK;
>  }
>  
> +nsresult
> +IDBTransaction::Abort(IDBRequest* aRequest)

Assert aRequest and that we're on the main thread.

@@ +532,5 @@
>  
> +nsresult
> +IDBTransaction::Abort(IDBRequest* aRequest)
> +{
> +  nsresult errorCode = aRequest->GetErrorCode();

Nit: no need for the stack variable, just put this into the AbortWithCode call.
Comment 3 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-06-25 12:18:35 PDT
https://hg.mozilla.org/mozilla-central/rev/4f832cefc08e
Comment 4 Jean-Yves Perrier [:teoli] 2014-12-27 05:54:40 PST
Documentation is there: https://developer.mozilla.org/en-US/docs/Web/API/IDBTransaction.error
(not specific entry in Fx 16 for developers as covered by the unprefixing of IndexedDB).

Note You need to log in before you can comment on or make changes to this bug.