750237 - admin tools unavailable to non-Admin users

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Andrew Williamson [:eviljeff]]

Despite their name, a number of the tools in /admin are used by classes of user that aren't 'Admin'.

According to the contributor spec (See URL):
* /flagged should be available to 'Senior Reviewers' (and 'Staff' by extension)
* Account Lookup and App Lookup (Add-on Lookup) should be available to 'Support Staff' and 'Staff'
* bulk validation, feature manager, and compatibility blacklisting should be available to 'Staff'

The /admin landing page has menus for the above tools and has the only entry point for Account lookup so also needs to be accessible to 'Senior Reviewers', 'Support Staff' and 'Staff'.

As of 6.5.2, the following pages (at least) return a white page with a 'Staff' account:
/admin
/admin/flagged
/admin/addon-search
/admin/compat

If this was being done from scratch I'd suggest a different name and url for the admin tools (Site tools?) to avoid confusion with the 'admin' user class and the admin stuff in /admin/models but its probably overkill.

Comment 1

[Kris Maglione [:kmag]]

/admin/addon/manage also needs to be available to 'Senior Reviewers'

Comment 2

[Mark Banner (:standard8)]

We've just found out this is blocking us doing a compatibility bump for Thunderbird :-(

Comment 3

[Wil Clouser [:clouserw]]

(In reply to Mark Banner (:standard8) from comment #2)
> We've just found out this is blocking us doing a compatibility bump for
> Thunderbird :-(

What URL are you trying to access?

Comment 4

[Andrei Hajdukewycz [:sancus]]

https://addons.mozilla.org/en-US/firefox/en-US/admin/validation is the right place, I believe.

Comment 5

[Mark Banner (:standard8)]

Various:

https://addons.mozilla.org/en-US/admin/validation (blank page)
https://addons.mozilla.org/en-US/firefox/z/en-US/admin/validation
https://addons.mozilla.org/z/en-US/admin/validation (not found)

Comment 6

[Wil Clouser [:clouserw]]

> https://addons.mozilla.org/en-US/admin/validation (blank page)

This is the right one.  Any URLs with /z/ in them are obsolete.

Thanks Rob.

Comment 7

[Mark Banner (:standard8)]

(In reply to Wil Clouser [:clouserw] from comment #6)
> > https://addons.mozilla.org/en-US/admin/validation (blank page)
> 
> This is the right one.  Any URLs with /z/ in them are obsolete.

Right, so that's blank for me.

On a separate note, Jorge has kindly set off the validation run we need for us. So this doesn't block us at the moment, but we'll be looking to run another one within the next couple of weeks.

Comment 8

[Rob Hudson [:robhudson]]

Patch commit for Staff users. I'll follow-up and add Sr Reviewers updates.

https://github.com/mozilla/zamboni/commit/7a2bb9f

Comment 9

[Rob Hudson [:robhudson]]

Patch for Sr Add-on Reviewers:
https://github.com/mozilla/zamboni/commit/0805214

Comment 10

[Kris Maglione [:kmag]]

Confirmed works for me on preview.

Comment 11

[Rob Hudson [:robhudson]]

Commit for new group, "Bulk Compatibility Updaters"
https://github.com/mozilla/zamboni/commit/ab8fcd4 

Someone needs to add Mark Banner to this group for TB bulk validation runs when it hits prod.

Comment 12

[Wil Clouser [:clouserw]]

Added you to the new group