750681 - Reader Mode: Implement/define CSS for articles in the reader

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

The design page has some ideas:

https://wiki.mozilla.org/Fennec/NativeUI/UserExperience/ReaderMode

We need to agree on the big picture:
- Typography (system fonts? custom fonts?)
- Color schemes (white? black? sepia?)
- Image style (magazine style?)
- Text style (paragraph spacing? line spacing? margins?)

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Implement/define CSS for articles in the reader

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 634433 [details] [diff] [review]
Implement/define CSS for articles in the reader

The patch itself is OK, but I have some questions:
* Can we reduce the filesize of the backgrounds? They seem a bit larger and if we could save some space, I'd like to try.
* Can OpenSans be freely redistributed? I want to be sure we are OK to ship it. Are there any restrictions, attribution or other changes that need to happen?

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 634433 [details] [diff] [review]
> * Can OpenSans be freely redistributed? I want to be sure we are OK to ship
> it. Are there any restrictions, attribution or other changes that need to
> happen?

OpenSans is released under the Apache License 2.0:

  http://www.fontsquirrel.com/license/open-sans

...which I assume is compatible with our license? To be honest, I have no idea how to proceed attribution wise.

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

https://www.mozilla.org/MPL/license-policy.html

<quote>
Licenses Compatible with the MPL

The following licenses are compatible with the Mozilla Public License, version 2.0:

    Creative Commons Zero
    Other Public Domain dedications
    MIT, New BSD, and similar permissive licenses
    Apache 2.0
    GPL and MPL dual license
</quote>

cc'ing gerv in case there is something else that needs to be done

Comment 5

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> The patch itself is OK, but I have some questions:
> * Can we reduce the filesize of the backgrounds? They seem a bit larger and
> if we could save some space, I'd like to try.

I'm going to use bug 766164 to track all possible optimizations on the assets used in the Reader UI.

Comment 6

[Gervase Markham [:gerv]]

This is shipping OpenSans as part of B2G, right, not as part of Firefox?

I am currently in the process of figuring out who is responsible for B2G's licensing compliance. But Apache should be fine for a standalone asset like a font.

However, I heard tell that a copy of OpenSans was going to be shipped as a B2G system font, so you may not want to import your own copy.

Gerv

Comment 7

[Lucas Rocha (:lucasr)]

(In reply to Gervase Markham [:gerv] from comment #6)
> This is shipping OpenSans as part of B2G, right, not as part of Firefox?

No, this is a font to ship with Firefox for Android.

Comment 8

[Gervase Markham [:gerv]]

From a licensing perspective, this is fine. Please make sure a copy of the Apache License 2.0 is associated with the copy of OpenSans in the tree, perhaps as a LICENSE file in its directory.

Non-licensing questions:

According to FontSquirrel:
http://www.fontsquirrel.com/fonts/open-sans
OpenSans has a pretty limited set of glyphs; have you talked with the i18n team about how this feature is going to support non-Latin-alphabet languages?

Are we cool with the increase in download size, particularly if we find a way of fixing the above?

The URL in comment 0 doesn't explain why we made a choice not to use Android system fonts. Is there a document somewhere which explains that?

Gerv

Comment 9

[Lucas Rocha (:lucasr)]

(In reply to Gervase Markham [:gerv] from comment #8)
> From a licensing perspective, this is fine. Please make sure a copy of the
> Apache License 2.0 is associated with the copy of OpenSans in the tree,
> perhaps as a LICENSE file in its directory.

Done.

> Non-licensing questions:
> 
> According to FontSquirrel:
> http://www.fontsquirrel.com/fonts/open-sans
> OpenSans has a pretty limited set of glyphs; have you talked with the i18n
> team about how this feature is going to support non-Latin-alphabet languages?

There's platform work being done to support downloading fonts for languages not supported by the system fonts (see bug 619521). We'll probably have to work through i18n issues as we go. I don't want to block on this for now.

> Are we cool with the increase in download size, particularly if we find a
> way of fixing the above?

I think we'll want to support downloading extra fonts on demand as needed, see comment above.

> The URL in comment 0 doesn't explain why we made a choice not to use Android
> system fonts. Is there a document somewhere which explains that?

The typography used in the Reader is a key part of the design and the user experience. The UX team wants the Reader to look unique. We'll have to balance (or build on) that with the i18n requirements. I filed bug 766623 to track this.

Comment 10

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/4ed14a1ce6c2

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4ed14a1ce6c2