751597 - Network geolocation provider fails to get wifi data

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Reuben Morais [:reuben]]

While testing with http://html5demos.com/geo, a friend was getting weird values for the location on Linux. I can reproduce it on OSX. On https://mxr.mozilla.org/mozilla-central/source/dom/system/NetworkGeolocationProvider.js#194 |accessPoints| is always null, and thus we fallback to Google's IP-based lookup. When testing in my own debug build everything works as expected, though.

Comment 1

[Doug Turner (:dougt)]

i don't see this in my local builds either, but it is clearly busted in the nightly.

Components.interfaces.nsIWifiMonitor isn't defined in the nightly.


Reuben,

Could you (and your friend) try one of these builds?  https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-32c03fc9fda6/

Comment 2

[Reuben Morais [:reuben]]

(In reply to Doug Turner (:dougt) from comment #1)
> Reuben,
> 
> Could you (and your friend) try one of these builds? 
> https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-
> 32c03fc9fda6/

Works as expected for me.
Aurora is affected by this so you might wanna land that patch there as well.

Comment 3

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 4

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c675215939ef

Comment 5

[Doug Turner (:dougt)]

.

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c675215939ef

Comment 7

[Doug Turner (:dougt)]

we do want this on 14.

Comment 8

[Alex Keybl [:akeybl]]

Sounds good - please nominate for Aurora 14.

Comment 9

[Reuben Morais [:reuben]]

Comment on attachment 621110 [details] [diff] [review]
patch v.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Geolocation regression
User impact if declined: Geolocation is not accurate.
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): none (?)
String or UUID changes made by this patch: none

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 621110 [details] [diff] [review]
patch v.1

[Triage Comment]
Approved for Aurora 14.

Comment 11

[Reuben Morais [:reuben]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/38cf9bdc6fea