Closed
Bug 751597
Opened 13 years ago
Closed 13 years ago
Network geolocation provider fails to get wifi data
Categories
(Core :: DOM: Geolocation, defect)
Core
DOM: Geolocation
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: reuben, Assigned: dougt)
References
Details
(Keywords: regression)
Attachments
(1 file)
841 bytes,
patch
|
ted
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
While testing with http://html5demos.com/geo, a friend was getting weird values for the location on Linux. I can reproduce it on OSX. On https://mxr.mozilla.org/mozilla-central/source/dom/system/NetworkGeolocationProvider.js#194 |accessPoints| is always null, and thus we fallback to Google's IP-based lookup. When testing in my own debug build everything works as expected, though.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → doug.turner
Assignee | ||
Comment 1•13 years ago
|
||
i don't see this in my local builds either, but it is clearly busted in the nightly.
Components.interfaces.nsIWifiMonitor isn't defined in the nightly.
Reuben,
Could you (and your friend) try one of these builds? https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/dougt@mozilla.com-32c03fc9fda6/
Reporter | ||
Comment 2•13 years ago
|
||
(In reply to Doug Turner (:dougt) from comment #1)
> Reuben,
>
> Could you (and your friend) try one of these builds?
> https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/dougt@mozilla.com-
> 32c03fc9fda6/
Works as expected for me.
Aurora is affected by this so you might wanna land that patch there as well.
Reporter | ||
Updated•13 years ago
|
status-firefox14:
--- → affected
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #621110 -
Flags: review?(ted.mielczarek)
Updated•13 years ago
|
Attachment #621110 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Assignee | ||
Comment 5•13 years ago
|
||
.
Assignee | ||
Updated•13 years ago
|
tracking-firefox14:
--- → ?
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Assignee | ||
Comment 7•13 years ago
|
||
we do want this on 14.
Reporter | ||
Comment 9•13 years ago
|
||
Comment on attachment 621110 [details] [diff] [review]
patch v.1
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Geolocation regression
User impact if declined: Geolocation is not accurate.
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): none (?)
String or UUID changes made by this patch: none
Attachment #621110 -
Flags: approval-mozilla-aurora?
Comment 10•13 years ago
|
||
Comment on attachment 621110 [details] [diff] [review]
patch v.1
[Triage Comment]
Approved for Aurora 14.
Attachment #621110 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter | ||
Comment 11•13 years ago
|
||
Updated•13 years ago
|
Updated•13 years ago
|
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•