Set background of standalone images (the image itself, not the whole page) to white

RESOLVED FIXED in mozilla15

Status

()

Toolkit
Themes
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: bz, Assigned: jaws)

Tracking

(Blocks: 1 bug)

11 Branch
mozilla15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

See discussion in mozilla.dev.apps.firefox earlier today.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Created attachment 622999 [details] [diff] [review]
Patch for bug
Attachment #622999 - Flags: review?(bzbarsky)
Whiteboard: [autoland-try]
Whiteboard: [autoland-try]
Whiteboard: [autoland-try:-b do -p linux,macosx64,win32 -u reftest -t none]

Updated

5 years ago
Whiteboard: [autoland-try:-b do -p linux,macosx64,win32 -u reftest -t none] → [autoland-in-queue]
Comment on attachment 622999 [details] [diff] [review]
Patch for bug

r=me
Attachment #622999 - Flags: review?(bzbarsky) → review+

Updated

5 years ago
Component: Layout → Themes
OS: Mac OS X → All
Product: Core → Toolkit
QA Contact: layout → themes
Hardware: x86 → All

Comment 3

5 years ago
(In reply to Boris Zbarsky (:bz) from comment #0)
> See discussion in mozilla.dev.apps.firefox earlier today.

Here, I'm guessing:

http://groups.google.com/group/mozilla.dev.apps.firefox/browse_thread/thread/827a52f71d092748

Glad to see some action on this.

Comment 4

5 years ago
Use to get a patterned background like in image editors (PSD, Paint.net, etc):
background:-moz-Dialog url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQAQMAAAAlPW0iAAAABlBMVEWgoKClpaUrSK7yAAAAAnRSTlNkFG3Yt+YAAAAPSURBVHheY2D4jxXhEgYAfr8P8SM7T18AAAAASUVORK5CYII=);
(In reply to Alfred Kayser from comment #4)
> Use to get a patterned background like in image editors

Please file a separate bug on this. (I think we might actually want to try this, depending on how this bug will be received.)

Comment 6

5 years ago
In case this is useful to Boris, here are my reasonings on this one from a previous bug - https://bugzilla.mozilla.org/show_bug.cgi?id=713555#c24

Good luck. :)
Just hope this bug won't be hijacked and closed like bug #713555, hhich have the only good concept with dealing with transparent images, compared to using black or black background.

Comment 8

5 years ago
Autoland Patchset:
	Patches: 622999
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=93291ada1202
Try run started, revision 93291ada1202. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=93291ada1202

Updated

5 years ago
Blocks: 754539
This test is failing on Windows in the try push:
> REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/test/build/reftest/tests/image/test/reftest/icon/win/bug415761.sjs | image comparison (==)
Whiteboard: [autoland-in-queue]
Created attachment 623851 [details] [diff] [review]
Patch for bug v2

This patch changes bug415761.sjs to explicitly set the icon dimensions.

On the other hand, I think that this test is actually quite broken, and writing this patch revealed the broken-ness. The test previously passed because we were testing a white background against a white background. It then passed because we were testing a dark grey background against a dark grey background. It only started failing now because we started explicitly setting a background-color for the image.
Attachment #622999 - Attachment is obsolete: true
Attachment #623851 - Flags: review?(bzbarsky)
Whiteboard: [autoland-try:-b do -p linux,macosx64,win32 -u reftest -t none]

Updated

5 years ago
Whiteboard: [autoland-try:-b do -p linux,macosx64,win32 -u reftest -t none] → [autoland-in-queue]

Comment 11

5 years ago
Autoland Patchset:
	Patches: 623851
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=6699388d2f96
Try run started, revision 6699388d2f96. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=6699388d2f96
Comment on attachment 623851 [details] [diff] [review]
Patch for bug v2

r=me
Attachment #623851 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/836e451c8b77
Whiteboard: [autoland-in-queue]
Target Milestone: --- → mozilla15
Version: unspecified → 11 Branch
https://hg.mozilla.org/mozilla-central/rev/836e451c8b77
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago

Updated

5 years ago
Depends on: 756419

Updated

5 years ago
Duplicate of this bug: 743474

Comment 16

5 years ago
A mockup was posted by Stephen to deal with specific images requiring white background etc

https://people.mozilla.com/~shorlander/files/stand-alone-image/stand-alone-image-01.html

Is it in plans ?
Blocks: 783874

Updated

4 years ago
Duplicate of this bug: 728085
Blocks: 1089880
You need to log in before you can comment on or make changes to this bug.