754133 - Set background of standalone images (the image itself, not the whole page) to white

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See discussion in mozilla.dev.apps.firefox earlier today.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for bug

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 622999 [details] [diff] [review]
Patch for bug

r=me

Comment 3

[Mark Goodhand]

(In reply to Boris Zbarsky (:bz) from comment #0)
> See discussion in mozilla.dev.apps.firefox earlier today.

Here, I'm guessing:

http://groups.google.com/group/mozilla.dev.apps.firefox/browse_thread/thread/827a52f71d092748

Glad to see some action on this.

Comment 4

[Alfred Kayser]

Use to get a patterned background like in image editors (PSD, Paint.net, etc):
background:-moz-Dialog url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQAQMAAAAlPW0iAAAABlBMVEWgoKClpaUrSK7yAAAAAnRSTlNkFG3Yt+YAAAAPSURBVHheY2D4jxXhEgYAfr8P8SM7T18AAAAASUVORK5CYII=);

Comment 5

[Dão Gottwald [:dao]]

(In reply to Alfred Kayser from comment #4)
> Use to get a patterned background like in image editors

Please file a separate bug on this. (I think we might actually want to try this, depending on how this bug will be received.)

Comment 6

[Frank Lion]

In case this is useful to Boris, here are my reasonings on this one from a previous bug - https://bugzilla.mozilla.org/show_bug.cgi?id=713555#c24

Good luck. :)

Comment 7

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Just hope this bug won't be hijacked and closed like bug #713555, hhich have the only good concept with dealing with transparent images, compared to using black or black background.

Comment 8

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 622999
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=93291ada1202
Try run started, revision 93291ada1202. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=93291ada1202

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

This test is failing on Windows in the try push:
> REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/test/build/reftest/tests/image/test/reftest/icon/win/bug415761.sjs | image comparison (==)

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for bug v2

This patch changes bug415761.sjs to explicitly set the icon dimensions.

On the other hand, I think that this test is actually quite broken, and writing this patch revealed the broken-ness. The test previously passed because we were testing a white background against a white background. It then passed because we were testing a dark grey background against a dark grey background. It only started failing now because we started explicitly setting a background-color for the image.

Comment 11

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 623851
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=6699388d2f96
Try run started, revision 6699388d2f96. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=6699388d2f96

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 623851 [details] [diff] [review]
Patch for bug v2

r=me

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/836e451c8b77

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/836e451c8b77

Comment 16

[bogas04]

A mockup was posted by Stephen to deal with specific images requiring white background etc

https://people.mozilla.com/~shorlander/files/stand-alone-image/stand-alone-image-01.html

Is it in plans ?