Status

mozilla.org
Licensing
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: gerv, Assigned: gerv)

Tracking

Details

Attachments

(1 attachment)

This bug tracks the MPL 2 upgrade for the project named in the subject line.
The repo is here: 
http://hg.mozilla.org/projects/ionmonkey/

Gerv

Comment 1

6 years ago
Ionmonkey is just a clone of mozilla-central that pulls regularly from it, so this is most likely a dupe of bug 716478.
But there's a load of new code inside the clone, right? in js/src/ion?

Gerv

Comment 3

6 years ago
Sorry yeah you're right, I hadn't seen up until now how many more files have been added to the tree that aren't present in m-c so won't get the changes from bug 716478.
dmandelin: I assume it's OK to produce a patch here? Which directories do I need to pay attention to?

Gerv
dmandelin: ping?

Gerv
(In reply to Gervase Markham [:gerv] from comment #5)
> dmandelin: ping?

I emailed too, but FTR, it's just the ion directory.
Created attachment 643645 [details] [diff] [review]
Update IonMonkey to MPL2.

Quick! Before we add a bunch of new files!

IonMonkey is a small project, so I just updated the license text by hand. Might as well get it done now.

We had a bunch of different formatting styles floating around. The SM coding guidelines specify that code wraps at the 100th column, so this standardizes to that.
Attachment #643645 - Flags: review?(gerv)
Attachment #643645 - Flags: review?(dvander)
(In reply to Sean Stangl from comment #7)
> Quick! Before we add a bunch of new files!

:-)

> IonMonkey is a small project, so I just updated the license text by hand.
> Might as well get it done now.

I'm happy to use my script...
 
> We had a bunch of different formatting styles floating around. The SM coding
> guidelines specify that code wraps at the 100th column, so this standardizes
> to that.

You've also changed the tab width from 8 to 4 in the modelines in some files. Was that intentional?

The boilerplate should use the standard formatting, which you've done, so thanks for that. It's better if it is its own comment rather than being part of the same comment as the modelines, but that's not essential.

So r=gerv if you actually meant to make all those modeline changes.

Gerv
Attachment #643645 - Flags: review?(gerv) → review+
Attachment #643645 - Flags: review?(dvander) → review+
http://hg.mozilla.org/projects/ionmonkey/rev/e6a6ab12a7bb
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.