Closed
Bug 754256
Opened 12 years ago
Closed 12 years ago
MPL 2 upgrade: IonMonkey
Categories
(mozilla.org :: Licensing, task)
mozilla.org
Licensing
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gerv, Assigned: gerv)
References
Details
Attachments
(1 file)
367.69 KB,
patch
|
gerv
:
review+
dvander
:
review+
|
Details | Diff | Splinter Review |
This bug tracks the MPL 2 upgrade for the project named in the subject line. The repo is here: http://hg.mozilla.org/projects/ionmonkey/ Gerv
Comment 1•12 years ago
|
||
Ionmonkey is just a clone of mozilla-central that pulls regularly from it, so this is most likely a dupe of bug 716478.
Assignee | ||
Comment 2•12 years ago
|
||
But there's a load of new code inside the clone, right? in js/src/ion? Gerv
Comment 3•12 years ago
|
||
Sorry yeah you're right, I hadn't seen up until now how many more files have been added to the tree that aren't present in m-c so won't get the changes from bug 716478.
Assignee | ||
Comment 4•12 years ago
|
||
dmandelin: I assume it's OK to produce a patch here? Which directories do I need to pay attention to? Gerv
Assignee | ||
Comment 5•12 years ago
|
||
dmandelin: ping? Gerv
Comment 6•12 years ago
|
||
(In reply to Gervase Markham [:gerv] from comment #5) > dmandelin: ping? I emailed too, but FTR, it's just the ion directory.
Comment 7•12 years ago
|
||
Quick! Before we add a bunch of new files! IonMonkey is a small project, so I just updated the license text by hand. Might as well get it done now. We had a bunch of different formatting styles floating around. The SM coding guidelines specify that code wraps at the 100th column, so this standardizes to that.
Attachment #643645 -
Flags: review?(gerv)
Attachment #643645 -
Flags: review?(dvander)
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to Sean Stangl from comment #7) > Quick! Before we add a bunch of new files! :-) > IonMonkey is a small project, so I just updated the license text by hand. > Might as well get it done now. I'm happy to use my script... > We had a bunch of different formatting styles floating around. The SM coding > guidelines specify that code wraps at the 100th column, so this standardizes > to that. You've also changed the tab width from 8 to 4 in the modelines in some files. Was that intentional? The boilerplate should use the standard formatting, which you've done, so thanks for that. It's better if it is its own comment rather than being part of the same comment as the modelines, but that's not essential. So r=gerv if you actually meant to make all those modeline changes. Gerv
Assignee | ||
Updated•12 years ago
|
Attachment #643645 -
Flags: review?(gerv) → review+
Updated•12 years ago
|
Attachment #643645 -
Flags: review?(dvander) → review+
Comment 9•12 years ago
|
||
http://hg.mozilla.org/projects/ionmonkey/rev/e6a6ab12a7bb
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•