756438 - Implement AppBar scripting interface and build AppBar content dynamcally

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Jim Mathies [:jimm]]

Currently we have static AppBar markup embedded in platform code. This should probably be replaced with dynamic generated content controlled through content via a scriptable interface. I think having default buttons would be ok, but resources like button labels and layout need to be controlled by front end code.

http://mxr.mozilla.org/projects-central/source/elm/widget/windows/winrt/MainPage.cpp

Comment 1

[Brian R. Bondy [:bbondy]]

Initial implementation:
http://hg.mozilla.org/projects/elm/rev/35da5ac3cdbb

Details:
- I created a new XBL control called appbar, you can manually add items to it, typically toolbarbuttons.
- I used that appbar control inside browser.xul.
- I used the icons provided by shorlander for the appbar
- It exposes a method for show() and dismiss(), and later we'll add more. 
- It automatically takes care of auto-dismissing when you click outside of the appbar.
- The menubutton isn't working yet, because xul menus aren't working correctly in Metro
- I just added all buttons for now in an arbitrary order, I'll need to fix that later to be to spec.

Comment 2

[Brian R. Bondy [:bbondy]]

windows button + Z will show the appbar at any time, I landed with it showing originally but I'll remove that soon with some other small changes.

Comment 3

[Brian R. Bondy [:bbondy]]

Added events for showing/hiding and registered for it.  Inside the handler I use the SecondaryTile::Exists API but it has a bug in it currently.  So as of right now detection doesn't work for if a tile is pinned.  IE has the same problem with detection right now.

Comment 4

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/projects/elm/rev/87fdd0673614

Comment 6

[Brian R. Bondy [:bbondy]]

elm -> m-c