854269 - Defect - "Pin" still selected when pressing "Back" or "Forward" buttons

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: App Bar, defect, P1)

Description

[Kamil Jozwiak [:kjozwiak]]

When pinning a website using the "Pin" feature from the App Bar, pressing the "Previous" or "Back" buttons will not dismiss the App Bar and the "Pin" will still appear as "Enabled" even when you have changed the website. Dismissing the App Bar fixes this issue.

Steps to reproduce the issue:

1) Open Firefox Metro
2) Go to any website (doesn't matter which one)
3) Open the App Bar using Windows + Z
4) Select the "Pin" icon and accept the "Pin to Start" window
5) Select the "Back" or "Forward" button and you will notice that the App Bar isn't dismissed and the "Pin" icon is still enabled

Actual Results:

- Pressing the "Previous" or "Back" buttons doesn't dismiss the App Bar and makes it look like the current website is also pinned

Expected Results:

- Pressing the "Previous" or "Back" buttons should dismiss the App Bar if its currently visible.

Comment 1

[Brian R. Bondy [:bbondy]]

Trivial to implement, possible for an iteration 5 defect?

Comment 2

[Brian R. Bondy [:bbondy]]

bug 756438 would have been a story if we would have had iterations back then.

Comment 3

[Marco Mucci [:MarcoM]]

We can put this forward as a defect for iteration #5.

Comment 4

[Brian R. Bondy [:bbondy]]

Based on Comment #3 I think it5 was meant to be added as a blocker. I added it in and I'll take this bug.

Comment 5

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

Also handle a similar case when you switch tabs via a keyboard shortcut and the appbar doesn't dismiss.

Comment 6

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 731141 [details] [diff] [review]
Patch v1.

Review of attachment 731141 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks for this

Comment 7

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ab0587c3ed5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0ab0587c3ed5

Comment 9

[juan becerra [:juanb]]

Tested on 2013-04-08 using a Nightly built from http://hg.mozilla.org/mozilla-central/rev/b0d842380959
- Tested using the steps in comment #0 and now the app bar is dismissed when going back and forth or when cycling through the tabs in the strip using the ctrl-tab keyboard shortcut.
- The app bar is also dismissed if I use alt-arrow (right or left) and I go back or forward.
- I can pin and unpin pages.
- Bringing up the app bar shows the pin icon unselected.

Comment 10

[raymond [:retornam] (inactive)]

Tested using 
April 8th, 2012  built from http://hg.mozilla.org/mozilla-central/rev/b0d842380959

Using the Back and Forward buttons after pinning an website now dismisses the App Bar if it is visible.  I noticed that the pin is not enabled for a website that has already been pinned. I checked in IE and it also does not show the pin as enabled for a website that has already been pinned

Comment 11

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration testing. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-13-03-09-27-mozilla-central/

Went through the following tests to ensure that issue has been resolved:

- Went through all the steps outlined in Comment 0 and made sure the "Pin" icon is deselected
- Went through all the steps outlined in Comment 9 and made sure the "Pin" icon is deselected
- Ensured that the "App Bar" is dismissed when creating a new tab and the "Pin" icon is deselected
- Ensured that the "App Bar" is dismissed when selecting the "Refresh" button and the "Pin" icon is deselected
- Ensured that the "App Bar" is dismissed when selecting "Help (online)" through the "Settings" charm and the "Pin" icon is deselected

Comment 12

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #6 testing. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-30-03-09-41-mozilla-central/

- Went through all the test cases added in the various comments above without any issues
- Ensured that the Junior-style "New Tab" and "Back" buttons on the sides dismissed the "App Bar" and the "Pin" icon is deselected

Comment 13

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #8 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-16-03-11-39-mozilla-central/

- Went through all the steps outlined in Comment 0 without any issues
- Went through all the steps outlined in Comment 9 without any issues
- "Pinned" a website and then selected a new tab using the overlay button and ensured that the awesome screen "Pin" button was not enabled
- "Pinned" a website and then selected a new tab using the "+" button under the "Tab Navigation App Bar" and ensured that the awesome screen "Pin" button was not enabled
- Ensured that pressing "CTRL + T" from a page that has been "Pinned" will create a new tab, dismiss the "Navigation App Bar" and made sure that the "Pin" was not enabled

Comment 14

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and app bar didn't dismiss.