base.html contains our header and footer and has hardcoded strings, I need these strings for Basecamp related pages. I will make pull requests to get those strings translatable. I will not enclose all strings yet because some of the text on this page, specifically the creative commons mention, needs a technical change to externalize the year and the url outside of the string. I will file a separate bug for this one.
Commits pushed to dev at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/31a7eda6a7ed743af57d5857b534d745b956dac4 Bug 758596 - [l10n] make base.html on mozilla.org translatable https://github.com/mozilla/bedrock/commit/8d6b6c77e7b5586e02bc9943c9bace151c0af970 Merge pull request #124 from pascalchevrel/l10n-Bug758596 Bug 758596 - [l10n] make base.html on mozilla.org translatable
Commit pushed to dev at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/40797b1345860b22309e32c8b94e392d64e3e83a Merge pull request #123 from pascalchevrel/l10n-Bug758596 Bug 758596 - [l10n] make base.html on mozilla.org translatable
Just a note, we now also have a base-resp.html template now that was done for the mobile release.
To confirm, with the recent move of /contribute to the responsive layout (bug 770976) the changes from pull request #124 no longer apply to the page since it's using the responsive template now? I'm just trying to confirm if this is still a relevant blocker for Get Involved localization or not.
I just took a look and base-resp.html has the all the strings marked for L10N. So it's good to go. Closing.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
Code in production, verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.